-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[CD] Do not build pytorch with nvshem on ARM #160465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160465
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 143 PendingAs of commit d2920b5 with merge base 9903ca4 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
| # MAX_JOB=5 is not required for CPU backend (see commit 465d98b) | ||
| if enable_cuda: | ||
| build_vars = "MAX_JOBS=5 " + build_vars | ||
| build_vars+ = "MAX_JOBS=5 " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| build_vars+ = "MAX_JOBS=5 " | |
| build_vars += "MAX_JOBS=5 " |
|
@pytorchbot merge -f "Let's test in PROD" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
As nvshmem binary from 3.3.9 is not compatible with manylinux2_28, and 3.3.20 is not available for download yet Also, package nvshmem binary into full wheel Fixes #160425 Pull Request resolved: #160465 Approved by: https://github.com/atalman, https://github.com/huydhn
Fix typo after #160465 Fixes: #160762 Pull Request resolved: #160778 Approved by: https://github.com/Camyll, https://github.com/malfet, https://github.com/ZainRizvi, https://github.com/Skylion007
As nvshmem binary from 3.3.9 is not compatible with manylinux2_28, and 3.3.20 is not available for download yet Also, package nvshmem binary into full wheel Fixes #160425 Pull Request resolved: #160465 Approved by: https://github.com/atalman, https://github.com/huydhn
As nvshmem binary from 3.3.9 is not compatible with manylinux2_28, and 3.3.20 is not available for download yet Also, package nvshmem binary into full wheel Fixes pytorch#160425 Pull Request resolved: pytorch#160465 Approved by: https://github.com/atalman, https://github.com/huydhn
Fix typo after pytorch#160465 Fixes: pytorch#160762 Pull Request resolved: pytorch#160778 Approved by: https://github.com/Camyll, https://github.com/malfet, https://github.com/ZainRizvi, https://github.com/Skylion007
As nvshmem binary from 3.3.9 is not compatible with manylinux2_28, and 3.3.20 is not available for download yet Also, package nvshmem binary into full wheel Fixes pytorch#160425 Pull Request resolved: pytorch#160465 Approved by: https://github.com/atalman, https://github.com/huydhn
Fix typo after pytorch#160465 Fixes: pytorch#160762 Pull Request resolved: pytorch#160778 Approved by: https://github.com/Camyll, https://github.com/malfet, https://github.com/ZainRizvi, https://github.com/Skylion007
Stack from ghstack (oldest at bottom):
As nvshmem binary from 3.3.9 is not compatible with manylinux2_28, and 3.3.20 is not available for download yet
Also, package nvshmem binary into full wheel
Fixes #160425