KEMBAR78
[CD] Do not build pytorch with nvshem on ARM by malfet · Pull Request #160465 · pytorch/pytorch · GitHub
Skip to content

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Aug 12, 2025

Stack from ghstack (oldest at bottom):

As nvshmem binary from 3.3.9 is not compatible with manylinux2_28, and 3.3.20 is not available for download yet
Also, package nvshmem binary into full wheel

Fixes #160425

[ghstack-poisoned]
@malfet malfet requested a review from a team as a code owner August 12, 2025 21:26
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160465

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 143 Pending

As of commit d2920b5 with merge base 9903ca4 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

malfet added a commit that referenced this pull request Aug 12, 2025
As nvshmem binary from 3.3.9 is not compatible with manylinux2_28, and 3.3.20 is not available for download yet

Fixes #160425

ghstack-source-id: ad78c31
Pull Request resolved: #160465
@atalman atalman added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Aug 12, 2025
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

# MAX_JOB=5 is not required for CPU backend (see commit 465d98b)
if enable_cuda:
build_vars = "MAX_JOBS=5 " + build_vars
build_vars+ = "MAX_JOBS=5 "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
build_vars+ = "MAX_JOBS=5 "
build_vars += "MAX_JOBS=5 "

[ghstack-poisoned]
malfet added a commit that referenced this pull request Aug 13, 2025
As nvshmem binary from 3.3.9 is not compatible with manylinux2_28, and 3.3.20 is not available for download yet

Fixes #160425

ghstack-source-id: 7da6346
Pull Request resolved: #160465
[ghstack-poisoned]
malfet added a commit that referenced this pull request Aug 13, 2025
As nvshmem binary from 3.3.9 is not compatible with manylinux2_28, and 3.3.20 is not available for download yet

Fixes #160425

ghstack-source-id: 508aad3
Pull Request resolved: #160465
@malfet
Copy link
Contributor Author

malfet commented Aug 13, 2025

@pytorchbot merge -f "Let's test in PROD"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

chuanhaozhuge pushed a commit that referenced this pull request Aug 14, 2025
As nvshmem binary from 3.3.9 is not compatible with manylinux2_28, and 3.3.20 is not available for download yet
Also, package nvshmem binary into full wheel

Fixes #160425
Pull Request resolved: #160465
Approved by: https://github.com/atalman, https://github.com/huydhn
chuanhaozhuge pushed a commit that referenced this pull request Aug 18, 2025
As nvshmem binary from 3.3.9 is not compatible with manylinux2_28, and 3.3.20 is not available for download yet
Also, package nvshmem binary into full wheel

Fixes #160425
Pull Request resolved: #160465
Approved by: https://github.com/atalman, https://github.com/huydhn
can-gaa-hou pushed a commit to can-gaa-hou/pytorch that referenced this pull request Aug 22, 2025
As nvshmem binary from 3.3.9 is not compatible with manylinux2_28, and 3.3.20 is not available for download yet
Also, package nvshmem binary into full wheel

Fixes pytorch#160425
Pull Request resolved: pytorch#160465
Approved by: https://github.com/atalman, https://github.com/huydhn
@github-actions github-actions bot deleted the gh/malfet/485/head branch September 13, 2025 02:05
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
As nvshmem binary from 3.3.9 is not compatible with manylinux2_28, and 3.3.20 is not available for download yet
Also, package nvshmem binary into full wheel

Fixes pytorch#160425
Pull Request resolved: pytorch#160465
Approved by: https://github.com/atalman, https://github.com/huydhn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries Trigger all binary build and upload jobs on the PR Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants