Fix typo packing libnvshmem into libtorch #160778
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160778
Note: Links to docs will display an error until the docs builds have been completed. ❌ 14 New Failures, 39 PendingAs of commit 4c96362 with merge base fa75ba9 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
atalman
changed the title
seemethere
reviewed
Aug 15, 2025
Maybe a better question is why didn't CI catch this? |
Camyll
approved these changes
Aug 15, 2025
|
@seemethere I believe this is the reason : #160465 (comment) :) |
atalman
added
the
ciflow/binaries
malfet
approved these changes
Aug 15, 2025
@atalman this disables it for ARM, but you are fixing typo for x86_64 |
ZainRizvi
approved these changes
Aug 15, 2025
Skylion007
approved these changes
Aug 15, 2025
|
@pytorchbot merge -f "XPU failures are bogus" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
can-gaa-hou
pushed a commit
to can-gaa-hou/pytorch
that referenced
this pull request
Aug 22, 2025
Fix typo after pytorch#160465 Fixes: pytorch#160762 Pull Request resolved: pytorch#160778 Approved by: https://github.com/Camyll, https://github.com/malfet, https://github.com/ZainRizvi, https://github.com/Skylion007
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
Fix typo after pytorch#160465 Fixes: pytorch#160762 Pull Request resolved: pytorch#160778 Approved by: https://github.com/Camyll, https://github.com/malfet, https://github.com/ZainRizvi, https://github.com/Skylion007
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typo after #160465
Fixes: #160762