-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Move to small wheel approach for CUDA SBSA wheel #160720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160720
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 9 Pending, 16 Unrelated FailuresAs of commit 3f3d1b2 with merge base 8906266 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| "/usr/local/lib/libnvpl_lapack_lp64_gomp.so.0", | ||
| "/usr/local/lib/libnvpl_blas_lp64_gomp.so.0", | ||
| "/usr/local/lib/libnvpl_lapack_core.so.0", | ||
| "/usr/local/lib/libnvpl_blas_core.so.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are nvpl-blas nvpl-lapack in PyPi, so we can utilize those as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Aidyn! let me try pulling those two as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might have to do it on a later stage, haven't tested nvpl-blas and nvpl-lapack with pypi before.
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
a374266 to
fa75e50
Compare
98a3ee2 to
d570a4e
Compare
|
Build for sbsa build was successful. If just install through |
|
After successful installation, seeing this error 1st check: RPATH not set 2nd check: |
|
After fixing RPATH with , new error Through LD_DEBUG, can see that libtorch_python.so is loading libtorch.so, so need to fix RPATH for libtorch_python.so |
|
Need to fix the RPATH for all libs loading pypi deps in |
|
Moving from zip to wheel pack will be in Andrey's PR #159481 |
|
Verified 13.0 wheel passes. Follow up:
|
|
@pytorchmergebot merge -f "lint and build looks good" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
I'm also seeing an import error trying to load It's probably coming from this PR. Any thoughts? @Aidyn-A @tinglvv |
|
pytorch#160673 Use download.pytorch.org's dependencies like x86 build instead of bundling libs into the wheel Pull Request resolved: pytorch#160720 Approved by: https://github.com/atalman
pytorch#160673 Use download.pytorch.org's dependencies like x86 build instead of bundling libs into the wheel Pull Request resolved: pytorch#160720 Approved by: https://github.com/atalman
pytorch#160673 Use download.pytorch.org's dependencies like x86 build instead of bundling libs into the wheel Pull Request resolved: pytorch#160720 Approved by: https://github.com/atalman
pytorch#160673 Use download.pytorch.org's dependencies like x86 build instead of bundling libs into the wheel Pull Request resolved: pytorch#160720 Approved by: https://github.com/atalman
#160673
Use download.pytorch.org's dependencies like x86 build instead of bundling libs into the wheel
cc @seemethere @malfet @atalman @ptrblck @msaroufim @eqy @jerryzh168 @snadampal @milpuz01 @aditew01 @nikhil-arm @fadara01 @nWEIdia