[ONNX] Refactor torchscript based exporter #161323

justinchuby · 2025-08-22T23:10:42Z

Stack from ghstack (oldest at bottom):

Refactor torchscript based exporter logic to move them to a single (private) location for better code management. Original public module and method apis are preserved.

Updated module paths in torch/csrc/autograd/python_function.cpp accordingly
Removed check_onnx_broadcast from torch/autograd/_functions/utils.py because it is private&unused

@albanD / @soulitzer could you review changes in torch/csrc/autograd/python_function.cpp and
torch/autograd/_functions/utils.py? Thanks!

BC Breaking

Deprecated members in torch.onnx.verification are removed

cc @titaiwangms @albanD

Differential Revision: D81236421

[ghstack-poisoned]

pytorch-bot · 2025-08-22T23:10:45Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161323

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

ROCm MI2xx CI/CD workflows failing due to : download from https://api.github.com/repos/pytorch/pytorch timed out.

✅ No Failures

As of commit 153c848 with merge base 378edb0 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> ghstack-source-id: 0a2854e Pull Request resolved: #161323

[ghstack-poisoned]

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> ghstack-source-id: 1c4e008 Pull Request resolved: #161323 Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> ghstack-source-id: 1c4e008 Pull Request resolved: pytorch#161323 Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

[ghstack-poisoned]

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> ghstack-source-id: 027c5bd Pull Request resolved: #161323 Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

[ghstack-poisoned]

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> ghstack-source-id: 34a7ba7 Pull Request resolved: #161323 Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

[ghstack-poisoned]

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> ghstack-source-id: 64d66f1 Pull Request resolved: pytorch#161323 Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

[ghstack-poisoned]

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> ghstack-source-id: 36ef09c Pull Request resolved: pytorch#161323 Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

angelayi · 2025-08-28T15:27:17Z

@angelayi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

test/onnx/test_utility_funs.py

docs/source/onnx_verification.md

[ghstack-poisoned]

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> ghstack-source-id: 31e64f4 Pull Request resolved: pytorch#161323 Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

angelayi · 2025-08-29T22:18:45Z

@angelayi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

justinchuby · 2025-09-02T16:02:30Z

@pytorchbot merge

pytorchmergebot · 2025-09-02T16:04:43Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-09-02T16:06:54Z

Starting merge as part of PR stack under #161449

pytorchmergebot · 2025-09-02T16:06:56Z

Starting merge as part of PR stack under #161546

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Pull Request resolved: #161449 Approved by: https://github.com/xadupre, https://github.com/titaiwangms ghstack dependencies: #161323

Remove import of two functions - _run_symbolic_function - _run_symbolic_method to the `torch.onnx` namespace. Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Pull Request resolved: #161546 Approved by: https://github.com/titaiwangms ghstack dependencies: #161323, #161449

@albanD

Refactor torchscript based exporter logic to move them to a single (private) location for better code management. Original public module and method apis are preserved. - Updated module paths in `torch/csrc/autograd/python_function.cpp` accordingly - Removed `check_onnx_broadcast` from `torch/autograd/_functions/utils.py` because it is private&unused @albanD / @soulitzer could you review changes in `torch/csrc/autograd/python_function.cpp` and `torch/autograd/_functions/utils.py`? Thanks! ## BC Breaking - **Deprecated members in `torch.onnx.verification` are removed** Differential Revision: [D81236421](https://our.internmc.facebook.com/intern/diff/D81236421) Pull Request resolved: pytorch#161323 Approved by: https://github.com/titaiwangms, https://github.com/angelayi

…#161449) Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Pull Request resolved: pytorch#161449 Approved by: https://github.com/xadupre, https://github.com/titaiwangms ghstack dependencies: pytorch#161323

Remove import of two functions - _run_symbolic_function - _run_symbolic_method to the `torch.onnx` namespace. Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Pull Request resolved: pytorch#161546 Approved by: https://github.com/titaiwangms ghstack dependencies: pytorch#161323, pytorch#161449

@albanD

Refactor torchscript based exporter logic to move them to a single (private) location for better code management. Original public module and method apis are preserved. - Updated module paths in `torch/csrc/autograd/python_function.cpp` accordingly - Removed `check_onnx_broadcast` from `torch/autograd/_functions/utils.py` because it is private&unused @albanD / @soulitzer could you review changes in `torch/csrc/autograd/python_function.cpp` and `torch/autograd/_functions/utils.py`? Thanks! ## BC Breaking - **Deprecated members in `torch.onnx.verification` are removed** Differential Revision: [D81236421](https://our.internmc.facebook.com/intern/diff/D81236421) Pull Request resolved: pytorch#161323 Approved by: https://github.com/titaiwangms, https://github.com/angelayi

…#161449) Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Pull Request resolved: pytorch#161449 Approved by: https://github.com/xadupre, https://github.com/titaiwangms ghstack dependencies: pytorch#161323

Remove import of two functions - _run_symbolic_function - _run_symbolic_method to the `torch.onnx` namespace. Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Pull Request resolved: pytorch#161546 Approved by: https://github.com/titaiwangms ghstack dependencies: pytorch#161323, pytorch#161449

Update

277abf1

[ghstack-poisoned]

justinchuby requested a review from titaiwangms as a code owner August 22, 2025 23:10

justinchuby mentioned this pull request Aug 22, 2025

[ONNX] Remove unused _onnx_supported_ops #161322

Closed

pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Aug 22, 2025

justinchuby added a commit that referenced this pull request Aug 22, 2025

[ONNX] Refactor torchscript based exporter

e456352

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> ghstack-source-id: 0a2854e Pull Request resolved: #161323

pytorchbot added the open source label Aug 22, 2025

Update

891ab5d

[ghstack-poisoned]

justinchuby added the module: onnx Related to torch.onnx label Aug 22, 2025

justinchuby marked this pull request as draft August 22, 2025 23:19

Update

6737047

[ghstack-poisoned]

justinchuby added topic: bc breaking topic category suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) labels Aug 25, 2025

justinchuby marked this pull request as ready for review August 25, 2025 22:18

justinchuby requested review from albanD and soulitzer as code owners August 25, 2025 22:18

justinchuby closed this Aug 25, 2025

justinchuby reopened this Aug 25, 2025

Update

e4a27f7

[ghstack-poisoned]

Update

27222fa

[ghstack-poisoned]

justinchuby mentioned this pull request Aug 25, 2025

[ONNX] Remove unused logic from internal verification module #161449

Closed

justinchuby added the keep-going Don't stop on first failure, keep running tests until the end label Aug 27, 2025

Update

b9f35da

[ghstack-poisoned]

justinchuby added ciflow/trunk Trigger trunk jobs on your pull request skip-pr-sanity-checks labels Aug 27, 2025

xadupre reviewed Aug 28, 2025

View reviewed changes

test/onnx/test_utility_funs.py Show resolved Hide resolved

titaiwangms approved these changes Aug 28, 2025

View reviewed changes

docs/source/onnx_verification.md Show resolved Hide resolved

Update

153c848

[ghstack-poisoned]

angelayi approved these changes Sep 2, 2025

View reviewed changes

pytorchmergebot added the merging label Sep 2, 2025

pytorchmergebot closed this in 524b78d Sep 2, 2025

pytorchmergebot added Merged and removed merging labels Sep 2, 2025

github-actions bot deleted the gh/justinchuby/113/head branch October 3, 2025 02:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ONNX] Refactor torchscript based exporter #161323

[ONNX] Refactor torchscript based exporter #161323

Uh oh!

justinchuby commented Aug 22, 2025 •

edited by pytorch-bot bot

Loading

Uh oh!

pytorch-bot bot commented Aug 22, 2025 •

edited

Loading

Uh oh!

angelayi commented Aug 28, 2025

Uh oh!

Uh oh!

Uh oh!

angelayi commented Aug 29, 2025

Uh oh!

justinchuby commented Sep 2, 2025

Uh oh!

pytorchmergebot commented Sep 2, 2025

Uh oh!

pytorchmergebot commented Sep 2, 2025

Uh oh!

pytorchmergebot commented Sep 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

[ONNX] Refactor torchscript based exporter #161323

[ONNX] Refactor torchscript based exporter #161323

Uh oh!

Conversation

justinchuby commented Aug 22, 2025 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

BC Breaking

Uh oh!

pytorch-bot bot commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161323

❗ 1 Active SEVs

✅ No Failures

Uh oh!

angelayi commented Aug 28, 2025

Uh oh!

Uh oh!

Uh oh!

angelayi commented Aug 29, 2025

Uh oh!

justinchuby commented Sep 2, 2025

Uh oh!

pytorchmergebot commented Sep 2, 2025

Merge started

Uh oh!

pytorchmergebot commented Sep 2, 2025

Uh oh!

pytorchmergebot commented Sep 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

justinchuby commented Aug 22, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Aug 22, 2025 •

edited

Loading