KEMBAR78
[ONNX] Remove private members from torch.onnx by justinchuby · Pull Request #161546 · pytorch/pytorch · GitHub
Skip to content

[ONNX] Remove private members from torch.onnx #161546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

[ONNX] Remove private members from torch.onnx #161546

wants to merge 8 commits into from

Conversation

@justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Aug 26, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Remove import of two functions

  • _run_symbolic_function
  • _run_symbolic_method

to the torch.onnx namespace.

Signed-off-by: Justin Chu justinchuby@users.noreply.github.com

cc @titaiwangms

@justinchuby
Update
832a4ef 
[ghstack-poisoned]
This was referenced Aug 26, 2025
Closed
Closed
@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Aug 26, 2025
justinchuby added a commit that referenced this pull request Aug 26, 2025
@justinchuby
[ONNX] Remove private members from torch.onnx
3a36c94 
Remove import of two functions

- _run_symbolic_function
- _run_symbolic_method

to the `torch.onnx` namespace.

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: cecd561
Pull Request resolved: #161546
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 26, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161546

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 56dd397 with merge base 378edb0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Aug 26, 2025
justinchuby added a commit that referenced this pull request Aug 26, 2025
@justinchuby
[ONNX] Remove private members from torch.onnx
4833294 
Remove import of two functions

- _run_symbolic_function
- _run_symbolic_method

to the `torch.onnx` namespace.

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: cecd561
Pull Request resolved: #161546

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Update
b43df30 
[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Aug 26, 2025
@justinchuby
[ONNX] Remove private members from torch.onnx
bf66ee2 
Remove import of two functions

- _run_symbolic_function
- _run_symbolic_method

to the `torch.onnx` namespace.

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: 515fe2d
Pull Request resolved: #161546

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Update
1945536 
[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Aug 26, 2025
@justinchuby
[ONNX] Remove private members from torch.onnx
ffab802 
Remove import of two functions

- _run_symbolic_function
- _run_symbolic_method

to the `torch.onnx` namespace.

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: a0f4338
Pull Request resolved: #161546

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Update
c8b5e42 
[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Aug 26, 2025
@justinchuby
[ONNX] Remove private members from torch.onnx
a3c27fa 
Remove import of two functions

- _run_symbolic_function
- _run_symbolic_method

to the `torch.onnx` namespace.

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: 62d1d78
Pull Request resolved: #161546

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby added module: onnx Related to torch.onnx topic: not user facing topic category and removed oncall: jit Add this issue/PR to JIT oncall triage queue labels Aug 26, 2025
@justinchuby
Update
93abbca 
[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Aug 27, 2025
@justinchuby
[ONNX] Remove private members from torch.onnx
e5a9e86 
Remove import of two functions

- _run_symbolic_function
- _run_symbolic_method

to the `torch.onnx` namespace.

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: e7e01a7
Pull Request resolved: #161546

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Update
95694df 
[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Aug 27, 2025
@justinchuby
[ONNX] Remove private members from torch.onnx
c6c5022 
Remove import of two functions

- _run_symbolic_function
- _run_symbolic_method

to the `torch.onnx` namespace.

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: e98336a
Pull Request resolved: #161546

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Update
3f047d4 
[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Aug 27, 2025
@justinchuby
[ONNX] Remove private members from torch.onnx
3e19cfb 
Remove import of two functions

- _run_symbolic_function
- _run_symbolic_method

to the `torch.onnx` namespace.

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: 1bf0c12
Pull Request resolved: #161546

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
titaiwangms
titaiwangms approved these changes Aug 28, 2025
View reviewed changes
@justinchuby
Update
56dd397 
[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Aug 29, 2025
@justinchuby
[ONNX] Remove private members from torch.onnx
d300d81 
Remove import of two functions

- _run_symbolic_function
- _run_symbolic_method

to the `torch.onnx` namespace.

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: ddf0f9c
Pull Request resolved: #161546

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 29, 2025
@justinchuby
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x b7eac6f1e71da39b64294920ea6fde0489095967 returned non-zero exit code 1

CONFLICT (modify/delete): test/onnx/test_verification.py deleted in b7eac6f1e71 ([ONNX] Remove unused logic from internal verification module) and modified in HEAD.  Version HEAD of test/onnx/test_verification.py left in tree.
CONFLICT (modify/delete): torch/onnx/_internal/torchscript_exporter/verification.py deleted in HEAD and modified in b7eac6f1e71 ([ONNX] Remove unused logic from internal verification module).  Version b7eac6f1e71 ([ONNX] Remove unused logic from internal verification module) of torch/onnx/_internal/torchscript_exporter/verification.py left in tree.
error: could not apply b7eac6f1e71... [ONNX] Remove unused logic from internal verification module
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Details for Dev Infra team Raised by workflow job

@justinchuby
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@justinchuby @markc-614
[ONNX] Remove private members from torch.onnx (pytorch#161546)
819ba76 
Remove import of two functions

- _run_symbolic_function
- _run_symbolic_method

to the `torch.onnx` namespace.

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

Pull Request resolved: pytorch#161546
Approved by: https://github.com/titaiwangms
ghstack dependencies: pytorch#161323, pytorch#161449
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@justinchuby @mansiag05
[ONNX] Remove private members from torch.onnx (pytorch#161546)
658b41b 
Remove import of two functions

- _run_symbolic_function
- _run_symbolic_method

to the `torch.onnx` namespace.

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

Pull Request resolved: pytorch#161546
Approved by: https://github.com/titaiwangms
ghstack dependencies: pytorch#161323, pytorch#161449
@github-actions github-actions bot deleted the gh/justinchuby/115/head branch October 3, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@titaiwangms titaiwangms titaiwangms approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@justinchuby @pytorchmergebot @titaiwangms @facebook-github-bot @pytorchbot