[ROCm] revamp miopen integration #161687
Closed
[ROCm] revamp miopen integration #161687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update sources under ATen/miopen and ATen/native/miopen to align with best practices. Avoid reshape_ calls inside backward operations.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161687
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 30b9d6a with merge base 8703deb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
module: cpu
This comment was marked as resolved.
This comment was marked as resolved.
jeffdaily
added
ciflow/periodic
This comment was marked as outdated.
This comment was marked as outdated.
pytorch-bot
bot
removed
the
ciflow/periodic-rocm-mi300
jeffdaily
added
the
ciflow/periodic-rocm-mi300
pytorch-bot
bot
removed
ciflow/periodic
jeffdaily
added
ciflow/rocm
|
Why skipping PR sanity check is ok here? We would expect a script to repro the change/codemod and regular file move usually. |
@albanD Did I add the wrong label? PR SIZE is 2598, so over the 2000 limit. This PR is very difficult to break into smaller pieces, and a big chunk of the diff is removing miopen depthwise redundant code. |
Is the removal stuff something we can do in a separate PR? |
jeffdaily
requested review from
eqy,
jeffdaily,
jithunnair-amd and
syed-ahmed
as code owners
jeffdaily
approved these changes
Sep 3, 2025
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
jeffdaily
added a commit
to ROCm/pytorch
that referenced
this pull request
Sep 4, 2025
Update sources under ATen/miopen and ATen/native/miopen to align with best practices. Avoid reshape_ calls inside backward operations. Pull Request resolved: pytorch#161687 Approved by: https://github.com/jeffdaily Co-authored-by: Jeff Daily <jeff.daily@amd.com>
jeffdaily
added a commit
to ROCm/pytorch
that referenced
this pull request
Sep 4, 2025
Update sources under ATen/miopen and ATen/native/miopen to align with best practices. Avoid reshape_ calls inside backward operations. Pull Request resolved: pytorch#161687 Approved by: https://github.com/jeffdaily Co-authored-by: Jeff Daily <jeff.daily@amd.com>
jeffdaily
added a commit
to ROCm/pytorch
that referenced
this pull request
Sep 4, 2025
Update sources under ATen/miopen and ATen/native/miopen to align with best practices. Avoid reshape_ calls inside backward operations. Pull Request resolved: pytorch#161687 Approved by: https://github.com/jeffdaily Co-authored-by: Jeff Daily <jeff.daily@amd.com>
jithunnair-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Sep 11, 2025
Update sources under ATen/miopen and ATen/native/miopen to align with best practices. Avoid reshape_ calls inside backward operations. Pull Request resolved: pytorch#161687 Approved by: https://github.com/jeffdaily
jeffdaily
added a commit
to ROCm/pytorch
that referenced
this pull request
Sep 11, 2025
Fixes pytorch#70125. Much of the work was done by pytorch#161687. This PR is additional test cleanup.
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 12, 2025
Fixes #70125. Much of the work was done by #161687. This PR is additional test cleanup. Pull Request resolved: #162766 Approved by: https://github.com/jeffdaily Co-authored-by: Jeff Daily <jeff.daily@amd.com>
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
Update sources under ATen/miopen and ATen/native/miopen to align with best practices. Avoid reshape_ calls inside backward operations. Pull Request resolved: pytorch#161687 Approved by: https://github.com/jeffdaily Co-authored-by: Jeff Daily <jeff.daily@amd.com>
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
Fixes pytorch#70125. Much of the work was done by pytorch#161687. This PR is additional test cleanup. Pull Request resolved: pytorch#162766 Approved by: https://github.com/jeffdaily Co-authored-by: Jeff Daily <jeff.daily@amd.com>
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
Update sources under ATen/miopen and ATen/native/miopen to align with best practices. Avoid reshape_ calls inside backward operations. Pull Request resolved: pytorch#161687 Approved by: https://github.com/jeffdaily Co-authored-by: Jeff Daily <jeff.daily@amd.com>
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
Fixes pytorch#70125. Much of the work was done by pytorch#161687. This PR is additional test cleanup. Pull Request resolved: pytorch#162766 Approved by: https://github.com/jeffdaily Co-authored-by: Jeff Daily <jeff.daily@amd.com>
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
Fixes pytorch#70125. Much of the work was done by pytorch#161687. This PR is additional test cleanup. Pull Request resolved: pytorch#162766 Approved by: https://github.com/jeffdaily Co-authored-by: Jeff Daily <jeff.daily@amd.com>
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
Update sources under ATen/miopen and ATen/native/miopen to align with best practices. Avoid reshape_ calls inside backward operations. Pull Request resolved: pytorch#161687 Approved by: https://github.com/jeffdaily Co-authored-by: Jeff Daily <jeff.daily@amd.com>
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
Fixes pytorch#70125. Much of the work was done by pytorch#161687. This PR is additional test cleanup. Pull Request resolved: pytorch#162766 Approved by: https://github.com/jeffdaily Co-authored-by: Jeff Daily <jeff.daily@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update sources under ATen/miopen and ATen/native/miopen to align with best practices. Avoid reshape_ calls inside backward operations.
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jerryzh168 @albanD