KEMBAR78
[ROCm][CI] unskip some test_memory_format tests by pragupta · Pull Request #162766 · pytorch/pytorch · GitHub
Skip to content

Conversation

@pragupta
Copy link
Contributor

@pragupta pragupta commented Sep 11, 2025

Fixes #70125.

Much of the work was done by #161687.
This PR is additional test cleanup.

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd

Fixes pytorch#70125.

Much of the work was done by pytorch#161687.
This PR is additional test cleanup.
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162766

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 175517f with merge base b500c16 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the module: rocm AMD GPU support for Pytorch label Sep 11, 2025
@jeffdaily jeffdaily added the topic: not user facing topic category label Sep 11, 2025
@jeffdaily jeffdaily marked this pull request as ready for review September 11, 2025 23:30
@jeffdaily jeffdaily added ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Sep 11, 2025
@pytorch-bot

This comment was marked as outdated.

@pytorch-bot

This comment was marked as outdated.

@pytorch-bot pytorch-bot bot removed ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Sep 11, 2025
@jeffdaily jeffdaily added ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Sep 11, 2025
@pytorch-bot pytorch-bot bot removed ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Sep 12, 2025
@jeffdaily jeffdaily added ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 ciflow/trunk Trigger trunk jobs on your pull request labels Sep 12, 2025
@pragupta
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
Fixes pytorch#70125.

Much of the work was done by pytorch#161687.
This PR is additional test cleanup.

Pull Request resolved: pytorch#162766
Approved by: https://github.com/jeffdaily

Co-authored-by: Jeff Daily <jeff.daily@amd.com>
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
Fixes pytorch#70125.

Much of the work was done by pytorch#161687.
This PR is additional test cleanup.

Pull Request resolved: pytorch#162766
Approved by: https://github.com/jeffdaily

Co-authored-by: Jeff Daily <jeff.daily@amd.com>
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
Fixes pytorch#70125.

Much of the work was done by pytorch#161687.
This PR is additional test cleanup.

Pull Request resolved: pytorch#162766
Approved by: https://github.com/jeffdaily

Co-authored-by: Jeff Daily <jeff.daily@amd.com>
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
Fixes pytorch#70125.

Much of the work was done by pytorch#161687.
This PR is additional test cleanup.

Pull Request resolved: pytorch#162766
Approved by: https://github.com/jeffdaily

Co-authored-by: Jeff Daily <jeff.daily@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 ciflow/trunk Trigger trunk jobs on your pull request Merged module: rocm AMD GPU support for Pytorch open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

channels_last/channels_last_3d memory format not supported for some modules on ROCm that should be supported on CUDA

4 participants