remove pytest.UsageError #58916
Closed
remove pytest.UsageError #58916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `pytest.UsageError` in case `pytest` is available adds almost nothing as observed in #53820 (comment), but makes it harder to maintain: due to the conditional import, `mypy` is not able to handle `UsageError` in a type annotation. [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 6aeb57b (more details on the Dr. CI page and at hud.pytorch.org/pr/58916): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced May 25, 2021
rgommers
added
the
module: testing
Using `pytest.UsageError` in case `pytest` is available adds almost nothing as observed in #53820 (comment), but makes it harder to maintain: due to the conditional import, `mypy` is not able to handle `UsageError` in a type annotation. [ghstack-poisoned]
Using `pytest.UsageError` in case `pytest` is available adds almost nothing as observed in #53820 (comment), but makes it harder to maintain: due to the conditional import, `mypy` is not able to handle `UsageError` in a type annotation. [ghstack-poisoned]
Using `pytest.UsageError` in case `pytest` is available adds almost nothing as observed in #53820 (comment), but makes it harder to maintain: due to the conditional import, `mypy` is not able to handle `UsageError` in a type annotation. [ghstack-poisoned]
|
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Oops, this broke torchvision's tests :) We were relying on pytest.UsageError: https://github.com/pytorch/vision/pull/4121/files I understand and agree with the removal of The docs clearly mention that a Altough, TBF, I would personally prefer if this was just a and will avoid users (us) to import a custom exception from torch.testing (which also can add extra confusion as it's very similar to |
pmeier
added a commit
that referenced
this pull request
Jul 1, 2021
See #58916 (comment). [ghstack-poisoned]
pmeier
added a commit
that referenced
this pull request
Jul 1, 2021
See #58916 (comment). [ghstack-poisoned]
pmeier
added a commit
that referenced
this pull request
Jul 6, 2021
See #58916 (comment). [ghstack-poisoned]
pmeier
added a commit
that referenced
this pull request
Jul 6, 2021
See #58916 (comment). [ghstack-poisoned]
pmeier
added a commit
that referenced
this pull request
Jul 8, 2021
See #58916 (comment). [ghstack-poisoned]
pmeier
added a commit
that referenced
this pull request
Jul 8, 2021
See #58916 (comment). [ghstack-poisoned]
pmeier
added a commit
that referenced
this pull request
Jul 9, 2021
See #58916 (comment). Differential Revision: [D29626810](https://our.internmc.facebook.com/intern/diff/D29626810) [ghstack-poisoned]
pmeier
added a commit
that referenced
this pull request
Jul 9, 2021
See #58916 (comment). Differential Revision: [D29626810](https://our.internmc.facebook.com/intern/diff/D29626810) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 9, 2021
Summary: Pull Request resolved: #61031 See #58916 (comment). Test Plan: Imported from OSS Reviewed By: iramazanli Differential Revision: D29626810 Pulled By: mruberry fbshipit-source-id: 25ddf26815f9ef82b8234d7dac811a6a13a53c54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
msgintorch.testing.assert_close#60254 tests for diagnostics in callablemsgintorch.testing.assert_closetorch.testing.assert_close#60163 update docstring examples oftorch.testing.assert_closetorch.testing.assert_closein case of mismatching values #60091 Improve error messages oftorch.testing.assert_closein case of mismatching valuestorch.testing.assert_close#58918 make assert_equal an example how to partialtorch.testing.assert_closeUsing
pytest.UsageErrorin casepytestis available adds almostnothing as observed in
#53820 (comment), but
makes it harder to maintain: due to the conditional import,
mypyisnot able to handle
UsageErrorin a type annotation.Differential Revision: D29259409