KEMBAR78
remove UsageError in favor of ValueError by pmeier · Pull Request #61031 · pytorch/pytorch · GitHub
Skip to content

remove UsageError in favor of ValueError #61031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

remove UsageError in favor of ValueError #61031

wants to merge 5 commits into from

Conversation

@pmeier
Copy link
Collaborator

@pmeier pmeier commented Jun 30, 2021 •
edited by mruberry
Loading

Stack from ghstack:

See #58916 (comment).

Differential Revision: D29626810

This was referenced Jun 30, 2021
Closed
Closed
Closed
@pmeier pmeier mentioned this pull request Jun 30, 2021
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 30, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 8c22506 (more details on the Dr. CI page and at hud.pytorch.org/pr/61031):

  • 3/3 failures possibly* introduced in this PR
    • 1/3 non-scanned failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_clang5_asan_test1 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jul 09 09:26:07 SUMMARY: UndefinedBehaviorSanit.../jenkins/workspace/aten/src/ATen/Utils.cpp:20:3 in 
Jul 09 09:26:07     #9 0x5606b918c8f2 in PyEval_EvalCode /home/builder/ktietz/cos6/ci_cos6/python_1622833237666/work/Python/ceval.c:731
Jul 09 09:26:07     #10 0x5606b91f4cd5 in run_mod /home/builder/ktietz/cos6/ci_cos6/python_1622833237666/work/Python/pythonrun.c:1025
Jul 09 09:26:07     #11 0x5606b91f6d5d in PyRun_StringFlags /home/builder/ktietz/cos6/ci_cos6/python_1622833237666/work/Python/pythonrun.c:949
Jul 09 09:26:07     #12 0x5606b91f6dbb in PyRun_SimpleStringFlags /home/builder/ktietz/cos6/ci_cos6/python_1622833237666/work/Python/pythonrun.c:445
Jul 09 09:26:07     #13 0x5606b91f7926 in run_command /home/builder/ktietz/cos6/ci_cos6/python_1622833237666/work/Modules/main.c:301
Jul 09 09:26:07     #14 0x5606b91f7926 in Py_Main /home/builder/ktietz/cos6/ci_cos6/python_1622833237666/work/Modules/main.c:749
Jul 09 09:26:07     #15 0x5606b9131196 in main /home/builder/ktietz/cos6/ci_cos6/python_1622833237666/work/Programs/python.c:69
Jul 09 09:26:07     #16 0x7f5eff6b183f in __libc_start_main /build/glibc-S7Ft5T/glibc-2.23/csu/../csu/libc-start.c:291
Jul 09 09:26:07     #17 0x5606b91c133d in _start (/opt/conda/bin/python3.6+0x1a733d)
Jul 09 09:26:07 
Jul 09 09:26:07 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/aten/src/ATen/Utils.cpp:20:3 in 
Jul 09 09:26:07 + retcode=1
Jul 09 09:26:07 + set -e
Jul 09 09:26:07 + return 1
Jul 09 09:26:07 + [[ pytorch-linux-xenial-py3-clang5-asan-test1 == *-NO_AVX-* ]]
Jul 09 09:26:07 + [[ pytorch-linux-xenial-py3-clang5-asan-test1 == *-NO_AVX2-* ]]
Jul 09 09:26:07 + '[' -n https://github.com/pytorch/pytorch/pull/61031 ']'
Jul 09 09:26:07 + [[ pytorch-linux-xenial-py3-clang5-asan-test1 != *coverage* ]]
Jul 09 09:26:07 ++ mktemp
Jul 09 09:26:07 + DETERMINE_FROM=/tmp/tmp.grq0l2ISou
Jul 09 09:26:07 + file_diff_from_base /tmp/tmp.grq0l2ISou

1 failure not recognized by patterns:

Job Step Action
GitHub Actions Windows CI (pytorch-win-vs2019-cpu-py3) / test (default, 1, 2, windows.4xlarge) Install Visual Studio 2019 toolchain 🔁 rerun

Preview docs built from this PR

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced Jun 30, 2021
Closed
Closed
Closed
Closed
pmeier added a commit that referenced this pull request Jun 30, 2021
@pmeier
remove UsageError in favor of ValueError
950c64b 
ghstack-source-id: b5fe8de
Pull Request resolved: #61031
@pmeier pmeier requested review from NicolasHug and mruberry June 30, 2021 08:59
@pmeier pmeier added the module: testing Issues related to the torch.testing module (not tests) label Jun 30, 2021
NicolasHug
NicolasHug approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

pmeier added a commit that referenced this pull request Jul 1, 2021
@pmeier
remove UsageError in favor of ValueError
17d6dd9 
ghstack-source-id: 807718f
Pull Request resolved: #61031
pmeier added a commit that referenced this pull request Jul 6, 2021
@pmeier
remove UsageError in favor of ValueError
312e188 
ghstack-source-id: 8e18eb1
Pull Request resolved: #61031
pmeier added a commit that referenced this pull request Jul 8, 2021
@pmeier
remove UsageError in favor of ValueError
d4b03c7 
ghstack-source-id: 722d6b7
Pull Request resolved: #61031
mruberry
mruberry approved these changes Jul 8, 2021
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification.

Thanks for helping us review assert_close, @NicolasHug

@mruberry
Copy link
Collaborator

mruberry commented Jul 8, 2021

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

pmeier added a commit that referenced this pull request Jul 9, 2021
@pmeier
remove UsageError in favor of ValueError
96a9eaf 
ghstack-source-id: a583c7d
Pull Request resolved: #61031
@mruberry
Copy link
Collaborator

mruberry commented Jul 9, 2021

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mruberry merged this pull request in 682ebc1.

@NicolasHug NicolasHug mentioned this pull request Jul 12, 2021
Merged
@facebook-github-bot facebook-github-bot deleted the gh/pmeier/29/head branch July 13, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mruberry mruberry mruberry approved these changes

+1 more reviewer

@NicolasHug NicolasHug NicolasHug approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged module: testing Issues related to the torch.testing module (not tests) open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pmeier @facebook-github-bot @mruberry @NicolasHug @pytorchbot