Add TORCH_API annotations to c10d #59695
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c10d apparently doesn't have hidden visibility by default, but libtorch has, so in order to prepare c10d to be merged into libtorch we need to add these annotations. I've done this "as needed", seeing what would fail and fixing it. Windows is much more picky about it than Linux, hence there's more annotations in the Windows-only files (e.g., Gloo, as compared to NCCL). Differential Revision: [D28987578](https://our.internmc.facebook.com/intern/diff/D28987578/) [ghstack-poisoned]
lw
requested review from
H-Huang,
cbalioglu,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma,
wayi1 and
zhaojuanmao
as code owners
facebook-github-bot
added
oncall: distributed
💊 CI failures summary and remediationsAs of commit 8383207 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
 Windows CI (pytorch-win-vs2019-cpu-py3) / render_test_results |
Download PyTorch Test Reports | 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group.
This was referenced Jun 9, 2021
c10d apparently doesn't have hidden visibility by default, but libtorch has, so in order to prepare c10d to be merged into libtorch we need to add these annotations. I've done this "as needed", seeing what would fail and fixing it. Windows is much more picky about it than Linux, hence there's more annotations in the Windows-only files (e.g., Gloo, as compared to NCCL). Differential Revision: [D28987578](https://our.internmc.facebook.com/intern/diff/D28987578/) [ghstack-poisoned]
c10d apparently doesn't have hidden visibility by default, but libtorch has, so in order to prepare c10d to be merged into libtorch we need to add these annotations. I've done this "as needed", seeing what would fail and fixing it. Windows is much more picky about it than Linux, hence there's more annotations in the Windows-only files (e.g., Gloo, as compared to NCCL). Differential Revision: [D28987578](https://our.internmc.facebook.com/intern/diff/D28987578/) [ghstack-poisoned]
c10d apparently doesn't have hidden visibility by default, but libtorch has, so in order to prepare c10d to be merged into libtorch we need to add these annotations. I've done this "as needed", seeing what would fail and fixing it. Windows is much more picky about it than Linux, hence there's more annotations in the Windows-only files (e.g., Gloo, as compared to NCCL). Differential Revision: [D28987578](https://our.internmc.facebook.com/intern/diff/D28987578/) [ghstack-poisoned]
|
It actually turns out that it's complicated to use The proper solution would be to introduce a temporary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
c10d apparently doesn't have hidden visibility by default, but libtorch has, so in order to prepare c10d to be merged into libtorch we need to add these annotations. I've done this "as needed", seeing what would fail and fixing it. Windows is much more picky about it than Linux, hence there's more annotations in the Windows-only files (e.g., Gloo, as compared to NCCL).
Differential Revision: D28987578