KEMBAR78
Reuse run_torch_xla_tests from pytorch/xla by ailzhang · Pull Request #59888 · pytorch/pytorch · GitHub
Skip to content

Reuse run_torch_xla_tests from pytorch/xla #59888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Reuse run_torch_xla_tests from pytorch/xla #59888

wants to merge 6 commits into from

Conversation

@ailzhang
Copy link
Contributor

@ailzhang ailzhang commented Jun 11, 2021 •
edited
Loading

Stack from ghstack:

Differential Revision: D29114274

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 11, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit f64bcbc (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_linux_bionic_py3_6_clang9_noarch_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun) ❄️

Jun 15 18:23:57 RuntimeError: Process 0 terminated or timed out after 105.08722400665283 seconds 
Jun 15 18:23:57 ======================================================================
Jun 15 18:23:57 ERROR [105.146s]: test_backward_rref_nested (__main__.ProcessGroupDistAutogradTestWithSpawn)
Jun 15 18:23:57 ----------------------------------------------------------------------
Jun 15 18:23:57 Traceback (most recent call last):
Jun 15 18:23:57   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 398, in wrapper
Jun 15 18:23:57     self._join_processes(fn)
Jun 15 18:23:57   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 590, in _join_processes
Jun 15 18:23:57     self._check_return_codes(elapsed_time)
Jun 15 18:23:57   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 638, in _check_return_codes
Jun 15 18:23:57     raise RuntimeError('Process {} terminated or timed out after {} seconds'.format(i, elapsed_time))
Jun 15 18:23:57 RuntimeError: Process 0 terminated or timed out after 105.08722400665283 seconds
Jun 15 18:23:57 
Jun 15 18:23:57 ----------------------------------------------------------------------
Jun 15 18:23:57 Ran 367 tests in 1075.381s
Jun 15 18:23:57 
Jun 15 18:23:57 FAILED (errors=1, skipped=4)
Jun 15 18:23:57 
Jun 15 18:23:57 Generating XML reports...
Jun 15 18:23:57 Generated XML report: test-reports/dist-gloo/distributed.rpc.test_process_group_agent/TEST-ProcessGroupDdpComparisonTestWithSpawn-20210615180601.xml
Jun 15 18:23:57 Generated XML report: test-reports/dist-gloo/distributed.rpc.test_process_group_agent/TEST-ProcessGroupDdpUnderDistAutogradTestWithSpawn-20210615180601.xml
Jun 15 18:23:57 Generated XML report: test-reports/dist-gloo/distributed.rpc.test_process_group_agent/TEST-ProcessGroupDistAutogradTestWithSpawn-20210615180601.xml
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

ailzhang pushed a commit that referenced this pull request Jun 11, 2021
Reuse run_torch_xla_tests from pytorch/xla
654cc7f 
ghstack-source-id: fd60999
Pull Request resolved: #59888
ailzhang pushed a commit that referenced this pull request Jun 11, 2021
Reuse run_torch_xla_tests from pytorch/xla
740385d 
ghstack-source-id: 90fd082
Pull Request resolved: #59888
@ailzhang
Copy link
Contributor Author

@ailzhang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ailzhang ailzhang mentioned this pull request Jun 14, 2021
Closed
samestep
samestep reviewed Jun 15, 2021
View reviewed changes
Copy link
Contributor

@samestep samestep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: instead of deleting the test_xla function entirely and inlining its new behavior, would it work to just replace the implementation of test_xla and leave what was line 448 as-is?

test_xla() {
  # shellcheck disable=SC1091
  source "./xla/.circleci/common.sh"
  run_torch_xla_tests "$(pwd)" "$(pwd)/xla"
  assert_git_not_dirty
}

@ailzhang
Copy link
Contributor Author

@samestep sounds good! Updated :D

samestep
samestep approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@samestep samestep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!

@ailzhang
Copy link
Contributor Author

@ailzhang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ailzhang merged this pull request in a0e62c4.

@facebook-github-bot facebook-github-bot deleted the gh/ailzhang/68/head branch June 19, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet Awaiting requested review from malfet

@seemethere seemethere Awaiting requested review from seemethere

1 more reviewer

@samestep samestep samestep approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ailzhang @facebook-github-bot @samestep