KEMBAR78
Reuse build_torch_xla from pytorch/xla repo. by ailzhang · Pull Request #59989 · pytorch/pytorch · GitHub
Skip to content

Reuse build_torch_xla from pytorch/xla repo. #59989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Reuse build_torch_xla from pytorch/xla repo. #59989

wants to merge 2 commits into from

Conversation

@ailzhang
Copy link
Contributor

@ailzhang ailzhang commented Jun 14, 2021 •
edited
Loading

Stack from ghstack:

Differential Revision: D29138211

@ailzhang ailzhang mentioned this pull request Jun 14, 2021
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 14, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 6292df6 (more details on the Dr. CI page):

  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-scanned failure(s)

1 failure not recognized by patterns:

Job Step Action
CircleCI pytorch_linux_xenial_py3_6_gcc5_4_test Run tests 🔁 rerun
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

ailzhang pushed a commit that referenced this pull request Jun 14, 2021
Reuse build_torch_xla from pytorch/xla repo.
94969ca 
ghstack-source-id: ebe5428
Pull Request resolved: #59989
ailzhang pushed a commit that referenced this pull request Jun 15, 2021
Reuse build_torch_xla from pytorch/xla repo.
57a8d33 
ghstack-source-id: f8c3ef1
Pull Request resolved: #59989
@ailzhang
Copy link
Contributor Author

@ailzhang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

samestep
samestep approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@samestep samestep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 out of curiosity, is there a specific reason clone_pytorch_xla was refactored out into its own function? (e.g. planning to be used elsewhere in the future)

@ailzhang
Copy link
Contributor Author

@samestep Not yet :P refactored it out mostly because we currently use pytorch/xla master branch, and this is a choice we might want to revisit in the future. So just want to put this logic in a function in case other people want to reuse it. (this is unlikely :P

@facebook-github-bot
Copy link
Contributor

@ailzhang merged this pull request in 8dd0570.

@facebook-github-bot facebook-github-bot deleted the gh/ailzhang/69/head branch June 19, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet Awaiting requested review from malfet

@seemethere seemethere Awaiting requested review from seemethere

1 more reviewer

@samestep samestep samestep approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ailzhang @facebook-github-bot @samestep