KEMBAR78
Embedding: Remove dispatch in parallel region by peterbell10 · Pull Request #60597 · pytorch/pytorch · GitHub
Skip to content

Embedding: Remove dispatch in parallel region #60597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Embedding: Remove dispatch in parallel region #60597

wants to merge 2 commits into from

Conversation

@peterbell10
Copy link
Collaborator

@peterbell10 peterbell10 commented Jun 23, 2021 •
edited by ngimel
Loading

Stack from ghstack:

Ref #56794

Differential Revision: D29446191

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 23, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit a4a44f9 (more details on the Dr. CI page and at hud.pytorch.org/pr/60597):

  • 3/3 failures introduced in this PR

🕵️ 3 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build Lint / mypy (1/3)

Step: "Run mypy" (full log | diagnosis details | 🔁 rerun)

2021-06-24T14:07:40.7313137Z torch/utils/benchm...ction "median" in typed context [no-untyped-call] 
2021-06-24T14:07:29.5019358Z env:
2021-06-24T14:07:29.5019860Z   pythonLocation: /opt/hostedtoolcache/Python/3.8.10/x64
2021-06-24T14:07:29.5020513Z   LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.8.10/x64/lib
2021-06-24T14:07:29.5020989Z ##[endgroup]
2021-06-24T14:07:29.5139604Z + for CONFIG in mypy*.ini
2021-06-24T14:07:29.5141041Z + mypy --config=mypy-strict.ini
2021-06-24T14:07:39.1884958Z torch/utils/benchmark/utils/common.py:166:34: error: Call to untyped function "median" in typed context  [no-untyped-call]
2021-06-24T14:07:39.1887060Z torch/utils/benchmark/utils/common.py:168:31: error: Call to untyped function "percentile" in typed context  [no-untyped-call]
2021-06-24T14:07:39.1888872Z torch/utils/benchmark/utils/common.py:169:31: error: Call to untyped function "percentile" in typed context  [no-untyped-call]
2021-06-24T14:07:39.1890554Z torch/utils/benchmark/utils/common.py:281:18: error: Call to untyped function "round" in typed context  [no-untyped-call]
2021-06-24T14:07:40.7313137Z torch/utils/benchmark/utils/timer.py:304:24: error: Call to untyped function "median" in typed context  [no-untyped-call]
2021-06-24T14:07:43.9580902Z Found 5 errors in 2 files (checked 141 source files)
2021-06-24T14:07:44.7863490Z ##[error]Process completed with exit code 1.
2021-06-24T14:07:44.7958601Z Post job cleanup.
2021-06-24T14:07:44.8728749Z [command]/usr/bin/git version
2021-06-24T14:07:44.8806020Z git version 2.32.0
2021-06-24T14:07:44.8832768Z [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand
2021-06-24T14:07:44.8897824Z [command]/usr/bin/git submodule foreach --recursive git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :
2021-06-24T14:07:44.9135336Z [command]/usr/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
2021-06-24T14:07:44.9170659Z http.https://github.com/.extraheader
2021-06-24T14:07:44.9178612Z [command]/usr/bin/git config --local --unset-all http.https://github.com/.extraheader

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_build (2/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result. 
CONFLICT (add/add): Merge conflict in .github/templates/linux_ci_workflow.yml.j2
Auto-merging .github/templates/linux_ci_workflow.yml.j2
CONFLICT (add/add): Merge conflict in .github/scripts/lint_native_functions.py
Auto-merging .github/scripts/lint_native_functions.py
CONFLICT (add/add): Merge conflict in .github/scripts/generate_ci_workflows.py
Auto-merging .github/scripts/generate_ci_workflows.py
CONFLICT (add/add): Merge conflict in .circleci/verbatim-sources/job-specs/pytorch-job-specs.yml
Auto-merging .circleci/verbatim-sources/job-specs/pytorch-job-specs.yml
CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_build (3/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result. 
CONFLICT (add/add): Merge conflict in .github/templates/linux_ci_workflow.yml.j2
Auto-merging .github/templates/linux_ci_workflow.yml.j2
CONFLICT (add/add): Merge conflict in .github/scripts/lint_native_functions.py
Auto-merging .github/scripts/lint_native_functions.py
CONFLICT (add/add): Merge conflict in .github/scripts/generate_ci_workflows.py
Auto-merging .github/scripts/generate_ci_workflows.py
CONFLICT (add/add): Merge conflict in .circleci/verbatim-sources/job-specs/pytorch-job-specs.yml
Auto-merging .circleci/verbatim-sources/job-specs/pytorch-job-specs.yml
CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced Jun 23, 2021
Closed
Closed
Closed
@peterbell10 peterbell10 requested a review from ngimel June 23, 2021 22:46
@ngimel
Copy link
Collaborator

ngimel commented Jun 29, 2021

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ngimel merged this pull request in 3cf267b.

@facebook-github-bot facebook-github-bot deleted the gh/peterbell10/85/head branch July 4, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel ngimel approved these changes

Assignees

No one assigned

Labels

cla signed Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@peterbell10 @facebook-github-bot @ngimel @pytorchbot