KEMBAR78
CTCLoss: Remove dispatching in parallel region by peterbell10 · Pull Request #60599 · pytorch/pytorch · GitHub
Skip to content

CTCLoss: Remove dispatching in parallel region #60599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

CTCLoss: Remove dispatching in parallel region #60599

wants to merge 2 commits into from

Conversation

@peterbell10
Copy link
Collaborator

@peterbell10 peterbell10 commented Jun 23, 2021 •
edited by ngimel
Loading

Stack from ghstack:

Ref #56794

Differential Revision: D29446190

This was referenced Jun 23, 2021
Closed
Closed
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 23, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 3625913 (more details on the Dr. CI page and at hud.pytorch.org/pr/60599):

  • 4/4 failures possibly* introduced in this PR
    • 1/4 non-scanned failure(s)

🕵️ 3 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_build (1/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result. 
CONFLICT (add/add): Merge conflict in .github/templates/linux_ci_workflow.yml.j2
Auto-merging .github/templates/linux_ci_workflow.yml.j2
CONFLICT (add/add): Merge conflict in .github/scripts/lint_native_functions.py
Auto-merging .github/scripts/lint_native_functions.py
CONFLICT (add/add): Merge conflict in .github/scripts/generate_ci_workflows.py
Auto-merging .github/scripts/generate_ci_workflows.py
CONFLICT (add/add): Merge conflict in .circleci/verbatim-sources/job-specs/pytorch-job-specs.yml
Auto-merging .circleci/verbatim-sources/job-specs/pytorch-job-specs.yml
CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_build (2/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result. 
CONFLICT (add/add): Merge conflict in .github/templates/linux_ci_workflow.yml.j2
Auto-merging .github/templates/linux_ci_workflow.yml.j2
CONFLICT (add/add): Merge conflict in .github/scripts/lint_native_functions.py
Auto-merging .github/scripts/lint_native_functions.py
CONFLICT (add/add): Merge conflict in .github/scripts/generate_ci_workflows.py
Auto-merging .github/scripts/generate_ci_workflows.py
CONFLICT (add/add): Merge conflict in .circleci/verbatim-sources/job-specs/pytorch-job-specs.yml
Auto-merging .circleci/verbatim-sources/job-specs/pytorch-job-specs.yml
CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

See GitHub Actions build Lint / mypy (3/3)

Step: "Run mypy" (full log | diagnosis details | 🔁 rerun)

2021-06-24T14:08:04.4860730Z torch/utils/benchm...ction "median" in typed context [no-untyped-call] 
2021-06-24T14:07:50.6619376Z env:
2021-06-24T14:07:50.6620039Z   pythonLocation: /opt/hostedtoolcache/Python/3.8.10/x64
2021-06-24T14:07:50.6620880Z   LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.8.10/x64/lib
2021-06-24T14:07:50.6621517Z ##[endgroup]
2021-06-24T14:07:50.6711849Z + for CONFIG in mypy*.ini
2021-06-24T14:07:50.6714392Z + mypy --config=mypy-strict.ini
2021-06-24T14:08:02.6004172Z torch/utils/benchmark/utils/common.py:166:34: error: Call to untyped function "median" in typed context  [no-untyped-call]
2021-06-24T14:08:02.6007909Z torch/utils/benchmark/utils/common.py:168:31: error: Call to untyped function "percentile" in typed context  [no-untyped-call]
2021-06-24T14:08:02.6011319Z torch/utils/benchmark/utils/common.py:169:31: error: Call to untyped function "percentile" in typed context  [no-untyped-call]
2021-06-24T14:08:02.6014550Z torch/utils/benchmark/utils/common.py:281:18: error: Call to untyped function "round" in typed context  [no-untyped-call]
2021-06-24T14:08:04.4860730Z torch/utils/benchmark/utils/timer.py:304:24: error: Call to untyped function "median" in typed context  [no-untyped-call]
2021-06-24T14:08:08.4320659Z Found 5 errors in 2 files (checked 141 source files)
2021-06-24T14:08:09.2654989Z ##[error]Process completed with exit code 1.
2021-06-24T14:08:09.2750904Z Post job cleanup.
2021-06-24T14:08:09.3723825Z [command]/usr/bin/git version
2021-06-24T14:08:09.3782304Z git version 2.32.0
2021-06-24T14:08:09.3816674Z [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand
2021-06-24T14:08:09.3902825Z [command]/usr/bin/git submodule foreach --recursive git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :
2021-06-24T14:08:09.4180837Z [command]/usr/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
2021-06-24T14:08:09.4222958Z http.https://github.com/.extraheader
2021-06-24T14:08:09.4232770Z [command]/usr/bin/git config --local --unset-all http.https://github.com/.extraheader

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

peterbell10 added a commit that referenced this pull request Jun 23, 2021
@peterbell10
CTCLoss: Remove dispatching in parallel region
b9d884b 
ghstack-source-id: ae02581
Pull Request resolved: #60599
@peterbell10 peterbell10 requested a review from ngimel June 23, 2021 22:47
peterbell10 added a commit that referenced this pull request Jun 24, 2021
@peterbell10
CTCLoss: Remove dispatching in parallel region
a803a1d 
ghstack-source-id: 39f7f5e
Pull Request resolved: #60599
@ngimel
Copy link
Collaborator

ngimel commented Jun 29, 2021

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ngimel merged this pull request in 512448a.

@facebook-github-bot facebook-github-bot deleted the gh/peterbell10/87/head branch July 6, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel ngimel approved these changes

Assignees

No one assigned

Labels

cla signed Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@peterbell10 @facebook-github-bot @ngimel @pytorchbot