KEMBAR78
change language from array to tensor by pmeier · Pull Request #60639 · pytorch/pytorch · GitHub
Skip to content

change language from array to tensor #60639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

change language from array to tensor #60639

wants to merge 6 commits into from

Conversation

@pmeier
Copy link
Collaborator

@pmeier pmeier commented Jun 24, 2021 •
edited by mruberry
Loading

Stack from ghstack:

Differential Revision: D29626812

This was referenced Jun 24, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 24, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 69a6564 (more details on the Dr. CI page and at hud.pytorch.org/pr/60639):

  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-scanned failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_clang5_asan_test1 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jul 09 09:27:41 SUMMARY: UndefinedBehaviorSanit.../jenkins/workspace/aten/src/ATen/Utils.cpp:20:3 in 
Jul 09 09:27:41     #9 0x55b0ddb888f2 in PyEval_EvalCode /home/builder/ktietz/cos6/ci_cos6/python_1622833237666/work/Python/ceval.c:731
Jul 09 09:27:41     #10 0x55b0ddbf0cd5 in run_mod /home/builder/ktietz/cos6/ci_cos6/python_1622833237666/work/Python/pythonrun.c:1025
Jul 09 09:27:41     #11 0x55b0ddbf2d5d in PyRun_StringFlags /home/builder/ktietz/cos6/ci_cos6/python_1622833237666/work/Python/pythonrun.c:949
Jul 09 09:27:41     #12 0x55b0ddbf2dbb in PyRun_SimpleStringFlags /home/builder/ktietz/cos6/ci_cos6/python_1622833237666/work/Python/pythonrun.c:445
Jul 09 09:27:41     #13 0x55b0ddbf3926 in run_command /home/builder/ktietz/cos6/ci_cos6/python_1622833237666/work/Modules/main.c:301
Jul 09 09:27:41     #14 0x55b0ddbf3926 in Py_Main /home/builder/ktietz/cos6/ci_cos6/python_1622833237666/work/Modules/main.c:749
Jul 09 09:27:41     #15 0x55b0ddb2d196 in main /home/builder/ktietz/cos6/ci_cos6/python_1622833237666/work/Programs/python.c:69
Jul 09 09:27:41     #16 0x7fb24c15183f in __libc_start_main /build/glibc-S7Ft5T/glibc-2.23/csu/../csu/libc-start.c:291
Jul 09 09:27:41     #17 0x55b0ddbbd33d in _start (/opt/conda/bin/python3.6+0x1a733d)
Jul 09 09:27:41 
Jul 09 09:27:41 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/aten/src/ATen/Utils.cpp:20:3 in 
Jul 09 09:27:41 + retcode=1
Jul 09 09:27:41 + set -e
Jul 09 09:27:41 + return 1
Jul 09 09:27:41 + [[ pytorch-linux-xenial-py3-clang5-asan-test1 == *-NO_AVX-* ]]
Jul 09 09:27:41 + [[ pytorch-linux-xenial-py3-clang5-asan-test1 == *-NO_AVX2-* ]]
Jul 09 09:27:41 + '[' -n https://github.com/pytorch/pytorch/pull/60639 ']'
Jul 09 09:27:41 + [[ pytorch-linux-xenial-py3-clang5-asan-test1 != *coverage* ]]
Jul 09 09:27:41 ++ mktemp
Jul 09 09:27:41 + DETERMINE_FROM=/tmp/tmp.OdAbZzKLsp
Jul 09 09:27:41 + file_diff_from_base /tmp/tmp.OdAbZzKLsp

Preview docs built from this PR

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

pmeier added a commit that referenced this pull request Jun 24, 2021
@pmeier
change language from array to tensor
5975f4e 
ghstack-source-id: f2d7e59
Pull Request resolved: #60639
@pmeier pmeier requested a review from mruberry June 24, 2021 08:56
@pmeier pmeier added the module: testing Issues related to the torch.testing module (not tests) label Jun 24, 2021
pmeier added a commit that referenced this pull request Jun 24, 2021
@pmeier
change language from array to tensor
f26204c 
ghstack-source-id: d928c6e
Pull Request resolved: #60639
@pmeier pmeier mentioned this pull request Jun 30, 2021
Closed
mruberry
mruberry approved these changes Jul 8, 2021
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamped. "tensor-or-scalar-like" seems like an OK phrase to me.

@mruberry
Copy link
Collaborator

mruberry commented Jul 8, 2021

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@mruberry
Copy link
Collaborator

mruberry commented Jul 9, 2021

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mruberry merged this pull request in 5401dd2.

@facebook-github-bot facebook-github-bot deleted the gh/pmeier/28/head branch July 13, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mruberry mruberry mruberry approved these changes

Assignees

No one assigned

Labels

cla signed Merged module: testing Issues related to the torch.testing module (not tests) open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pmeier @facebook-github-bot @mruberry @pytorchbot