[Functional Optim] Test kwargs parity for SGD #62078
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that kwarg arguments such as momentum and weight decay maintain parity between optimizer.step and step_param. Differential Revision: [D29837942](https://our.internmc.facebook.com/intern/diff/D29837942/) [ghstack-poisoned]
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 3623e85 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Jul 23, 2021
Ensure that kwarg arguments such as momentum and weight decay maintain parity between optimizer.step and step_param. Differential Revision: [D29837942](https://our.internmc.facebook.com/intern/diff/D29837942/) [ghstack-poisoned]
Ensure that kwarg arguments such as momentum and weight decay maintain parity between optimizer.step and step_param. Differential Revision: [D29837942](https://our.internmc.facebook.com/intern/diff/D29837942/) [ghstack-poisoned]
wayi1
approved these changes
Jul 23, 2021
Ensure that kwarg arguments such as momentum and weight decay maintain parity between optimizer.step and step_param. Differential Revision: [D29837942](https://our.internmc.facebook.com/intern/diff/D29837942/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Jul 23, 2021
Pull Request resolved: #62078 Ensure that kwarg arguments such as momentum and weight decay maintain parity between optimizer.step and step_param. ghstack-source-id: 134234266 Differential Revision: [D29837942](https://our.internmc.facebook.com/intern/diff/D29837942/)
Ensure that kwarg arguments such as momentum and weight decay maintain parity between optimizer.step and step_param. Differential Revision: [D29837942](https://our.internmc.facebook.com/intern/diff/D29837942/) [ghstack-poisoned]
Ensure that kwarg arguments such as momentum and weight decay maintain parity between optimizer.step and step_param. Differential Revision: [D29837942](https://our.internmc.facebook.com/intern/diff/D29837942/) [ghstack-poisoned]
Ensure that kwarg arguments such as momentum and weight decay maintain parity between optimizer.step and step_param. Differential Revision: [D29837942](https://our.internmc.facebook.com/intern/diff/D29837942/) [ghstack-poisoned]
|
This pull request has been merged in c0ebeca. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Ensure that kwarg arguments such as momentum and weight decay maintain
parity between optimizer.step and step_param.
Differential Revision: D29837942