[DDP/Functional Optim] Support kwarg arguments #62079
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for kwarg arguments into functional optimizer running as hook. Differential Revision: [D29838127](https://our.internmc.facebook.com/intern/diff/D29838127/) [ghstack-poisoned]
rohan-varma
requested review from
H-Huang,
cbalioglu,
mingzhe09088,
mrshenli,
pritamdamania87,
wayi1 and
zhaojuanmao
as code owners
facebook-github-bot
added
oncall: distributed
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 1acfce9 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Jul 23, 2021
Adds support for kwarg arguments into functional optimizer running as hook. Differential Revision: [D29838127](https://our.internmc.facebook.com/intern/diff/D29838127/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Jul 23, 2021
Pull Request resolved: #62079 Adds support for kwarg arguments into functional optimizer running as hook. ghstack-source-id: 134166276 Differential Revision: [D29838127](https://our.internmc.facebook.com/intern/diff/D29838127/)
Adds support for kwarg arguments into functional optimizer running as hook. Differential Revision: [D29838127](https://our.internmc.facebook.com/intern/diff/D29838127/) [ghstack-poisoned]
wayi1
reviewed
Jul 23, 2021
| self.functional_optimizer = functional_optim_cls( | ||
| [], | ||
| *self.functional_optim_args, | ||
| *functional_optim_args, |
There was a problem hiding this comment.
Optimizers usually only have kwargs. Do you have any example that needs args?
There was a problem hiding this comment.
AFAIK user is able to construct regular optimizer without specifying kwargs and just using the parameter order in constructor:
s = torch.optim.SGD(torch.nn.Linear(1,1).parameters(), 0.01)
so wanted to support the same behavior here.
wayi1
approved these changes
Jul 23, 2021
Adds support for kwarg arguments into functional optimizer running as hook. Differential Revision: [D29838127](https://our.internmc.facebook.com/intern/diff/D29838127/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Jul 23, 2021
Pull Request resolved: #62079 Adds support for kwarg arguments into functional optimizer running as hook. ghstack-source-id: 134219582 Differential Revision: [D29838127](https://our.internmc.facebook.com/intern/diff/D29838127/)
Adds support for kwarg arguments into functional optimizer running as hook. Differential Revision: [D29838127](https://our.internmc.facebook.com/intern/diff/D29838127/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Jul 23, 2021
Pull Request resolved: #62079 Adds support for kwarg arguments into functional optimizer running as hook. ghstack-source-id: 134239594 Differential Revision: [D29838127](https://our.internmc.facebook.com/intern/diff/D29838127/)
Adds support for kwarg arguments into functional optimizer running as hook. Differential Revision: [D29838127](https://our.internmc.facebook.com/intern/diff/D29838127/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Jul 24, 2021
Pull Request resolved: #62079 Adds support for kwarg arguments into functional optimizer running as hook. ghstack-source-id: 134249089 Differential Revision: [D29838127](https://our.internmc.facebook.com/intern/diff/D29838127/)
Adds support for kwarg arguments into functional optimizer running as hook. Differential Revision: [D29838127](https://our.internmc.facebook.com/intern/diff/D29838127/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Jul 26, 2021
Pull Request resolved: #62079 Adds support for kwarg arguments into functional optimizer running as hook. ghstack-source-id: 134282611 Differential Revision: [D29838127](https://our.internmc.facebook.com/intern/diff/D29838127/)
Adds support for kwarg arguments into functional optimizer running as hook. Differential Revision: [D29838127](https://our.internmc.facebook.com/intern/diff/D29838127/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Jul 26, 2021
Pull Request resolved: #62079 Adds support for kwarg arguments into functional optimizer running as hook. ghstack-source-id: 134330379 Differential Revision: [D29838127](https://our.internmc.facebook.com/intern/diff/D29838127/)
|
This pull request has been merged in 64283fe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Adds support for kwarg arguments into functional optimizer running as
hook.
Differential Revision: D29838127