KEMBAR78
[ao][docs] Clarify operator support for quantization by raghuramank100 · Pull Request #63270 · pytorch/pytorch · GitHub
Skip to content

[ao][docs] Clarify operator support for quantization #63270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 16 commits into from
Closed

[ao][docs] Clarify operator support for quantization #63270

wants to merge 16 commits into from

Conversation

@raghuramank100
Copy link
Contributor

@raghuramank100 raghuramank100 commented Aug 14, 2021 •
edited
Loading

Stack from ghstack:

Summary:
Add table to quantization main page showing supported modules
for static and dynamic quantization.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D30658654

@raghuramank10000
[ao][docs] Clarify operator support for quantization
e9a7f86 
Summary:
Add table to quantization main page showing supported modules
for static and dynamic quantization.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@raghuramank100 raghuramank100 mentioned this pull request Aug 14, 2021
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 14, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 0caad43 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@raghuramank10000
Update on "[ao][docs] Clarify operator support for quantization"
2fd7c4d 
Summary:
Add table to quantization main page showing supported modules
for static and dynamic quantization.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
raghuramank100 pushed a commit that referenced this pull request Aug 14, 2021
@raghuramank10000
[ao][docs] Clarify operator support for quantization
8e842f9 
Summary:
Add table to quantization main page showing supported modules
for static and dynamic quantization.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: ae646e8
Pull Request resolved: #63270
@raghuramank100 raghuramank100 mentioned this pull request Aug 19, 2021
Closed
@raghuramank10000
Update on "[ao][docs] Clarify operator support for quantization"
410856c 
Summary:
Add table to quantization main page showing supported modules
for static and dynamic quantization.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@raghuramank10000
Update on "[ao][docs] Clarify operator support for quantization"
7e2cfbe 
Summary:
Add table to quantization main page showing supported modules
for static and dynamic quantization.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@raghuramank10000
Update on "[ao][docs] Clarify operator support for quantization"
e35bd7b 
Summary:
Add table to quantization main page showing supported modules
for static and dynamic quantization.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
raghuramank100 pushed a commit that referenced this pull request Aug 19, 2021
@raghuramank10000
[ao][docs] Clarify operator support for quantization
0e1c21b 
Summary:
Add table to quantization main page showing supported modules
for static and dynamic quantization.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 182a903
Pull Request resolved: #63270
@raghuramank10000
Update on "[ao][docs] Clarify operator support for quantization"
5672f80 
Summary:
Add table to quantization main page showing supported modules
for static and dynamic quantization.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@raghuramank10000
Update on "[ao][docs] Clarify operator support for quantization"
1ae7d61 
Summary:
Add table to quantization main page showing supported modules
for static and dynamic quantization.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
raghuramank100 pushed a commit that referenced this pull request Aug 19, 2021
@raghuramank10000
[ao][docs] Clarify operator support for quantization
a510d50 
Summary:
Add table to quantization main page showing supported modules
for static and dynamic quantization.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 308ebc1
Pull Request resolved: #63270
vkuzo
vkuzo approved these changes Aug 23, 2021
View reviewed changes
docs/source/quantization.rst Outdated
|nn.Conv1d/2d/3d | Y | N |
+-----------------+-------------------+-------------------+
|nn.LSTM | N | Y |
|nn.GRU | | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: specify for each line, to stay consistent with L170:L171?

docs/source/quantization.rst Outdated
Comment on lines 177 to 178
|nn.GRUCell | | |
|nn.LSTMCell | | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

docs/source/quantization.rst Outdated
+-----------------+-------------------+-------------------+
|nn.Embedding | Y | N |
+-----------------+-------------------+-------------------+
|nn.MHA |* Supported via | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we spell out the name (not everyone will know what MHA means), and should we consider not saying this is supported yet until there is a clear long term strategy and clear documentation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, will change that.

@raghuramank10000
Update on "[ao][docs] Clarify operator support for quantization"
c46a11c 
Summary:
Add table to quantization main page showing supported modules
for static and dynamic quantization.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
raghuramank100 pushed a commit that referenced this pull request Aug 26, 2021
@raghuramank10000
[ao][docs] Clarify operator support for quantization
7e23f01 
Summary:
Add table to quantization main page showing supported modules
for static and dynamic quantization.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 322a7c1
Pull Request resolved: #63270
@raghuramank10000
Update on "[ao][docs] Clarify operator support for quantization"
76641ab 
Summary:
Add table to quantization main page showing supported modules
for static and dynamic quantization.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
raghuramank100 pushed a commit that referenced this pull request Aug 26, 2021
@raghuramank10000
[ao][docs] Clarify operator support for quantization
5fdcf79 
Summary:
Add table to quantization main page showing supported modules
for static and dynamic quantization.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 5ad9377
Pull Request resolved: #63270
@raghuramank10000
Update on "[ao][docs] Clarify operator support for quantization"
6c32d11 
Summary:
Add table to quantization main page showing supported modules
for static and dynamic quantization.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@raghuramank10000
Update on "[ao][docs] Clarify operator support for quantization"
acccb9f 
Summary:
Add table to quantization main page showing supported modules
for static and dynamic quantization.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@raghuramank10000
Update on "[ao][docs] Clarify operator support for quantization"
01a949a 
Summary:
Add table to quantization main page showing supported modules
for static and dynamic quantization.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@raghuramank10000
Update on "[ao][docs] Clarify operator support for quantization"
0d18760 
Summary:
Add table to quantization main page showing supported modules
for static and dynamic quantization.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
raghuramank100 pushed a commit that referenced this pull request Aug 31, 2021
@raghuramank10000
[ao][docs] Clarify operator support for quantization
b3efd23 
Summary:
Add table to quantization main page showing supported modules
for static and dynamic quantization.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 4058af5
Pull Request resolved: #63270
@raghuramank100
Copy link
Contributor Author

@raghuramank100 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@raghuramank10000
Update on "[ao][docs] Clarify operator support for quantization"
6fe2793 
Summary:
Add table to quantization main page showing supported modules
for static and dynamic quantization.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D30658654](https://our.internmc.facebook.com/intern/diff/D30658654)

[ghstack-poisoned]
@raghuramank10000
Update on "[ao][docs] Clarify operator support for quantization"
8c3ca6d 
Summary:
Add table to quantization main page showing supported modules
for static and dynamic quantization.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D30658654](https://our.internmc.facebook.com/intern/diff/D30658654)

[ghstack-poisoned]
raghuramank100 pushed a commit that referenced this pull request Aug 31, 2021
@raghuramank10000
[ao][docs] Clarify operator support for quantization
418ff1e 
Pull Request resolved: #63270



Add table to quantization main page showing supported modules
for static and dynamic quantization.
ghstack-source-id: 137049017

Differential Revision: [D30658654](https://our.internmc.facebook.com/intern/diff/D30658654/)
@raghuramank10000
Update on "[ao][docs] Clarify operator support for quantization"
0caad43 
Summary:
Add table to quantization main page showing supported modules
for static and dynamic quantization.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D30658654](https://our.internmc.facebook.com/intern/diff/D30658654)

[ghstack-poisoned]
raghuramank100 pushed a commit that referenced this pull request Aug 31, 2021
@raghuramank10000
[ao][docs] Clarify operator support for quantization
256e045 
Pull Request resolved: #63270



Add table to quantization main page showing supported modules
for static and dynamic quantization.
ghstack-source-id: 137087204

Differential Revision: [D30658654](https://our.internmc.facebook.com/intern/diff/D30658654/)
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 347ef69.

@facebook-github-bot facebook-github-bot deleted the gh/raghuramank100/51/head branch September 4, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkuzo vkuzo vkuzo approved these changes

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168

@supriyar supriyar Awaiting requested review from supriyar

Assignees

No one assigned

Labels

cla signed hackathon Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@raghuramank100 @facebook-github-bot @vkuzo @supriyar @raghuramank10000