[ao][docs] Add description of qconfig and qengine to quantization page #63582
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Current quantization docs do not define qconfig and qengine. Added text to define these concepts before they are used. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit c97c77e (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
…ization page" Summary: Current quantization docs do not define qconfig and qengine. Added text to define these concepts before they are used. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…ization page" Summary: Current quantization docs do not define qconfig and qengine. Added text to define these concepts before they are used. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…ization page" Summary: Current quantization docs do not define qconfig and qengine. Added text to define these concepts before they are used. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
supriyar
reviewed
Aug 24, 2021
docs/source/quantization.rst
Outdated
| 1. Quantization Config (Qconfig): Specifies how weights and activations are to be quantized. Qconfig is needed to create a quantized model. | ||
| 2. Backend: Refers to kernels that support quantization, usually with different numerics. | ||
| 3. Quantization engine (torch.backends.quantization.engine): When a quantized model is executed, the qengine specifies which | ||
| backed is to be used for execution. It is important to ensure that the qengine is consistent with the Qconfig. |
There was a problem hiding this comment.
Is the new line here required?
supriyar
reviewed
Aug 24, 2021
|
|
||
| The corresponding implementation is chosen automatically based on the PyTorch build mode. | ||
| The corresponding implementation is chosen automatically based on the PyTorch build mode, though users | ||
| have the option to override this by setting `torch.backends.quantization.engine` to `fbgemm` or `qnnpack`. |
There was a problem hiding this comment.
maybe adding a small code-block here specifying how to override would be helpful
supriyar
approved these changes
Aug 24, 2021
…ization page" Summary: Current quantization docs do not define qconfig and qengine. Added text to define these concepts before they are used. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…ization page" Summary: Current quantization docs do not define qconfig and qengine. Added text to define these concepts before they are used. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…ization page" Summary: Current quantization docs do not define qconfig and qengine. Added text to define these concepts before they are used. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…ization page" Summary: Current quantization docs do not define qconfig and qengine. Added text to define these concepts before they are used. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
|
@raghuramank100 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…ization page" Summary: Current quantization docs do not define qconfig and qengine. Added text to define these concepts before they are used. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D30658656](https://our.internmc.facebook.com/intern/diff/D30658656) [ghstack-poisoned]
…ization page" Summary: Current quantization docs do not define qconfig and qengine. Added text to define these concepts before they are used. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D30658656](https://our.internmc.facebook.com/intern/diff/D30658656) [ghstack-poisoned]
…ization page" Summary: Current quantization docs do not define qconfig and qengine. Added text to define these concepts before they are used. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D30658656](https://our.internmc.facebook.com/intern/diff/D30658656) [ghstack-poisoned]
…ization page" Summary: Current quantization docs do not define qconfig and qengine. Added text to define these concepts before they are used. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D30658656](https://our.internmc.facebook.com/intern/diff/D30658656) [ghstack-poisoned]
…ization page" Summary: Current quantization docs do not define qconfig and qengine. Added text to define these concepts before they are used. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D30658656](https://our.internmc.facebook.com/intern/diff/D30658656) [ghstack-poisoned]
raghuramank100
pushed a commit
that referenced
this pull request
Aug 31, 2021
Pull Request resolved: #63582 Current quantization docs do not define qconfig and qengine. Added text to define these concepts before they are used. ghstack-source-id: 137051719 Differential Revision: [D30658656](https://our.internmc.facebook.com/intern/diff/D30658656/)
|
This pull request has been merged in b9275a4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Current quantization docs do not define qconfig and qengine. Added text to define these concepts before they are used.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D30658656