remove componentwise comparison of complex values in TestCase.assertEqual #63572

CONFLICT (add/add): Merge conflict in .circleci/scripts/cpp_doc_push_script.sh
Auto-merging .circleci/scripts/cpp_doc_push_script.sh
CONFLICT (add/add): Merge conflict in .circleci/scripts/binary_macos_build.sh
Auto-merging .circleci/scripts/binary_macos_build.sh
CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_definitions.py
Auto-merging .circleci/cimodel/data/pytorch_build_definitions.py
CONFLICT (add/add): Merge conflict in .bazelrc
Auto-merging .bazelrc
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

pytorch_paralleltbb_linux_xenial_py3_6_gcc5_4_build (2/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.

CONFLICT (add/add): Merge conflict in .circleci/scripts/cpp_doc_push_script.sh
Auto-merging .circleci/scripts/cpp_doc_push_script.sh
CONFLICT (add/add): Merge conflict in .circleci/scripts/binary_macos_build.sh
Auto-merging .circleci/scripts/binary_macos_build.sh
CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_definitions.py
Auto-merging .circleci/cimodel/data/pytorch_build_definitions.py
CONFLICT (add/add): Merge conflict in .bazelrc
Auto-merging .bazelrc
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

pytorch_parallelnative_linux_xenial_py3_6_gcc5_4_build (3/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.

CONFLICT (add/add): Merge conflict in .circleci/scripts/cpp_doc_push_script.sh
Auto-merging .circleci/scripts/cpp_doc_push_script.sh
CONFLICT (add/add): Merge conflict in .circleci/scripts/binary_macos_build.sh
Auto-merging .circleci/scripts/binary_macos_build.sh
CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_definitions.py
Auto-merging .circleci/cimodel/data/pytorch_build_definitions.py
CONFLICT (add/add): Merge conflict in .bazelrc
Auto-merging .bazelrc
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

…qual ghstack-source-id: cb9f2ff Pull Request resolved: #63572

…ase.assertEqual" Addresses #61906. Issue will be fixed later in the stack when `torch.testing.assert_close` got the same treatment. [ghstack-poisoned]

…qual ghstack-source-id: 476d75b Pull Request resolved: #63572

pmeier · 2021-08-23T13:17:53Z

There is one issue that materializes for example in test_tensor_creation_ops.TestRandomTensorCreation.test_randn:

>>> t = torch.tensor(0, dtype=torch.complex32)
>>> torch.allclose(t, t)
RuntimeError: "eq_cpu" not implemented for 'ComplexHalf'
>>> t = t.cuda()
>>> torch.allclose(t, t)
RuntimeError: "eq_cuda" not implemented for 'ComplexHalf'

Previously one complex32 was treated as two float16 which prevents this. We could skip complex32 in all tests that compare values, but for the future equality should be supported for these values.

…ase.assertEqual" Addresses #61906. Issue will be fixed later in the stack when `torch.testing.assert_close` got the same treatment. [ghstack-poisoned]

…qual ghstack-source-id: edde9eb Pull Request resolved: #63572

mruberry · 2021-08-25T13:17:25Z

Some (one?) of the test failures seem real:

test_randn_cpu_complex32 - TestRandomTensorCreationCPU

Traceback (most recent call last):
  File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 378, in instantiated_test
    raise rte
  File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 373, in instantiated_test
    result = test(self, **param_kwargs)
  File "test_tensor_creation_ops.py", line 3269, in test_randn
    self.assertEqual(res1, res2)
  File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 1550, in assertEqual
    exact_device=exact_device)
  File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 1415, in _compareTensors
    return _compare_tensors_internal(a, b, rtol=rtol, atol=atol, equal_nan=equal_nan)
  File "/opt/conda/lib/python3.6/site-packages/torch/testing/_core.py", line 118, in _compare_tensors_internal
    if torch.allclose(a, b, rtol=rtol, atol=atol, equal_nan=equal_nan):
RuntimeError: "eq_cpu" not implemented for 'ComplexHalf'

A fix for this could be to implement allclose for complexhalf or to upcast complexhalf tensors in assertEqual/compareTensors/assert_close.

mruberry · 2021-08-25T13:17:41Z

cc @zasdfgbnm

pmeier · 2021-08-25T13:49:05Z

A fix for this could be to implement allclose for complexhalf or to upcast complexhalf tensors in assertEqual/compareTensors/assert_close.

It is not allclose, but rather equality:

>>> t = torch.tensor(0, dtype=torch.complex32)
>>> t == t
RuntimeError: "eq_cpu" not implemented for 'ComplexHalf'
>>> t = t.cuda()
>>> t == t
RuntimeError: "eq_cuda" not implemented for 'ComplexHalf'

Feels weird that this fundamental method is not there.

anjali411 · 2021-08-25T14:54:45Z

A fix for this could be to implement allclose for complexhalf or to upcast complexhalf tensors in assertEqual/compareTensors/assert_close.

It is not allclose, but rather equality:
>>> t = torch.tensor(0, dtype=torch.complex32)
>>> t == t
RuntimeError: "eq_cpu" not implemented for 'ComplexHalf'
>>> t = t.cuda()
>>> t == t
RuntimeError: "eq_cuda" not implemented for 'ComplexHalf'
Feels weird that this fundamental method is not there.

There's bare minimum support for ComplexHalf. In fact, we should probably just remove the ComplexHalf dtype until enough functionality is added.

As for the failing tests for this PR, it's safe to disable any test for torch.complex32.

@ezyang

…ase.assertEqual" Addresses #61906. Issue will be fixed later in the stack when `torch.testing.assert_close` got the same treatment. cc @ezyang @gchanan [ghstack-poisoned]

mruberry

Cool

mruberry · 2021-08-30T02:38:33Z

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2021-08-30T19:38:56Z

@mruberry merged this pull request in 401bbb2.

remove componentwise comparison of complex values in TestCase.assertE…

9508c4d

…qual [ghstack-poisoned]

pmeier mentioned this pull request Aug 19, 2021

enable equal_nan for complex values in isclose #63571

Closed

facebook-github-bot added the cla signed label Aug 19, 2021

pmeier added a commit that referenced this pull request Aug 19, 2021

remove componentwise comparison of complex values in TestCase.assertE…

1da9995

…qual ghstack-source-id: cb9f2ff Pull Request resolved: #63572

pytorchbot added the open source label Aug 19, 2021

Update on "remove componentwise comparison of complex values in TestC…

44d0217

…ase.assertEqual" Addresses #61906. Issue will be fixed later in the stack when `torch.testing.assert_close` got the same treatment. [ghstack-poisoned]

pmeier added a commit that referenced this pull request Aug 23, 2021

remove componentwise comparison of complex values in TestCase.assertE…

01de995

…qual ghstack-source-id: 476d75b Pull Request resolved: #63572

Update on "remove componentwise comparison of complex values in TestC…

db572b7

…ase.assertEqual" Addresses #61906. Issue will be fixed later in the stack when `torch.testing.assert_close` got the same treatment. [ghstack-poisoned]

pmeier added a commit that referenced this pull request Aug 24, 2021

remove componentwise comparison of complex values in TestCase.assertE…

ce891da

…qual ghstack-source-id: edde9eb Pull Request resolved: #63572

pmeier mentioned this pull request Aug 24, 2021

remove componentwise comparison of complex values in torch.testing.assert_close #63841

Closed

pmeier marked this pull request as ready for review August 24, 2021 06:00

pmeier requested a review from mruberry August 24, 2021 06:00

pmeier added module: bc-breaking Related to a BC-breaking change module: testing Issues related to the torch.testing module (not tests) labels Aug 24, 2021

mruberry requested a review from anjali411 August 25, 2021 13:17

Update on "remove componentwise comparison of complex values in TestC…

2b0074a

…ase.assertEqual" Addresses #61906. Issue will be fixed later in the stack when `torch.testing.assert_close` got the same treatment. cc @ezyang @gchanan [ghstack-poisoned]

mruberry added the ci/master label Aug 30, 2021

mruberry approved these changes Aug 30, 2021

View reviewed changes

facebook-github-bot closed this in 401bbb2 Aug 30, 2021

facebook-github-bot added the Merged label Aug 30, 2021

facebook-github-bot deleted the gh/pmeier/35/head branch September 3, 2021 14:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

remove componentwise comparison of complex values in TestCase.assertEqual #63572

remove componentwise comparison of complex values in TestCase.assertEqual #63572

Uh oh!

pmeier commented Aug 19, 2021 •

edited by mruberry

Loading

Uh oh!

facebook-github-bot commented Aug 19, 2021 •

edited

Loading

Uh oh!

pmeier commented Aug 23, 2021

Uh oh!

mruberry commented Aug 25, 2021

Uh oh!

mruberry commented Aug 25, 2021

Uh oh!

pmeier commented Aug 25, 2021

Uh oh!

anjali411 commented Aug 25, 2021 •

edited

Loading

Uh oh!

mruberry left a comment

Uh oh!

mruberry commented Aug 30, 2021

Uh oh!

facebook-github-bot commented Aug 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

remove componentwise comparison of complex values in TestCase.assertEqual #63572

remove componentwise comparison of complex values in TestCase.assertEqual #63572

Uh oh!

Conversation

pmeier commented Aug 19, 2021 • edited by mruberry Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Aug 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

🕵️ 3 new failures recognized by patterns

pytorch_pure_torch_linux_xenial_py3_6_gcc5_4_build (1/3)

pytorch_paralleltbb_linux_xenial_py3_6_gcc5_4_build (2/3)

pytorch_parallelnative_linux_xenial_py3_6_gcc5_4_build (3/3)

Uh oh!

pmeier commented Aug 23, 2021

Uh oh!

mruberry commented Aug 25, 2021

Uh oh!

mruberry commented Aug 25, 2021

Uh oh!

pmeier commented Aug 25, 2021

Uh oh!

anjali411 commented Aug 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mruberry left a comment

Choose a reason for hiding this comment

Uh oh!

mruberry commented Aug 30, 2021

Uh oh!

facebook-github-bot commented Aug 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pmeier commented Aug 19, 2021 •

edited by mruberry

Loading

facebook-github-bot commented Aug 19, 2021 •

edited

Loading

anjali411 commented Aug 25, 2021 •

edited

Loading