remove componentwise comparison of complex values in torch.testing.assert_close #63841

2021-08-30T07:29:17.7433772Z 
2021-08-30T07:29:17.7434094Z Folders: 11
2021-08-30T07:29:17.7434440Z Files: 130
2021-08-30T07:29:17.7434755Z Size:       907512
2021-08-30T07:29:17.7435127Z Compressed: 111420
2021-08-30T07:29:17.7494190Z + mkdir -p 'C:/Program Files/NVIDIA Corporation/NvToolsExt'
2021-08-30T07:29:17.7830800Z + cp -r NvToolsExt/bin NvToolsExt/docs NvToolsExt/include NvToolsExt/lib NvToolsExt/samples 'C:/Program Files/NVIDIA Corporation/NvToolsExt/'
2021-08-30T07:29:24.0862982Z + export 'NVTOOLSEXT_PATH=C:\Program Files\NVIDIA Corporation\NvToolsExt\'
2021-08-30T07:29:24.0864283Z + NVTOOLSEXT_PATH='C:\Program Files\NVIDIA Corporation\NvToolsExt\'
2021-08-30T07:29:24.0865261Z + ls '/c/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v10.1/bin/nvcc.exe'
2021-08-30T07:29:24.1042403Z ls: cannot access '/c/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v10.1/bin/nvcc.exe': No such file or directory
2021-08-30T07:29:24.1046284Z + echo 'CUDA installation failed'
2021-08-30T07:29:24.1047211Z CUDA installation failed
2021-08-30T07:29:24.1048052Z + mkdir -p /c/w/build-results
2021-08-30T07:29:24.1216391Z + 7z a 'c:\w\build-results\cuda_install_logs.7z' cuda_install_logs
2021-08-30T07:29:25.4521259Z 
2021-08-30T07:29:25.4522607Z 7-Zip 19.00 (x64) : Copyright (c) 1999-2018 Igor Pavlov : 2019-02-21
2021-08-30T07:29:25.4523402Z 
2021-08-30T07:29:25.4524071Z Scanning the drive:
2021-08-30T07:29:25.4524886Z 1 folder, 2 files, 4205427 bytes (4107 KiB)
2021-08-30T07:29:25.4525483Z

pytorch_linux_xenial_py3_clang7_onnx_ort_test2 (2/5)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Aug 30 06:18:15 ../../../../opt/conda/lib/pytho...TestSparseLpNorm::test_sparse_lpnorm FAILED [ 95%]

Aug 30 06:18:13 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/softmax_ops_test.py::TestSoftmaxOps::test_spatial_softmax_with_loss PASSED [ 95%]
Aug 30 06:18:13 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/softmax_ops_test.py::TestSoftmaxOps::test_spatial_softmax_with_loss_allignore PASSED [ 95%]
Aug 30 06:18:14 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/softplus_op_test.py::TestSoftplus::test_softplus PASSED [ 95%]
Aug 30 06:18:14 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/sparse_dropout_with_replacement_op_test.py::SparseDropoutWithReplacementTest::test_all_dropout PASSED [ 95%]
Aug 30 06:18:14 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/sparse_dropout_with_replacement_op_test.py::SparseDropoutWithReplacementTest::test_all_dropout_empty_input PASSED [ 95%]
Aug 30 06:18:14 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/sparse_dropout_with_replacement_op_test.py::SparseDropoutWithReplacementTest::test_no_dropout PASSED [ 95%]
Aug 30 06:18:14 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/sparse_gradient_checker_test.py::TestSparseGradient::test_sparse_gradient PASSED [ 95%]
Aug 30 06:18:14 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/sparse_itemwise_dropout_with_replacement_op_test.py::SparseItemwiseDropoutWithReplacementTest::test_all_dropout PASSED [ 95%]
Aug 30 06:18:14 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/sparse_itemwise_dropout_with_replacement_op_test.py::SparseItemwiseDropoutWithReplacementTest::test_all_dropout_empty_input PASSED [ 95%]
Aug 30 06:18:14 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/sparse_itemwise_dropout_with_replacement_op_test.py::SparseItemwiseDropoutWithReplacementTest::test_no_dropout PASSED [ 95%]
Aug 30 06:18:15 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/operator_test/sparse_lp_regularizer_test.py::TestSparseLpNorm::test_sparse_lpnorm FAILED [ 95%]
Aug 30 06:18:15 
Aug 30 06:18:15 =================================== FAILURES ===================================
Aug 30 06:18:15 _____________________ TestSparseLpNorm.test_sparse_lpnorm ______________________
Aug 30 06:18:15 
Aug 30 06:18:15 self = <caffe2.python.operator_test.sparse_lp_regularizer_test.TestSparseLpNorm testMethod=test_sparse_lpnorm>
Aug 30 06:18:15 
Aug 30 06:18:15     @settings(suppress_health_check=[HealthCheck.filter_too_much])
Aug 30 06:18:15 >   @given(inputs=hu.tensors(n=1, min_dim=2, max_dim=2),
Aug 30 06:18:15            p=st.integers(min_value=1, max_value=2),
Aug 30 06:18:15            reg_lambda=st.floats(min_value=1e-4, max_value=1e-1),

pytorch_paralleltbb_linux_xenial_py3_6_gcc5_4_build (3/5)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.

CONFLICT (add/add): Merge conflict in .circleci/scripts/cpp_doc_push_script.sh
Auto-merging .circleci/scripts/cpp_doc_push_script.sh
CONFLICT (add/add): Merge conflict in .circleci/scripts/binary_macos_build.sh
Auto-merging .circleci/scripts/binary_macos_build.sh
CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_definitions.py
Auto-merging .circleci/cimodel/data/pytorch_build_definitions.py
CONFLICT (add/add): Merge conflict in .bazelrc
Auto-merging .bazelrc
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

pytorch_parallelnative_linux_xenial_py3_6_gcc5_4_build (4/5)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.

CONFLICT (add/add): Merge conflict in .circleci/scripts/cpp_doc_push_script.sh
Auto-merging .circleci/scripts/cpp_doc_push_script.sh
CONFLICT (add/add): Merge conflict in .circleci/scripts/binary_macos_build.sh
Auto-merging .circleci/scripts/binary_macos_build.sh
CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_definitions.py
Auto-merging .circleci/cimodel/data/pytorch_build_definitions.py
CONFLICT (add/add): Merge conflict in .bazelrc
Auto-merging .bazelrc
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

pytorch_pure_torch_linux_xenial_py3_6_gcc5_4_build (5/5)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.

CONFLICT (add/add): Merge conflict in .circleci/scripts/cpp_doc_push_script.sh
Auto-merging .circleci/scripts/cpp_doc_push_script.sh
CONFLICT (add/add): Merge conflict in .circleci/scripts/binary_macos_build.sh
Auto-merging .circleci/scripts/binary_macos_build.sh
CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_definitions.py
Auto-merging .circleci/cimodel/data/pytorch_build_definitions.py
CONFLICT (add/add): Merge conflict in .bazelrc
Auto-merging .bazelrc
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

…sert_close ghstack-source-id: e4ad9b8 Pull Request resolved: #63841

@ezyang

….testing.assert_close" Closes #61906. cc @ezyang @gchanan [ghstack-poisoned]

…sert_close ghstack-source-id: 97f8107 Pull Request resolved: #63841

test/test_testing.py

torch/testing/_asserts.py

mruberry

Cool simplification but maybe a little too aggressive with the conjugate bit test? I also have a name suggestion (naming things is hard but XXX seems easy to improve on)

mruberry · 2021-08-30T02:38:39Z

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ezyang

….testing.assert_close" Closes #61906. cc @ezyang @gchanan Differential Revision: [D30633526](https://our.internmc.facebook.com/intern/diff/D30633526) [ghstack-poisoned]

…sert_close ghstack-source-id: be361da Pull Request resolved: #63841

mruberry

Cool!

mruberry · 2021-08-30T06:54:11Z

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2021-08-30T19:39:00Z

@mruberry merged this pull request in eafe33c.

remove componentwise comparison of complex values in torch.testing.as…

253e4bf

…sert_close [ghstack-poisoned]

This was referenced Aug 24, 2021

enable equal_nan for complex values in isclose #63571

Closed

remove componentwise comparison of complex values in TestCase.assertEqual #63572

Closed

facebook-github-bot added the cla signed label Aug 24, 2021

pmeier added a commit that referenced this pull request Aug 24, 2021

remove componentwise comparison of complex values in torch.testing.as…

e7d4b0b

…sert_close ghstack-source-id: e4ad9b8 Pull Request resolved: #63841

pmeier requested a review from mruberry August 24, 2021 06:00

pmeier linked an issue Aug 24, 2021 that may be closed by this pull request

RESOLVED: Retire component-wise closeness tests for complex tensors #61906

Closed

pmeier added module: bc-breaking Related to a BC-breaking change module: testing Issues related to the torch.testing module (not tests) labels Aug 24, 2021

pytorchbot added the open source label Aug 24, 2021

Update on "remove componentwise comparison of complex values in torch…

6af2275

….testing.assert_close" Closes #61906. cc @ezyang @gchanan [ghstack-poisoned]

pmeier added a commit that referenced this pull request Aug 26, 2021

remove componentwise comparison of complex values in torch.testing.as…

e878792

…sert_close ghstack-source-id: 97f8107 Pull Request resolved: #63841

mruberry added the ci/master label Aug 30, 2021

mruberry reviewed Aug 30, 2021

View reviewed changes

test/test_testing.py Show resolved Hide resolved

mruberry reviewed Aug 30, 2021

View reviewed changes

torch/testing/_asserts.py Outdated Show resolved Hide resolved

mruberry reviewed Aug 30, 2021

View reviewed changes

Update on "remove componentwise comparison of complex values in torch…

4e8c80e

….testing.assert_close" Closes #61906. cc @ezyang @gchanan Differential Revision: [D30633526](https://our.internmc.facebook.com/intern/diff/D30633526) [ghstack-poisoned]

pmeier added a commit that referenced this pull request Aug 30, 2021

remove componentwise comparison of complex values in torch.testing.as…

ce58607

…sert_close ghstack-source-id: be361da Pull Request resolved: #63841

mruberry self-requested a review August 30, 2021 06:53

mruberry approved these changes Aug 30, 2021

View reviewed changes

facebook-github-bot closed this in eafe33c Aug 30, 2021

facebook-github-bot added the Merged label Aug 30, 2021

facebook-github-bot deleted the gh/pmeier/36/head branch September 3, 2021 14:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

remove componentwise comparison of complex values in torch.testing.assert_close #63841

remove componentwise comparison of complex values in torch.testing.assert_close #63841

Uh oh!

pmeier commented Aug 24, 2021 •

edited by mruberry

Loading

Uh oh!

facebook-github-bot commented Aug 24, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

mruberry left a comment

Uh oh!

mruberry commented Aug 30, 2021

Uh oh!

mruberry left a comment

Uh oh!

mruberry commented Aug 30, 2021

Uh oh!

facebook-github-bot commented Aug 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

remove componentwise comparison of complex values in torch.testing.assert_close #63841

remove componentwise comparison of complex values in torch.testing.assert_close #63841

Uh oh!

Conversation

pmeier commented Aug 24, 2021 • edited by mruberry Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Aug 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

🕵️ 5 new failures recognized by patterns

win-vs2019-cuda10.1-py3 / test (default, 1, 1, windows.8xlarge.nvidia.gpu) (1/5)

pytorch_linux_xenial_py3_clang7_onnx_ort_test2 (2/5)

pytorch_paralleltbb_linux_xenial_py3_6_gcc5_4_build (3/5)

pytorch_parallelnative_linux_xenial_py3_6_gcc5_4_build (4/5)

pytorch_pure_torch_linux_xenial_py3_6_gcc5_4_build (5/5)

Uh oh!

Uh oh!

Uh oh!

mruberry left a comment

Choose a reason for hiding this comment

Uh oh!

mruberry commented Aug 30, 2021

Uh oh!

mruberry left a comment

Choose a reason for hiding this comment

Uh oh!

mruberry commented Aug 30, 2021

Uh oh!

facebook-github-bot commented Aug 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pmeier commented Aug 24, 2021 •

edited by mruberry

Loading

facebook-github-bot commented Aug 24, 2021 •

edited

Loading