Update CMake minimum version to 3.10 #63660

peterbell10 · 2021-08-20T19:12:35Z

Stack from ghstack:

Differential Revision:

Differential Revision: D30543878

cc @malfet @seemethere @walterddr

[ghstack-poisoned]

facebook-github-bot · 2021-08-20T19:12:41Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/63660
📄 Preview docs built from this PR

💊 CI failures summary and remediations

As of commit d903bea (more details on the Dr. CI page):

1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

docker-pytorch-linux-xenial-cuda11.3-cudnn8-py3-gcc7 (1/1)

Step: "build_docker_image_pytorch-linux-xenial-cuda11.3-cudnn8-py3-gcc7" (full log | diagnosis details | 🔁 rerun)

executor failed running [/bin/sh -c if [ -n "${...hen bash ./install_protobuf.sh; fi]: exit code: 28

#19 5.909 + curl -LO https://github.com/protocolbuffers/protobuf/releases/download/v3.17.3/protobuf-all-3.17.3.tar.gz
#19 5.915   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
#19 5.915                                  Dload  Upload   Total   Spent    Left  Speed
#19 5.915 
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   632  100   632    0     0   1912      0 --:--:-- --:--:-- --:--:--  1915
#19 7.451 
  0     0    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:02 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:03 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:04 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:05 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:06 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:07 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:08 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:09 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:10 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:11 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:12 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:13 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:14 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:15 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:16 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:17 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:18 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:19 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:20 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:21 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:22 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:23 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:24 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:25 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:26 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:27 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:28 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:29 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:30 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:31 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:32 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:33 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:34 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:35 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:36 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:37 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:38 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:39 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:40 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:41 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:42 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:43 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:44 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:45 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:46 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:47 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:48 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:49 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:50 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:51 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:52 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:53 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:54 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:55 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:56 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:57 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:58 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:59 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:01:00 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:01:01 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:01:02 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:01:03 --:--:--     0
  0     0   
#19 306.8 curl: (28) Operation timed out after 0 milliseconds with 0 out of 0 bytes received
#19 ERROR: executor failed running [/bin/sh -c if [ -n "${PROTOBUF}" ]; then bash ./install_protobuf.sh; fi]: exit code: 28
------
 > [stage-0 15/36] RUN if [ -n "yes" ]; then bash ./install_protobuf.sh; fi:
------
executor failed running [/bin/sh -c if [ -n "${PROTOBUF}" ]; then bash ./install_protobuf.sh; fi]: exit code: 28
+ docker logout 308535385114.dkr.ecr.us-east-1.amazonaws.com
Removing login credentials for 308535385114.dkr.ecr.us-east-1.amazonaws.com


Exited with code exit status 1

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

[ghstack-poisoned]

malfet · 2021-08-23T21:56:14Z

LGTM, @ezyang any objections on your end?

malfet · 2021-08-23T22:10:53Z

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

ezyang · 2021-08-24T13:57:08Z

IIRC the main question is if the most recent LTS Ubuntu ships with cmake 3.10... does it?

peterbell10 · 2021-08-24T16:14:59Z

The most recent LTS is 20.04, and this command shows CMake 3.16.3 is on apt.

docker run -it ubuntu:20.04 sh -c "apt-get update -y && apt-get install cmake -y && cmake --version"

Running the same command with 18.04 installs CMake 3.10.2 so we even support the previous LTS release.

ezyang · 2021-08-24T17:10:18Z

Then we're good to go! :)

Differential Revision: [](https://our.internmc.facebook.com/intern/diff/) [ghstack-poisoned]

malfet · 2021-08-25T15:57:59Z

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

zhouzhuojie · 2021-08-25T16:02:48Z

Is this change comprehensive to include all the cmake in the codebase? e.g. one I can find is here https://github.com/pytorch/pytorch/blob/master/aten/src/ATen/cpu/tbb/CMakeLists.txt#L4

facebook-github-bot · 2021-08-25T16:27:00Z

This pull request has been merged in 5ab356f.

suo · 2021-08-25T17:39:06Z

@peterbell10 on #63918 I am getting new cmake minimum version errors on the pytorch_linux_xenial_py3_6_gcc5_4 docker image (affected job). I am planning to revert this change while we figure it out, is there anything special about this change that would make a revert messy?

edit: before reverting I'll try rebasing my PR in the hopes that will fix something
edit2: looks like rebasing fixed my issue https://app.circleci.com/pipelines/github/pytorch/pytorch/370528/workflows/b15949bd-6914-4942-9ff4-8b3bc0cc8c4d/jobs/15630396 and the hud looks clean, so I guess we're good here

peterbell10 · 2021-08-25T18:37:56Z

@peterbell10 on #63918 I am getting new cmake minimum version errors on the pytorch_linux_xenial_py3_6_gcc5_4 docker image (affected job).

The docker image is picked based on a hash of the folder in your branch, so it chooses the old docker image. Then master is merged into your PR which expects the CMake from the newer docker image. IIRC there's only a few CI jobs that merge with master like that though.

Summary: Due to pytorch/pytorch#63660, seeing issues like the following on CI. Trying to update to latest stable cmake 3.21 to unbreak. ``` + python setup.py install Building wheel torch-1.10.0a0+git5b548f6 CMake Error at CMakeLists.txt:1 (cmake_minimum_required): CMake 3.10 or higher is required. You are running version 3.5.1 ``` Pull Request resolved: #5798 Reviewed By: mortzur Differential Revision: D30560148 Pulled By: jfix71 fbshipit-source-id: d3a329e9d1e8fcdd115885f62a6d7a5b9cc07204

Update CMake minimum version to 3.10

bed654d

[ghstack-poisoned]

peterbell10 requested review from jeffdaily and jithunnair-amd as code owners August 20, 2021 19:12

facebook-github-bot added the cla signed label Aug 20, 2021

This was referenced Aug 20, 2021

Update CMake and use native CUDA language support #62445

Closed

Simplify ccache instructions in CONTRIBUTING.md #62549

Closed

peterbell10 mentioned this pull request Aug 20, 2021

Add workaround for nvcc header dependecies bug #62550

Closed

peterbell10 added ci/binaries module: build Build system issues labels Aug 20, 2021

Update on "Update CMake minimum version to 3.10"

a79f444

[ghstack-poisoned]

pytorchbot added the open source label Aug 20, 2021

Update on "Update CMake minimum version to 3.10"

19302d4

[ghstack-poisoned]

peterbell10 mentioned this pull request Aug 20, 2021

Fix docker image build #63663

Closed

Update on "Update CMake minimum version to 3.10"

44cf337

[ghstack-poisoned]

peterbell10 mentioned this pull request Aug 20, 2021

Fix pocketfft include path in mobile build #63714

Closed

peterbell10 added 4 commits August 21, 2021 04:56

Update on "Update CMake minimum version to 3.10"

9546259

[ghstack-poisoned]

Update on "Update CMake minimum version to 3.10"

42ce012

[ghstack-poisoned]

Update on "Update CMake minimum version to 3.10"

983263f

[ghstack-poisoned]

Update on "Update CMake minimum version to 3.10"

537391e

[ghstack-poisoned]

peterbell10 requested a review from malfet August 21, 2021 14:57

Update on "Update CMake minimum version to 3.10"

fd2c246

[ghstack-poisoned]

malfet approved these changes Aug 23, 2021

View reviewed changes

Update on "Update CMake minimum version to 3.10"

d903bea

Differential Revision: [](https://our.internmc.facebook.com/intern/diff/) [ghstack-poisoned]

facebook-github-bot closed this in 5ab356f Aug 25, 2021

facebook-github-bot added the Merged label Aug 25, 2021

jfix71 mentioned this pull request Aug 25, 2021

Use cmake-3.21 for PyTorch CI to unbreak pytorch/glow#5798

Closed

zhouzhuojie mentioned this pull request Aug 26, 2021

[Meta][WIP][Do-Not-Remove] HUD CI SEV Issues #63695

Closed

facebook-github-bot deleted the gh/peterbell10/121/head branch August 29, 2021 14:21

peterbell10 mentioned this pull request Apr 20, 2022

Eliminate uses of deprecated FindCUDA.cmake #76082

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update CMake minimum version to 3.10 #63660

Update CMake minimum version to 3.10 #63660

Uh oh!

peterbell10 commented Aug 20, 2021 •

edited by pytorch-probot bot

Loading

Uh oh!

facebook-github-bot commented Aug 20, 2021 •

edited

Loading

Uh oh!

malfet commented Aug 23, 2021

Uh oh!

malfet commented Aug 23, 2021

Uh oh!

ezyang commented Aug 24, 2021

Uh oh!

peterbell10 commented Aug 24, 2021 •

edited

Loading

Uh oh!

ezyang commented Aug 24, 2021

Uh oh!

malfet commented Aug 25, 2021

Uh oh!

zhouzhuojie commented Aug 25, 2021

Uh oh!

facebook-github-bot commented Aug 25, 2021

Uh oh!

suo commented Aug 25, 2021 •

edited

Loading

Uh oh!

peterbell10 commented Aug 25, 2021 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Update CMake minimum version to 3.10 #63660

Update CMake minimum version to 3.10 #63660

Uh oh!

Conversation

peterbell10 commented Aug 20, 2021 • edited by pytorch-probot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Aug 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

🕵️ 1 new failure recognized by patterns

docker-pytorch-linux-xenial-cuda11.3-cudnn8-py3-gcc7 (1/1)

Uh oh!

malfet commented Aug 23, 2021

Uh oh!

malfet commented Aug 23, 2021

Uh oh!

ezyang commented Aug 24, 2021

Uh oh!

peterbell10 commented Aug 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ezyang commented Aug 24, 2021

Uh oh!

malfet commented Aug 25, 2021

Uh oh!

zhouzhuojie commented Aug 25, 2021

Uh oh!

facebook-github-bot commented Aug 25, 2021

Uh oh!

suo commented Aug 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peterbell10 commented Aug 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

peterbell10 commented Aug 20, 2021 •

edited by pytorch-probot bot

Loading

facebook-github-bot commented Aug 20, 2021 •

edited

Loading

peterbell10 commented Aug 24, 2021 •

edited

Loading

suo commented Aug 25, 2021 •

edited

Loading

peterbell10 commented Aug 25, 2021 •

edited

Loading