KEMBAR78
pkg/boot/syslinux: fuzzing for syslinux configs by RiSKeD · Pull Request #2536 · u-root/u-root · GitHub
Skip to content

Conversation

@RiSKeD
Copy link
Contributor

@RiSKeD RiSKeD commented Oct 24, 2022

This PR follows the same concept as #2528 but for the parsing of syslinux config files.
The tests either check for panics when parsing the seeded or generated syslinux config by the fuzzing engine of golang.

@RiSKeD RiSKeD added the Awaiting reviewer Waiting for a reviewer. label Oct 24, 2022
Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com>
Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com>
@RiSKeD
Copy link
Contributor Author

RiSKeD commented Oct 26, 2022

Added a second commit, which fixes some issues in the parsing of syslinux files.
Afterwards i ran the fuzzing test for about 40 minutes for about 40 million different inputs without encountering anymore errors.

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 73.66% // Head: 73.86% // Increases project coverage by +0.20% 🎉

Coverage data is based on head (3ac21b4) compared to base (a893db1).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 3ac21b4 differs from pull request most recent head 3cc98e0. Consider uploading reports for the commit 3cc98e0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2536      +/-   ##
==========================================
+ Coverage   73.66%   73.86%   +0.20%     
==========================================
  Files         405      403       -2     
  Lines       41229    40979     -250     
==========================================
- Hits        30372    30271     -101     
+ Misses      10857    10708     -149     
Impacted Files Coverage Δ
pkg/boot/syslinux/syslinux.go 93.42% <100.00%> (+0.06%) ⬆️
pkg/cpio/archive.go 57.77% <0.00%> (-8.89%) ⬇️
pkg/boot/grub/entry.go 89.18% <0.00%> (-6.47%) ⬇️
pkg/cpio/utils.go 81.34% <0.00%> (-1.50%) ⬇️
pkg/boot/grub/grub.go 71.98% <0.00%> (-1.38%) ⬇️
pkg/cpio/newc.go 86.01% <0.00%> (-0.89%) ⬇️
cmds/boot/localboot/grub.go
cmds/boot/localboot/main.go
pkg/boot/fit/vfit.go 53.75% <0.00%> (+1.31%) ⬆️
pkg/boot/uefi/uefi.go 91.37% <0.00%> (+1.37%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com>
@rminnich rminnich added automerge Applying this label auto-merges the PR when ready Awaiting author Waiting for new changes or feedback for author. and removed Awaiting reviewer Waiting for a reviewer. labels Oct 29, 2022
@probot-auto-merge probot-auto-merge bot merged commit 132c3cd into u-root:main Oct 29, 2022
Navidem pushed a commit to google/oss-fuzz that referenced this pull request Nov 7, 2022
Following the addition of some fuzzing tests
([#1](u-root/u-root#2528),
[#2](u-root/u-root#2535),
[#3](u-root/u-root#2536)) in the u-root project
and [preparations for this
integration](u-root/u-root#2543).
You can check out its [website](https://u-root.org/) for more info on
the project.

Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com>

Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Applying this label auto-merges the PR when ready Awaiting author Waiting for new changes or feedback for author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants