KEMBAR78
oss-fuzz integration prep: add dictionaries & .options to improve fuz… by RiSKeD · Pull Request #2543 · u-root/u-root · GitHub
Skip to content

oss-fuzz integration prep: add dictionaries & .options to improve fuz… #2543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2022
Merged

oss-fuzz integration prep: add dictionaries & .options to improve fuz… #2543

merged 1 commit into from
Oct 31, 2022

Conversation

@RiSKeD
Copy link
Contributor

@RiSKeD RiSKeD commented Oct 31, 2022

This is the last PR before we can submit a PR to include u-root to the family of projects in the OSS-Fuzz project.

Changes:

  • Documentation on how OSS-Fuzz works, how it is different from native golang fuzzing, and how to run it locally for any fuzzing target.
  • Optional files used by libfuzzer to improve the fuzzing performance (see the doc or libfuzzer docs for more info).

Signed-off-by: Fabian Wienand fabian.wienand@9elements.com

@RiSKeD
oss-fuzz integration prep: add dictionaries & .options to improve fuz…
1196b60 
…zing with libfuzzer; include documentation

Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com>
@RiSKeD RiSKeD requested a review from rminnich October 31, 2022 14:45
@RiSKeD RiSKeD added the Awaiting reviewer Waiting for a reviewer. label Oct 31, 2022
@RiSKeD
Copy link
Contributor Author

RiSKeD commented Oct 31, 2022 •
edited
Loading

@rminnich Who would you suggest as the primary contact and additional contacts for the fuzzing in OSS-Fuzz?
These will get contacted on any upcoming failures during the nightly fuzzing runs and will also be able to access the OSS-Fuzz dashboard for the u-root project to check on coverage, failures, and statistics.
See OSS-Fuzz / Primary Contact for more info.

@codecov
Copy link

codecov bot commented Oct 31, 2022 •
edited
Loading

Codecov Report

Base: 73.66% // Head: 73.83% // Increases project coverage by +0.16% 🎉

Coverage data is based on head (1196b60) compared to base (132c3cd).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2543      +/-   ##
==========================================
+ Coverage   73.66%   73.83%   +0.16%     
==========================================
  Files         405      405              
  Lines       41231    41231              
==========================================
+ Hits        30374    30444      +70     
+ Misses      10857    10787      -70
Impacted Files Coverage Δ
cmds/core/mv/mv.go 79.54% <0.00%> (+2.27%) ⬆️
pkg/acpi/rsdp.go 51.28% <0.00%> (+10.25%) ⬆️
pkg/acpi/raw.go 89.28% <0.00%> (+14.28%) ⬆️
pkg/acpi/bios.go 83.78% <0.00%> (+83.78%) ⬆️
pkg/acpi/sdt.go 86.66% <0.00%> (+86.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

rminnich
rminnich approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@rminnich rminnich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very neat.

@rminnich rminnich added Awaiting author Waiting for new changes or feedback for author. and removed Awaiting reviewer Waiting for a reviewer. labels Oct 31, 2022
@RiSKeD RiSKeD added Awaiting reviewer Waiting for a reviewer. and removed Awaiting author Waiting for new changes or feedback for author. labels Oct 31, 2022
@RiSKeD RiSKeD merged commit 7e76d6f into u-root:main Oct 31, 2022
@RiSKeD RiSKeD deleted the oss-fuzz-opts branch October 31, 2022 17:19
@RiSKeD RiSKeD removed the Awaiting reviewer Waiting for a reviewer. label Nov 2, 2022
@RiSKeD RiSKeD mentioned this pull request Nov 2, 2022
Merged
Navidem pushed a commit to google/oss-fuzz that referenced this pull request Nov 7, 2022
@RiSKeD
u-root: init project (#8911)
d149cdd 
Following the addition of some fuzzing tests
([#1](u-root/u-root#2528),
[#2](u-root/u-root#2535),
[#3](u-root/u-root#2536)) in the u-root project
and [preparations for this
integration](u-root/u-root#2543).
You can check out its [website](https://u-root.org/) for more info on
the project.

Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com>

Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rminnich rminnich rminnich approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RiSKeD @rminnich