Modify maven_export to allow exporting zip archives #1368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables publishing zip files to maven. The project I'm converting over to bazel publishes C++ artifacts (JNI and others) as zip files to maven. Signed-off-by: Austin Schuh <austin.linux@gmail.com>
|
Build failure looks like a flake |
|
Apologies for getting to this so late. Is there any reason why you wouldn't use the java_export(
name = "example-export",
classifier_artifacts = {
"zip": ":create-zip-archive",
},
maven_coordinates = "com.example:bazel-example:0.0.1",
) |
|
Unfortunately, This creates: vs the required If there's another way to do this, I'm all ears. The simplest way I could find was to make a new rule. |
|
I'd be okay if you made it possible for the jar and javadoc artifacts to be optional. It seems like a smaller change than a new rule.... |
Signed-off-by: Austin Schuh <austin.linux@gmail.com>
|
I'm not sure it ends up cleaner, but here you go. |
AustinSchuh
changed the title
|
CI now passes. Looks like updating to the latest master made that work. What do you think? Any feedback? |
shs96c
approved these changes
Jun 24, 2025
shs96c
added a commit
to jin/rules_jvm_external
that referenced
this pull request
Jul 4, 2025
* master: (39 commits) Fix resolution of Android/AAR artifacts with Gradle resolver (bazel-contrib#1395) fail_if_repin_required is now True by default and minor improvement to failure message (bazel-contrib#1397) Housekeeping before we release 6.8 (bazel-contrib#1384) Add dll, dylib and so types to maven package mappings (bazel-contrib#1392) [bzlmod] Allow suppressing warning about multiple contributing modules. (bazel-contrib#1393) Use the artifact default values when adding them to a struct and add tests for coursier artifacts that have empty versions provided by BOMs and don't inlcude them in outdated (bazel-contrib#1390) Allow package exclusions and inclusions in javadocs (bazel-contrib#1293) Document well-known issues with `bzlmod` (bazel-contrib#1388) Begin documenting the gradle resolver (bazel-contrib#1389) Run gradle regression tests in CI (bazel-contrib#1385) Modify maven_export to allow exporting zip archives (bazel-contrib#1368) Allow root module's override tags to take precedence over the overridees from transitive deps. (bazel-contrib#1381) Ensure root module artifacts and boms take precedence with warnings (bazel-contrib#1373) Update maven-metadata.xml when publishing locally (bazel-contrib#1369) Add support for gradle resolver (bazel-contrib#1357) Prepare for 6.8 release (bazel-contrib#1380) Remove the Windows `kt_jvm_export` example (bazel-contrib#1383) Avoid spurious warnings about poorly formatted artifact coordinates (bazel-contrib#1374) Flip `fail_if_repin_required` to `True` by default (bazel-contrib#1371) Allow the same coordinate to be overridden in different repos (bazel-contrib#1378) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables publishing zip files to maven. The project I'm converting over to bazel publishes C++ artifacts (JNI and others) as zip files to maven.