KEMBAR78
Allow coursier artifacts to have empty versions provided by BOMs and don't inlcude them in outdated by cheister · Pull Request #1390 · bazel-contrib/rules_jvm_external · GitHub
Skip to content

Conversation

@cheister
Copy link
Collaborator

Fix the error

ERROR: rules_jvm_external/specs.bzl:259:65: An error occurred during the fetch of repository '_main~maven~unpinned_coursier_resolved_with_boms':
   Traceback (most recent call last):
	File "rules_jvm_external/private/rules/coursier.bzl", line 1072, column 38, in _coursier_fetch_impl
		dep_tree = make_coursier_dep_tree(
	File "rules_jvm_external/private/rules/coursier.bzl", line 844, column 48, in make_coursier_dep_tree
		coordinates = utils.artifact_coordinate(a)
	File "rules_jvm_external/specs.bzl", line 259, column 65, in _artifact_to_coord
		return artifact["group"] + ":" + artifact["artifact"] + ":" + artifact["version"] + classifier + type
Error: unsupported binary operation: string + NoneType

when using BOMs with coursier and not specifiying a version for an artifact.

Also don't check artifacts that get their versions from BOMs when running outdated

@cheister cheister requested review from jin and shs96c as code owners June 26, 2025 15:12
Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cheister cheister force-pushed the coursier-bom-test branch from a2dfc2a to f91d60a Compare June 27, 2025 04:19
…tests for coursier artifacts that have empty versions provided by BOMs and don't inlcude them in outdated
@cheister cheister force-pushed the coursier-bom-test branch from f91d60a to afbb8e9 Compare June 27, 2025 04:42
@cheister cheister merged commit 3089931 into bazel-contrib:master Jun 27, 2025
7 checks passed
shs96c added a commit to jin/rules_jvm_external that referenced this pull request Jul 4, 2025
* master: (39 commits)
  Fix resolution of Android/AAR artifacts with Gradle resolver (bazel-contrib#1395)
  fail_if_repin_required is now True by default and minor improvement to failure message (bazel-contrib#1397)
  Housekeeping before we release 6.8 (bazel-contrib#1384)
  Add dll, dylib and so types to maven package mappings (bazel-contrib#1392)
  [bzlmod] Allow suppressing warning about multiple contributing modules. (bazel-contrib#1393)
  Use the artifact default values when adding them to a struct and add tests for coursier artifacts that have empty versions provided by BOMs and don't inlcude them in outdated (bazel-contrib#1390)
  Allow package exclusions and inclusions in javadocs (bazel-contrib#1293)
  Document well-known issues with `bzlmod` (bazel-contrib#1388)
  Begin documenting the gradle resolver (bazel-contrib#1389)
  Run gradle regression tests in CI (bazel-contrib#1385)
  Modify maven_export to allow exporting zip archives (bazel-contrib#1368)
  Allow root module's override tags to take precedence over the overridees from transitive deps. (bazel-contrib#1381)
  Ensure root module artifacts and boms take precedence with warnings (bazel-contrib#1373)
  Update maven-metadata.xml when publishing locally (bazel-contrib#1369)
  Add support for gradle resolver (bazel-contrib#1357)
  Prepare for 6.8 release (bazel-contrib#1380)
  Remove the Windows `kt_jvm_export` example (bazel-contrib#1383)
  Avoid spurious warnings about poorly formatted artifact coordinates (bazel-contrib#1374)
  Flip `fail_if_repin_required` to `True` by default (bazel-contrib#1371)
  Allow the same coordinate to be overridden in different repos (bazel-contrib#1378)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants