KEMBAR78
Prepare for 6.8 release by sumeetgajjar · Pull Request #1380 · bazel-contrib/rules_jvm_external · GitHub
Skip to content

Conversation

@sumeetgajjar
Copy link
Contributor

@sumeetgajjar sumeetgajjar commented Jun 18, 2025

  • Pre-requisites for Release rules_jvm_external 6.8 #1379
  • Followed https://github.com/bazel-contrib/rules_jvm_external/blob/master/RELEASING.md
  • NB: The 7.2.15 rules_java release is available at the time of creating this PR. However, it's not updated here due to
    # Here goes the chain of rules compatibility resolution between RJE, java, android, cc and protobuf:
    #
    # rules_jvm_external wants to support LTS-2. For Bazel 8, this means supporting Bazel 6.
    #
    # rules_android is decoupled from Bazel 8, including its providers. ProguardSpecInfo is also decoupled, but to rules_java 7.12.2.
    #
    # So rules_java 7.12.2 is necessary for a decoupled rules_android to work with Bazel 6.
    #
    # But with workspace + rules_java 7.12.2, rules_java brings in a dep on
    # rules_cc's //cc package via //java/bazel/rules:rules (for CcInfo).
    # https://github.com/bazelbuild/rules_java/blob/2a9bd746974f6c94b159821d75130ad43e6b2970/java/bazel/rules/BUILD.bazel#L34-L35
    #
    # and rules_cc, in turn, brings in a dep on protobuf.
    #
    # And that's why we need the following deps:

@sumeetgajjar
Copy link
Contributor Author

sumeetgajjar commented Jun 18, 2025

The CI's failing for kt_jvm_export example, however, it's failing for quite some time now, so I'm assuming it's a non-issue.

Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really need to land #1373 in this release, and it's the cause of some nasty issues with users.

)
bazel_dep(
name = "bazel_features",
version = "1.17.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're deliberately leaving dependencies on low versions. The reason is because we don't want projects using rules_jvm_external to be forced to update their bazel_deps unless they want to. It seems counter-intuitive to leave our own deps lagging behind, but it's a conscious choice

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good - will revert to 1.17.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

repositories.bzl Outdated
strip_prefix = "bazel_features-1.17.0",
url = "https://github.com/bazel-contrib/bazel_features/releases/download/v1.17.0/bazel_features-v1.17.0.tar.gz",
sha256 = "07bd2b18764cdee1e0d6ff42c9c0a6111ffcbd0c17f0de38e7f44f1519d1c0cd",
strip_prefix = "bazel_features-1.32.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep this in sync with the module version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good - will revert to 1.17.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@shs96c
Copy link
Collaborator

shs96c commented Jun 19, 2025

Thank you for the PR! It's appreciated, and I understand why you want this release out ASAP

@sumeetgajjar sumeetgajjar requested a review from shs96c June 19, 2025 18:27
Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@shs96c shs96c merged commit 9557377 into bazel-contrib:master Jun 20, 2025
6 of 7 checks passed
shs96c added a commit to shs96c/rules_jvm_external that referenced this pull request Jun 23, 2025
* master:
  Update maven-metadata.xml when publishing locally (bazel-contrib#1369)
  Add support for gradle resolver (bazel-contrib#1357)
  Prepare for 6.8 release (bazel-contrib#1380)
shs96c added a commit to jin/rules_jvm_external that referenced this pull request Jul 4, 2025
* master: (39 commits)
  Fix resolution of Android/AAR artifacts with Gradle resolver (bazel-contrib#1395)
  fail_if_repin_required is now True by default and minor improvement to failure message (bazel-contrib#1397)
  Housekeeping before we release 6.8 (bazel-contrib#1384)
  Add dll, dylib and so types to maven package mappings (bazel-contrib#1392)
  [bzlmod] Allow suppressing warning about multiple contributing modules. (bazel-contrib#1393)
  Use the artifact default values when adding them to a struct and add tests for coursier artifacts that have empty versions provided by BOMs and don't inlcude them in outdated (bazel-contrib#1390)
  Allow package exclusions and inclusions in javadocs (bazel-contrib#1293)
  Document well-known issues with `bzlmod` (bazel-contrib#1388)
  Begin documenting the gradle resolver (bazel-contrib#1389)
  Run gradle regression tests in CI (bazel-contrib#1385)
  Modify maven_export to allow exporting zip archives (bazel-contrib#1368)
  Allow root module's override tags to take precedence over the overridees from transitive deps. (bazel-contrib#1381)
  Ensure root module artifacts and boms take precedence with warnings (bazel-contrib#1373)
  Update maven-metadata.xml when publishing locally (bazel-contrib#1369)
  Add support for gradle resolver (bazel-contrib#1357)
  Prepare for 6.8 release (bazel-contrib#1380)
  Remove the Windows `kt_jvm_export` example (bazel-contrib#1383)
  Avoid spurious warnings about poorly formatted artifact coordinates (bazel-contrib#1374)
  Flip `fail_if_repin_required` to `True` by default (bazel-contrib#1371)
  Allow the same coordinate to be overridden in different repos (bazel-contrib#1378)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants