ref: fill out TypeVars for ForeignKey #75228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #75228 +/- ##
==========================================
+ Coverage 78.02% 78.16% +0.13%
==========================================
Files 6765 6765
Lines 301819 301820 +1
Branches 51922 51922
==========================================
+ Hits 235506 235909 +403
+ Misses 59941 59557 -384
+ Partials 6372 6354 -18
|
this fixes a class of problem when upgrading to django-stubs 4.0.3
asottile-sentry
force-pushed
the
asottile-typevars-foreignkey
branch
from
507a913 to
abf8b8c
Compare
joshuarli
approved these changes
Jul 31, 2024
roaga
pushed a commit
that referenced
this pull request
Jul 31, 2024
this fixes a class of problem when upgrading to django-stubs 4.0.3 where `_ST` becomes unbound <!-- Describe your PR here. -->
asottile-sentry
added a commit
that referenced
this pull request
Jul 31, 2024
<!-- Describe your PR here. --> this had three sets of breakage addressed by other PRs: - our foreign key subclass was not functioning, django-stubs added a default TypeVar here which started getting filled in with an unbound TypeVar resulting in thousands of errors: fixed by #75228 - we were able to remove our fork's [descriptor patch](getsentry/sentry-forked-django-stubs#4) (which removed the non-model overload of `__get__` for fields) as mypy [fixed this issue](python/mypy#17381). in doing so it pointed out an unsafe descriptor access through a mixin and so that had to go: #75360 - django-stubs improved some field validation through QuerySets which was only checked through managers before: fixed by #75359
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes a class of problem when upgrading to django-stubs 5.0.4 where
_STbecomes unboundin order to fix this I first had to adjust the TypeVars in django-stubs itself:
fixing that mypy now followed foreign keys which resulted in a few new errors (~30) needing fixing in sentry:
fixing those left about ~5 errors that mypy was flagging code as "unreachable" but the foreign keys were marked
null=True-- this turned out to be another bug in django-stubs related to how our "FlexibleForeignKey" was defined:fixing that surfaced ~220 new errors in sentry which were fixed: