ref: fix type errors pointed out by django-stubs 5.0.4 #75359
Conversation
github-actions
bot
added
the
Scope: Backend
| has_integration: bool | None = None, | ||
| has_provider: bool | None = None, | ||
| status: ObjectStatus | None = None, | ||
| status: int | None = None, |
There was a problem hiding this comment.
despite looking like an enum ObjectStatus is just a namespace for ints
There was a problem hiding this comment.
It looks like this is the only caller which ever provides a value so this one looks good: https://github.com/getsentry/sentry/blob/master/src/sentry/plugins/providers/integration_repository.py#L97
There was a problem hiding this comment.
👍 The service definition is also int | None.
|
can someone from @getsentry/hybrid-cloud confirm that these schema changes make sense? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #75359 +/- ##
===========================================
+ Coverage 57.18% 78.22% +21.03%
===========================================
Files 6774 6784 +10
Lines 301932 302326 +394
Branches 51954 52022 +68
===========================================
+ Hits 172660 236487 +63827
+ Misses 124473 59470 -65003
- Partials 4799 6369 +1570
|
| uuids: list[str] | ||
| status: int | ||
| api_token_id: str | ||
| api_token_id: int |
There was a problem hiding this comment.
This looks good as well, it just gets used for filtering on https://github.com/getsentry/sentry/blob/master/src/sentry/models/integrations/sentry_app_installation.py#L128
| has_integration: bool | None = None, | ||
| has_provider: bool | None = None, | ||
| status: ObjectStatus | None = None, | ||
| status: int | None = None, |
There was a problem hiding this comment.
👍 The service definition is also int | None.
| uuids: list[str] | ||
| status: int | ||
| api_token_id: str | ||
| api_token_id: int |
There was a problem hiding this comment.
This should be fine too. We have coerce_numbers_to_str enabled in pydantic 2 which should cover any deploy time differences.
<!-- Describe your PR here. --> this had three sets of breakage addressed by other PRs: - our foreign key subclass was not functioning, django-stubs added a default TypeVar here which started getting filled in with an unbound TypeVar resulting in thousands of errors: fixed by #75228 - we were able to remove our fork's [descriptor patch](getsentry/sentry-forked-django-stubs#4) (which removed the non-model overload of `__get__` for fields) as mypy [fixed this issue](python/mypy#17381). in doing so it pointed out an unsafe descriptor access through a mixin and so that had to go: #75360 - django-stubs improved some field validation through QuerySets which was only checked through managers before: fixed by #75359
4 participants
Uh oh!
There was an error while loading. Please reload this page.