KEMBAR78
ref: remove OrganizationAbsoluteUrlMixin by asottile-sentry · Pull Request #75360 · getsentry/sentry · GitHub
Skip to content

Conversation

@asottile-sentry
Copy link
Contributor

blocker for upgrading to django-stubs 5.0.4

@asottile-sentry asottile-sentry requested review from a team July 31, 2024 18:32
@asottile-sentry asottile-sentry requested a review from a team as a code owner July 31, 2024 18:32
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 31, 2024
@asottile-sentry asottile-sentry merged commit 9ca135c into master Jul 31, 2024
@asottile-sentry asottile-sentry deleted the asottile-remove-organization-absolute-url-mixin branch July 31, 2024 19:05
asottile-sentry added a commit that referenced this pull request Jul 31, 2024
<!-- Describe your PR here. -->

this had three sets of breakage addressed by other PRs:

- our foreign key subclass was not functioning, django-stubs added a
default TypeVar here which started getting filled in with an unbound
TypeVar resulting in thousands of errors: fixed by
#75228
- we were able to remove our fork's [descriptor
patch](getsentry/sentry-forked-django-stubs#4)
(which removed the non-model overload of `__get__` for fields) as mypy
[fixed this issue](python/mypy#17381). in doing
so it pointed out an unsafe descriptor access through a mixin and so
that had to go: #75360
- django-stubs improved some field validation through QuerySets which
was only checked through managers before: fixed by
#75359
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants