[MPS][BE] Add dispatch_sync_with_rethrow
#108393
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And enable testing for match_output for complex types. Most of them should throw an "unsupported XYZ" error, rather than crash. This fixed several crashes when linalg ops were invoked with complex inputs [ghstack-poisoned]
pytorch-bot
bot
added
ciflow/mps
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108393
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit a0fad88 with merge base eafc058 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Sep 1, 2023
|
@albanD , @kulinseth can you guys please give it another glance? It mostly a no-op and adds a bit of testing for complex ops |
kit1980
approved these changes
Sep 9, 2023
kulinseth
approved these changes
Sep 9, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 10, 2023
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 10, 2023
Using existing BinaryKernel template Add `mul` as well as `kron` and `outer` to list of MPS ops that support complex types This should add all the missing ops mentioned in #105665 Pull Request resolved: #108395 Approved by: https://github.com/albanD ghstack dependencies: #108393, #108394
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
muloperation for complex types #108395add/sub#108394dispatch_sync_with_rethrow#108393And enable testing for match_output for complex types.
Most of them should throw an "unsupported XYZ" error, rather than crash.
This fixed several crashes when linalg ops were invoked with complex inputs.