-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[MPS] Implement mul operation for complex types
#108395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Using existing BinaryKernel template Add `mul` as well as `kron` and `outer` to list of MPS ops that support complex types This should add all the missing ops mentioned in #105665 [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108395
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 0629aba with merge base eafc058 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Using existing BinaryKernel template Add `mul` as well as `kron` and `outer` to list of MPS ops that support complex types This should add all the missing ops mentioned in #105665 [ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
With this PR, does this mean pytorch supports all complex operations on MPS devices? e.g. tensor multiplications, additions, and various linear algebra operations? |
|
Stack from ghstack (oldest at bottom):
muloperation for complex types #108395add/sub#108394dispatch_sync_with_rethrow#108393Using existing BinaryKernel template
Add
mulas well askronandouterto list of MPS ops that support complex typesThis should add all the missing ops mentioned in #105665