[MPS] Add complex add/sub
#108394
Closed
[MPS] Add complex add/sub
#108394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `view_as_real` and running elementwise ops in resulted tensors Add `add` and `sub` to list of complex ops that should work on MPS [ghstack-poisoned]
pytorch-bot
bot
added
ciflow/mps
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108394
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2a247b5 with merge base eafc058 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Sep 1, 2023
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 10, 2023
Using existing BinaryKernel template Add `mul` as well as `kron` and `outer` to list of MPS ops that support complex types This should add all the missing ops mentioned in #105665 Pull Request resolved: #108395 Approved by: https://github.com/albanD ghstack dependencies: #108393, #108394
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
muloperation for complex types #108395add/sub#108394dispatch_sync_with_rethrow#108393Using
view_as_realand running elementwise ops in resulted tensorsAdd
addandsubto list of complex ops that should work on MPS