KEMBAR78
use sym_or instead of any to avoid dde in calc_conv_nd_return_shape by laithsakka · Pull Request #162084 · pytorch/pytorch · GitHub
Skip to content

use sym_or instead of any to avoid dde in calc_conv_nd_return_shape #162084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

use sym_or instead of any to avoid dde in calc_conv_nd_return_shape #162084

wants to merge 3 commits into from

Conversation

@laithsakka
Copy link
Contributor

@laithsakka laithsakka commented Sep 3, 2025 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162084

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 465c89a with merge base a8d6943 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

laithsakka added a commit that referenced this pull request Sep 3, 2025
@laithsakka
use sym_or instead of any to avoid dde
3e5fbfb 
ghstack-source-id: 7596696
Pull Request resolved: #162084
@laithsakka laithsakka changed the title use sym_or instead of any to avoid dde use sym_or instead of any to avoid dde in calc_conv_nd_return_shape Sep 3, 2025
@laithsakka laithsakka added the topic: not user facing topic category label Sep 3, 2025
@laithsakka laithsakka mentioned this pull request Sep 3, 2025
Closed
aorenste
aorenste reviewed Sep 3, 2025
View reviewed changes
@laithsakka @aorenste
Update torch/_meta_registrations.py
6e489cd 
Co-authored-by: Aaron Orenstein <aorenste@fb.com>
@laithsakka
Copy link
Contributor Author

address suggestion.

@laithsakka laithsakka requested a review from aorenste September 3, 2025 21:55
@laithsakka
Update
465c89a 
[ghstack-poisoned]
@laithsakka
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 3, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@laithsakka laithsakka mentioned this pull request Sep 3, 2025
Closed
pytorchmergebot pushed a commit that referenced this pull request Sep 8, 2025
@laithsakka @pytorchmergebot
make should_swap more dde friendly (#162099)
85fe94e 
unblock customers for common cases with DDE ,until @pianpwk  land the change to should_swap #160473.

Pull Request resolved: #162099
Approved by: https://github.com/aorenste
ghstack dependencies: #162084
pytorchmergebot pushed a commit that referenced this pull request Sep 8, 2025
@laithsakka @pytorchmergebot
rewrite __maybe_broadcast should_expand check for unbacked (#162109)
2c538c9 
Pull Request resolved: #162109
Approved by: https://github.com/aorenste
ghstack dependencies: #162084, #162099
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@laithsakka @aorenste @markc-614
use sym_or instead of any to avoid dde in calc_conv_nd_return_shape (p…
8778d5c 
…ytorch#162084)

Pull Request resolved: pytorch#162084
Approved by: https://github.com/aorenste

Co-authored-by: Aaron Orenstein <aorenste@fb.com>
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@laithsakka @markc-614
make should_swap more dde friendly (pytorch#162099)
972506b 
unblock customers for common cases with DDE ,until @pianpwk  land the change to should_swap pytorch#160473.

Pull Request resolved: pytorch#162099
Approved by: https://github.com/aorenste
ghstack dependencies: pytorch#162084
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@laithsakka @markc-614
rewrite __maybe_broadcast should_expand check for unbacked (pytorch#1…
6369107 
…62109)

Pull Request resolved: pytorch#162109
Approved by: https://github.com/aorenste
ghstack dependencies: pytorch#162084, pytorch#162099
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@laithsakka @aorenste @mansiag05
use sym_or instead of any to avoid dde in calc_conv_nd_return_shape (p…
236b5a0 
…ytorch#162084)

Pull Request resolved: pytorch#162084
Approved by: https://github.com/aorenste

Co-authored-by: Aaron Orenstein <aorenste@fb.com>
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@laithsakka @mansiag05
make should_swap more dde friendly (pytorch#162099)
3a03589 
unblock customers for common cases with DDE ,until @pianpwk  land the change to should_swap pytorch#160473.

Pull Request resolved: pytorch#162099
Approved by: https://github.com/aorenste
ghstack dependencies: pytorch#162084
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@laithsakka @mansiag05
rewrite __maybe_broadcast should_expand check for unbacked (pytorch#1…
e943a9a 
…62109)

Pull Request resolved: pytorch#162109
Approved by: https://github.com/aorenste
ghstack dependencies: pytorch#162084, pytorch#162099
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@laithsakka @cleonard530
make should_swap more dde friendly (pytorch#162099)
ad89fd0 
unblock customers for common cases with DDE ,until @pianpwk  land the change to should_swap pytorch#160473.

Pull Request resolved: pytorch#162099
Approved by: https://github.com/aorenste
ghstack dependencies: pytorch#162084
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@laithsakka @cleonard530
rewrite __maybe_broadcast should_expand check for unbacked (pytorch#1…
f47fb62 
…62109)

Pull Request resolved: pytorch#162109
Approved by: https://github.com/aorenste
ghstack dependencies: pytorch#162084, pytorch#162099
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@laithsakka @aorenste @dsashidh
use sym_or instead of any to avoid dde in calc_conv_nd_return_shape (p…
00f1953 
…ytorch#162084)

Pull Request resolved: pytorch#162084
Approved by: https://github.com/aorenste

Co-authored-by: Aaron Orenstein <aorenste@fb.com>
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@laithsakka @dsashidh
make should_swap more dde friendly (pytorch#162099)
3170a6f 
unblock customers for common cases with DDE ,until @pianpwk  land the change to should_swap pytorch#160473.

Pull Request resolved: pytorch#162099
Approved by: https://github.com/aorenste
ghstack dependencies: pytorch#162084
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@laithsakka @dsashidh
rewrite __maybe_broadcast should_expand check for unbacked (pytorch#1…
775c6e2 
…62109)

Pull Request resolved: pytorch#162109
Approved by: https://github.com/aorenste
ghstack dependencies: pytorch#162084, pytorch#162099
@github-actions github-actions bot deleted the gh/laithsakka/265/head branch October 4, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aorenste aorenste aorenste approved these changes

@bobrenjc93 bobrenjc93 Awaiting requested review from bobrenjc93

@pianpwk pianpwk Awaiting requested review from pianpwk

@ezyang ezyang Awaiting requested review from ezyang

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@laithsakka @pytorchmergebot @aorenste