make should_swap more dde friendly #162099
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162099
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c00817f with merge base a8d6943 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
laithsakka
requested review from
ColinPeppler,
bobakfb,
bobrenjc93 and
pianpwk
aorenste
reviewed
Sep 3, 2025
This was referenced Sep 3, 2025
aorenste
approved these changes
Sep 5, 2025
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 2 jobs have failed, first few of them are: trunk / linux-jammy-cuda12.8-py3.10-gcc11 / test (default, 1, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu), trunk / linux-jammy-cuda12.8-py3.10-gcc11 / test (default, 4, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu) Details for Dev Infra teamRaised by workflow job |
|
Starting merge as part of PR stack under #162109 |
|
Starting merge as part of PR stack under #162109 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 8, 2025
Pull Request resolved: #162109 Approved by: https://github.com/aorenste ghstack dependencies: #162084, #162099
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
unblock customers for common cases with DDE ,until @pianpwk land the change to should_swap pytorch#160473. Pull Request resolved: pytorch#162099 Approved by: https://github.com/aorenste ghstack dependencies: pytorch#162084
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…62109) Pull Request resolved: pytorch#162109 Approved by: https://github.com/aorenste ghstack dependencies: pytorch#162084, pytorch#162099
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
unblock customers for common cases with DDE ,until @pianpwk land the change to should_swap pytorch#160473. Pull Request resolved: pytorch#162099 Approved by: https://github.com/aorenste ghstack dependencies: pytorch#162084
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
…62109) Pull Request resolved: pytorch#162109 Approved by: https://github.com/aorenste ghstack dependencies: pytorch#162084, pytorch#162099
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
unblock customers for common cases with DDE ,until @pianpwk land the change to should_swap pytorch#160473. Pull Request resolved: pytorch#162099 Approved by: https://github.com/aorenste ghstack dependencies: pytorch#162084
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
…62109) Pull Request resolved: pytorch#162109 Approved by: https://github.com/aorenste ghstack dependencies: pytorch#162084, pytorch#162099
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
unblock customers for common cases with DDE ,until @pianpwk land the change to should_swap pytorch#160473. Pull Request resolved: pytorch#162099 Approved by: https://github.com/aorenste ghstack dependencies: pytorch#162084
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
…62109) Pull Request resolved: pytorch#162109 Approved by: https://github.com/aorenste ghstack dependencies: pytorch#162084, pytorch#162099
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
unblock customers for common cases with DDE ,until @pianpwk land the change to should_swap #160473.