Add query and synchronize to c10::Stream #59560
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`at::cuda::CUDAStream` has the `query` and `synchronize` methods, but `c10::Stream` does not, and I couldn't find any generic way to accomplish this. Hence I added helpers to do this to the DeviceGuardImpl interface, and then defined these methods on `c10::Stream`. (I had to do it out-of-line to circumvent a circular dependency). Differential Revision: [D28931377](https://our.internmc.facebook.com/intern/diff/D28931377/) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit a033ec2 (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
 pytorch_doc_test |
Doc test | 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group.
This was referenced Jun 7, 2021
`at::cuda::CUDAStream` has the `query` and `synchronize` methods, but `c10::Stream` does not, and I couldn't find any generic way to accomplish this. Hence I added helpers to do this to the DeviceGuardImpl interface, and then defined these methods on `c10::Stream`. (I had to do it out-of-line to circumvent a circular dependency). Differential Revision: [D28931377](https://our.internmc.facebook.com/intern/diff/D28931377/) [ghstack-poisoned]
`at::cuda::CUDAStream` has the `query` and `synchronize` methods, but `c10::Stream` does not, and I couldn't find any generic way to accomplish this. Hence I added helpers to do this to the DeviceGuardImpl interface, and then defined these methods on `c10::Stream`. (I had to do it out-of-line to circumvent a circular dependency). Differential Revision: [D28931377](https://our.internmc.facebook.com/intern/diff/D28931377/) [ghstack-poisoned]
`at::cuda::CUDAStream` has the `query` and `synchronize` methods, but `c10::Stream` does not, and I couldn't find any generic way to accomplish this. Hence I added helpers to do this to the DeviceGuardImpl interface, and then defined these methods on `c10::Stream`. (I had to do it out-of-line to circumvent a circular dependency). Differential Revision: [D28931377](https://our.internmc.facebook.com/intern/diff/D28931377/) [ghstack-poisoned]
`at::cuda::CUDAStream` has the `query` and `synchronize` methods, but `c10::Stream` does not, and I couldn't find any generic way to accomplish this. Hence I added helpers to do this to the DeviceGuardImpl interface, and then defined these methods on `c10::Stream`. (I had to do it out-of-line to circumvent a circular dependency). Differential Revision: [D28931377](https://our.internmc.facebook.com/intern/diff/D28931377/) [ghstack-poisoned]
`at::cuda::CUDAStream` has the `query` and `synchronize` methods, but `c10::Stream` does not, and I couldn't find any generic way to accomplish this. Hence I added helpers to do this to the DeviceGuardImpl interface, and then defined these methods on `c10::Stream`. (I had to do it out-of-line to circumvent a circular dependency). Differential Revision: [D28931377](https://our.internmc.facebook.com/intern/diff/D28931377/) [ghstack-poisoned]
`at::cuda::CUDAStream` has the `query` and `synchronize` methods, but `c10::Stream` does not, and I couldn't find any generic way to accomplish this. Hence I added helpers to do this to the DeviceGuardImpl interface, and then defined these methods on `c10::Stream`. (I had to do it out-of-line to circumvent a circular dependency). Differential Revision: [D28931377](https://our.internmc.facebook.com/intern/diff/D28931377/) [ghstack-poisoned]
`at::cuda::CUDAStream` has the `query` and `synchronize` methods, but `c10::Stream` does not, and I couldn't find any generic way to accomplish this. Hence I added helpers to do this to the DeviceGuardImpl interface, and then defined these methods on `c10::Stream`. (I had to do it out-of-line to circumvent a circular dependency). Differential Revision: [D28931377](https://our.internmc.facebook.com/intern/diff/D28931377/) [ghstack-poisoned]
`at::cuda::CUDAStream` has the `query` and `synchronize` methods, but `c10::Stream` does not, and I couldn't find any generic way to accomplish this. Hence I added helpers to do this to the DeviceGuardImpl interface, and then defined these methods on `c10::Stream`. (I had to do it out-of-line to circumvent a circular dependency). Differential Revision: [D28931377](https://our.internmc.facebook.com/intern/diff/D28931377/) [ghstack-poisoned]
`at::cuda::CUDAStream` has the `query` and `synchronize` methods, but `c10::Stream` does not, and I couldn't find any generic way to accomplish this. Hence I added helpers to do this to the DeviceGuardImpl interface, and then defined these methods on `c10::Stream`. (I had to do it out-of-line to circumvent a circular dependency). Differential Revision: [D28931377](https://our.internmc.facebook.com/intern/diff/D28931377/) [ghstack-poisoned]
ezyang
reviewed
Jun 8, 2021
c10/cuda/CUDAStream.h
Outdated
| } | ||
|
|
||
| return false; | ||
| return stream_.query(); |
There was a problem hiding this comment.
This is backwards: the true implementation should live here, and the DeviceGuard impl should construct a CUDAStream and call into this implementation. This way, users of CUDAStream bypass dynamic dispatch on the virtual method.
There was a problem hiding this comment.
Makes sense, and it leaves CUDAStream untouched, which is reassuring. It also fixes a weird HIP issue later in the stack, so that's neat too.
|
Seems reasonable enough to me. |
`at::cuda::CUDAStream` has the `query` and `synchronize` methods, but `c10::Stream` does not, and I couldn't find any generic way to accomplish this. Hence I added helpers to do this to the DeviceGuardImpl interface, and then defined these methods on `c10::Stream`. (I had to do it out-of-line to circumvent a circular dependency). Differential Revision: [D28931377](https://our.internmc.facebook.com/intern/diff/D28931377/) [ghstack-poisoned]
This was referenced Jun 9, 2021
`at::cuda::CUDAStream` has the `query` and `synchronize` methods, but `c10::Stream` does not, and I couldn't find any generic way to accomplish this. Hence I added helpers to do this to the DeviceGuardImpl interface, and then defined these methods on `c10::Stream`. (I had to do it out-of-line to circumvent a circular dependency). Differential Revision: [D28931377](https://our.internmc.facebook.com/intern/diff/D28931377/) [ghstack-poisoned]
|
This pull request has been merged in e7cccc2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
at::cuda::CUDAStreamhas thequeryandsynchronizemethods, butc10::Streamdoes not, and I couldn't find any generic way to accomplish this. Hence I added helpers to do this to the DeviceGuardImpl interface, and then defined these methods onc10::Stream. (I had to do it out-of-line to circumvent a circular dependency).Differential Revision: D28931377