-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[ci] add 3.13 inductor unittests to CI #140733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140733
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3d36725 with merge base 16676fd ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
| linux-focal-cuda12_1-py3_13-gcc9-inductor-build: | ||
| name: cuda12.1-py3.13-gcc9-sm86 | ||
| uses: ./.github/workflows/_linux-build.yml | ||
| needs: get-label-type | ||
| with: | ||
| build-environment: linux-focal-cuda12.1-py3.13-gcc9-sm86 | ||
| docker-image-name: pytorch-linux-focal-cuda12.1-cudnn9-py3.13-gcc9-inductor-benchmarks | ||
| cuda-arch-list: '8.6' | ||
| runner_prefix: "${{ needs.get-label-type.outputs.label-type }}" | ||
| test-matrix: | | ||
| { include: [ | ||
| { config: "inductor", shard: 1, num_shards: 2, runner: "linux.g5.4xlarge.nvidia.gpu" }, | ||
| { config: "inductor", shard: 2, num_shards: 2, runner: "linux.g5.4xlarge.nvidia.gpu" }, | ||
| ]} | ||
| secrets: inherit | ||
|
|
||
| linux-focal-cuda12_1-py3_13-gcc9-inductor-test: | ||
| name: cuda12.1-py3.13-gcc9-sm86 | ||
| uses: ./.github/workflows/_linux-test.yml | ||
| needs: linux-focal-cuda12_1-py3_13-gcc9-inductor-build | ||
| with: | ||
| build-environment: linux-focal-cuda12.1-py3.13-gcc9-sm86 | ||
| docker-image: ${{ needs.linux-focal-cuda12_1-py3_13-gcc9-inductor-build.outputs.docker-image }} | ||
| test-matrix: ${{ needs.linux-focal-cuda12_1-py3_13-gcc9-inductor-build.outputs.test-matrix }} | ||
| secrets: inherit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not add any cuda12_1 tests now, why 12.4 is not sufficient? (or why not use 12.6?)
[ghstack-poisoned]
[ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Pull Request resolved: pytorch#140733 Approved by: https://github.com/malfet, https://github.com/atalman ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533
…torch#141859) Pull Request resolved: pytorch#141859 Approved by: https://github.com/StrongerXi, https://github.com/atalman ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733
…h#141860) Pull Request resolved: pytorch#141860 Approved by: https://github.com/StrongerXi, https://github.com/atalman ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859
…1886) Pull Request resolved: pytorch#141886 Approved by: https://github.com/PaliC ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860
…41887) Pull Request resolved: pytorch#141887 Approved by: https://github.com/StrongerXi, https://github.com/atalman ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886
…141950) Pull Request resolved: pytorch#141950 Approved by: https://github.com/StrongerXi, https://github.com/atalman ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887
…141951) Pull Request resolved: pytorch#141951 Approved by: https://github.com/sraikund16, https://github.com/atalman ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887, pytorch#141950
Pull Request resolved: pytorch#141264 Approved by: https://github.com/StrongerXi, https://github.com/atalman ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887, pytorch#141950, pytorch#141951
Pull Request resolved: pytorch#140733 Approved by: https://github.com/malfet, https://github.com/atalman ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533
…1886) Pull Request resolved: pytorch#141886 Approved by: https://github.com/PaliC ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860
…41887) Pull Request resolved: pytorch#141887 Approved by: https://github.com/StrongerXi, https://github.com/atalman ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886
…141950) Pull Request resolved: pytorch#141950 Approved by: https://github.com/StrongerXi, https://github.com/atalman ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887
CUDA 12.4 is the default now. This frees up some resources. This also fixes newly added Python 3.13 job by #140733. That PR missed adding the new Docker image `pytorch-linux-focal-cuda12.4-cudnn9-py3.13-gcc9-inductor-benchmarks` into docker build workflow. Pull Request resolved: #142177 Approved by: https://github.com/atalman
Stack from ghstack (oldest at bottom):