KEMBAR78
[ci] add 3.13 inductor unittests to CI by williamwen42 · Pull Request #140733 · pytorch/pytorch · GitHub
Skip to content

Conversation

williamwen42
Copy link
Member

@williamwen42 williamwen42 commented Nov 14, 2024

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 14, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140733

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3d36725 with merge base 16676fd (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

williamwen42 added a commit that referenced this pull request Nov 14, 2024
ghstack-source-id: d94921d
Pull Request resolved: #140733
@williamwen42 williamwen42 added ciflow/inductor keep-going Don't stop on first failure, keep running tests until the end labels Nov 15, 2024
williamwen42 added a commit that referenced this pull request Nov 15, 2024
ghstack-source-id: 8bc7b3d
Pull Request resolved: #140733
williamwen42 added a commit that referenced this pull request Nov 19, 2024
ghstack-source-id: 92c5417
Pull Request resolved: #140733
williamwen42 added a commit that referenced this pull request Nov 19, 2024
ghstack-source-id: dd04c93
Pull Request resolved: #140733
williamwen42 added a commit that referenced this pull request Nov 20, 2024
ghstack-source-id: 315d4ad
Pull Request resolved: #140733
Comment on lines 155 to 179
linux-focal-cuda12_1-py3_13-gcc9-inductor-build:
name: cuda12.1-py3.13-gcc9-sm86
uses: ./.github/workflows/_linux-build.yml
needs: get-label-type
with:
build-environment: linux-focal-cuda12.1-py3.13-gcc9-sm86
docker-image-name: pytorch-linux-focal-cuda12.1-cudnn9-py3.13-gcc9-inductor-benchmarks
cuda-arch-list: '8.6'
runner_prefix: "${{ needs.get-label-type.outputs.label-type }}"
test-matrix: |
{ include: [
{ config: "inductor", shard: 1, num_shards: 2, runner: "linux.g5.4xlarge.nvidia.gpu" },
{ config: "inductor", shard: 2, num_shards: 2, runner: "linux.g5.4xlarge.nvidia.gpu" },
]}
secrets: inherit

linux-focal-cuda12_1-py3_13-gcc9-inductor-test:
name: cuda12.1-py3.13-gcc9-sm86
uses: ./.github/workflows/_linux-test.yml
needs: linux-focal-cuda12_1-py3_13-gcc9-inductor-build
with:
build-environment: linux-focal-cuda12.1-py3.13-gcc9-sm86
docker-image: ${{ needs.linux-focal-cuda12_1-py3_13-gcc9-inductor-build.outputs.docker-image }}
test-matrix: ${{ needs.linux-focal-cuda12_1-py3_13-gcc9-inductor-build.outputs.test-matrix }}
secrets: inherit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not add any cuda12_1 tests now, why 12.4 is not sufficient? (or why not use 12.6?)

Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@williamwen42 williamwen42 added the module: python version Issues related to specific Python versions label Dec 6, 2024
pytorchmergebot pushed a commit that referenced this pull request Dec 9, 2024
CUDA 12.4 is the default now.  This frees up some resources.  This also fixes newly added Python 3.13 job by #140733. That PR missed adding the new Docker image `pytorch-linux-focal-cuda12.4-cudnn9-py3.13-gcc9-inductor-benchmarks` into docker build workflow.
Pull Request resolved: #142177
Approved by: https://github.com/atalman
@atalman atalman mentioned this pull request Dec 12, 2024
37 tasks
@github-actions github-actions bot deleted the gh/williamwen42/165/head branch January 6, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor keep-going Don't stop on first failure, keep running tests until the end Merged module: python version Issues related to specific Python versions topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants