KEMBAR78
[CI, 3.13] enable dynamo_wrapped unittests in 3.13 by williamwen42 · Pull Request #141264 · pytorch/pytorch · GitHub
Skip to content

[CI, 3.13] enable dynamo_wrapped unittests in 3.13 #141264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 23 commits into from
Closed

[CI, 3.13] enable dynamo_wrapped unittests in 3.13 #141264

wants to merge 23 commits into from

Conversation

williamwen42
Copy link
Member

@williamwen42 williamwen42 commented Nov 21, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

@williamwen42 williamwen42 requested a review from a team as a code owner November 21, 2024 19:03
This was referenced Nov 21, 2024
Closed
Closed
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 21, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 21, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141264

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit aef86d4 with merge base 16676fd (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@williamwen42 williamwen42 added the keep-going Don't stop on first failure, keep running tests until the end label Nov 21, 2024
@williamwen42 williamwen42 mentioned this pull request Nov 23, 2024
Closed
williamwen42 added a commit that referenced this pull request Nov 23, 2024
@williamwen42
[CI, 3.13] enable dynamo_wrapped unittests in 3.13
14cea34 
ghstack-source-id: dded178
Pull Request resolved: #141264
@williamwen42 williamwen42 mentioned this pull request Nov 26, 2024
Closed
@williamwen42 williamwen42 mentioned this pull request Nov 26, 2024
Closed
@williamwen42 williamwen42 mentioned this pull request Nov 26, 2024
Closed
@williamwen42 williamwen42 mentioned this pull request Nov 26, 2024
Closed
@williamwen42 williamwen42 mentioned this pull request Nov 26, 2024
Closed
williamwen42 added a commit that referenced this pull request Nov 26, 2024
@williamwen42
[CI, 3.13] enable dynamo_wrapped unittests in 3.13
1b278ca 
ghstack-source-id: 6afedd3
Pull Request resolved: #141264
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 4, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approvers from one of the following sets are needed:

  • OSS CI (alband, dagitses, pytorch/pytorch-dev-infra)
  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10, ...)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet, ...)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@StrongerXi
Copy link
Contributor

Looks like I'm too noob for reviewer lol

@williamwen42
Copy link
Member Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approvers from one of the following sets are needed:

  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10, ...)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet, ...)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@atalman
Copy link
Contributor

atalman commented Dec 5, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[CI, 3.13] enable dynamo_wrapped unittests in 3.13 (pytorch#141264)
33f35d6 
Pull Request resolved: pytorch#141264
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887, pytorch#141950, pytorch#141951
@williamwen42 williamwen42 added the module: python version Issues related to specific Python versions label Dec 6, 2024
pytorch-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[CI, 3.13] enable dynamo_wrapped unittests in 3.13 (#141264)
8eff273 
Pull Request resolved: #141264
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: #141409, #142003, #141572, #141577, #141605, #141621, #141623, #141673, #141674, #141858, #141862, #139533, #140733, #141859, #141860, #141886, #141887, #141950, #141951
This was referenced Dec 12, 2024
Closed
Closed
pytorchmergebot pushed a commit that referenced this pull request Dec 13, 2024
@atalman @pytorchmergebot
Linux Wheels: Remove triton dependency python < 3.13 constraint (#143162
04bb82f 
)

We do build pytorch-triton package for python 3.13 : https://github.com/pytorch/pytorch/actions/runs/12304476674/job/34344764271
Hence constraint is no longer needed.
This stack enabled torch.compile for Python 3.13 : #141264
Pull Request resolved: #143162
Approved by: https://github.com/kit1980
pytorchbot pushed a commit that referenced this pull request Dec 13, 2024
@atalman @pytorchbot
Linux Wheels: Remove triton dependency python < 3.13 constraint (#143162
f2cf12a 
)

We do build pytorch-triton package for python 3.13 : https://github.com/pytorch/pytorch/actions/runs/12304476674/job/34344764271
Hence constraint is no longer needed.
This stack enabled torch.compile for Python 3.13 : #141264
Pull Request resolved: #143162
Approved by: https://github.com/kit1980

(cherry picked from commit 04bb82f)
@pytorchbot pytorchbot mentioned this pull request Dec 13, 2024
Merged
malfet pushed a commit that referenced this pull request Dec 13, 2024
@pytorchbot @atalman
Linux Wheels: Remove triton dependency python < 3.13 constraint (#143199
5fbc4aa 
)

Linux Wheels: Remove triton dependency python < 3.13 constraint (#143162)

We do build pytorch-triton package for python 3.13 : https://github.com/pytorch/pytorch/actions/runs/12304476674/job/34344764271
Hence constraint is no longer needed.
This stack enabled torch.compile for Python 3.13 : #141264
Pull Request resolved: #143162
Approved by: https://github.com/kit1980

(cherry picked from commit 04bb82f)

Co-authored-by: Andrey Talman <atalman@fb.com>
@github-actions github-actions bot deleted the gh/williamwen42/166/head branch January 6, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atalman atalman atalman approved these changes

@StrongerXi StrongerXi StrongerXi approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request keep-going Don't stop on first failure, keep running tests until the end Merged module: python version Issues related to specific Python versions topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@williamwen42 @pytorchmergebot @StrongerXi @atalman