KEMBAR78
[ci, 3.13] disable segfaulting profiler tests in 3.13 by williamwen42 · Pull Request #141674 · pytorch/pytorch · GitHub
Skip to content

[ci, 3.13] disable segfaulting profiler tests in 3.13 #141674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

[ci, 3.13] disable segfaulting profiler tests in 3.13 #141674

wants to merge 9 commits into from

Conversation

williamwen42
Copy link
Member

@williamwen42 williamwen42 commented Nov 27, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

@williamwen42 williamwen42 mentioned this pull request Nov 27, 2024
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 27, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141674

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 82953fc with merge base 16676fd (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@williamwen42 williamwen42 mentioned this pull request Nov 27, 2024
Closed
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 27, 2024
This was referenced Nov 27, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@williamwen42
Copy link
Member Author

cc @sraikund16 - can you find someone to investigate this?

@williamwen42 williamwen42 changed the title [ci, 3.13] disable segfaulting memory profiler tests in 3.13 [ci, 3.13] disable segfaulting profiler tests in 3.13 Dec 2, 2024
This was referenced Dec 2, 2024
Closed
Closed
This was referenced Dec 2, 2024
Closed
Closed
Closed
Closed
@williamwen42 williamwen42 mentioned this pull request Dec 3, 2024
Closed
@williamwen42 williamwen42 mentioned this pull request Dec 3, 2024
Closed
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[ci, 3.13] skip dynamo-xpass'd numpy tests in numpy >= 2.0 (pytorch#1…
2fcc39c 
…41862)

Pull Request resolved: pytorch#141862
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[CI, 3.13] enable 3.13 CI (pytorch#139533)
ce3e09c 
Pull Request resolved: pytorch#139533
Approved by: https://github.com/atalman, https://github.com/malfet
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[ci] add 3.13 inductor unittests to CI (pytorch#140733)
3626125 
Pull Request resolved: pytorch#140733
Approved by: https://github.com/malfet, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[dynamo, 3.13] add JUMP_BACKWARD_NO_INTERRUPT to terminal opcodes (py…
21cf16d 
…torch#141859)

Pull Request resolved: pytorch#141859
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[dynamo, 3.13] disable 3.13.0 warning in dynamo-wrapped tests (pytorc…
bc6077b 
…h#141860)

Pull Request resolved: pytorch#141860
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[ci, 3.13] skip failing torch.package dynamo-wrapped test (pytorch#14…
82e76d0 
…1886)

Pull Request resolved: pytorch#141886
Approved by: https://github.com/PaliC
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[ci, 3.13] skip failing module tracker dynamo-wrapped test (pytorch#1…
3f7c8ae 
…41887)

Pull Request resolved: pytorch#141887
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[ci, 3.13] fix/skip failing numpy 2.0+ dynamo-wrapped tests (pytorch#…
ca4c72e 
…141950)

Pull Request resolved: pytorch#141950
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[ci, 3.13] disable segfaulting dynamo-wrapped profiler test (pytorch#…
6ecd615 
…141951)

Pull Request resolved: pytorch#141951
Approved by: https://github.com/sraikund16, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887, pytorch#141950
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[CI, 3.13] enable dynamo_wrapped unittests in 3.13 (pytorch#141264)
33f35d6 
Pull Request resolved: pytorch#141264
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887, pytorch#141950, pytorch#141951
@williamwen42 williamwen42 mentioned this pull request Dec 5, 2024
Closed
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci, 3.13] disable segfaulting profiler tests in 3.13 (pytorch#141674)
79e68f9 
Pull Request resolved: pytorch#141674
Approved by: https://github.com/sraikund16, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[dynamo, 3.13] support CONVERT_VALUE (pytorch#141858)
b5ac556 
Pull Request resolved: pytorch#141858
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674
pytorch-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci, 3.13] skip dynamo-xpass'd numpy tests in numpy >= 2.0 (#141862)
4d2a3bc 
Pull Request resolved: #141862
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: #141409, #142003, #141572, #141577, #141605, #141621, #141623, #141673, #141674, #141858
pytorch-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[CI, 3.13] enable 3.13 CI (#139533)
776adcc 
Pull Request resolved: #139533
Approved by: https://github.com/atalman, https://github.com/malfet
ghstack dependencies: #141409, #142003, #141572, #141577, #141605, #141621, #141623, #141673, #141674, #141858, #141862
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci] add 3.13 inductor unittests to CI (pytorch#140733)
602e75a 
Pull Request resolved: pytorch#140733
Approved by: https://github.com/malfet, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533
pytorch-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[dynamo, 3.13] add JUMP_BACKWARD_NO_INTERRUPT to terminal opcodes (#1…
0bf73c9 
…41859)

Pull Request resolved: #141859
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: #141409, #142003, #141572, #141577, #141605, #141621, #141623, #141673, #141674, #141858, #141862, #139533, #140733
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[dynamo, 3.13] disable 3.13.0 warning in dynamo-wrapped tests (pytorc…
c1d0289 
…h#141860)

Pull Request resolved: pytorch#141860
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859
pytorch-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci, 3.13] skip failing torch.package dynamo-wrapped test (#141886)
86966d9 
Pull Request resolved: #141886
Approved by: https://github.com/PaliC
ghstack dependencies: #141409, #142003, #141572, #141577, #141605, #141621, #141623, #141673, #141674, #141858, #141862, #139533, #140733, #141859, #141860
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci, 3.13] skip failing module tracker dynamo-wrapped test (pytorch#1…
980eda7 
…41887)

Pull Request resolved: pytorch#141887
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886
pytorch-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci, 3.13] fix/skip failing numpy 2.0+ dynamo-wrapped tests (#141950)
ea06bac 
Pull Request resolved: #141950
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: #141409, #142003, #141572, #141577, #141605, #141621, #141623, #141673, #141674, #141858, #141862, #139533, #140733, #141859, #141860, #141886, #141887
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci, 3.13] disable segfaulting dynamo-wrapped profiler test (pytorch#…
ba7e1dc 
…141951)

Pull Request resolved: pytorch#141951
Approved by: https://github.com/sraikund16, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887, pytorch#141950
pytorch-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[CI, 3.13] enable dynamo_wrapped unittests in 3.13 (#141264)
8eff273 
Pull Request resolved: #141264
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: #141409, #142003, #141572, #141577, #141605, #141621, #141623, #141673, #141674, #141858, #141862, #139533, #140733, #141859, #141860, #141886, #141887, #141950, #141951
@atalman atalman mentioned this pull request Dec 12, 2024
Closed
37 tasks
@github-actions github-actions bot deleted the gh/williamwen42/176/head branch January 4, 2025 02:05
@malfet malfet mentioned this pull request May 19, 2025
Closed
pytorchmergebot pushed a commit that referenced this pull request May 19, 2025
@malfet @pytorchmergebot
Fix profiler on cpython-3.13 (#153848)
c0343b1 
Per [PEP 667](https://peps.python.org/pep-0667/) `PyFrame_GetLocals` no longer returns dict, but rather instance of `PyFrameLocalsProxy_Type`, so calling `PyDict_GetItemString` is no longer valid(it will always return None) and must be replaced with `PyMapping_GetItemString`

Tested by partially reverting #141674 full revert will be done in the followup PR

Fixes #148273
Pull Request resolved: #153848
Approved by: https://github.com/Skylion007
pytorchbot pushed a commit that referenced this pull request May 21, 2025
@malfet @pytorchbot
Fix profiler on cpython-3.13 (#153848)
19b80ad 
Per [PEP 667](https://peps.python.org/pep-0667/) `PyFrame_GetLocals` no longer returns dict, but rather instance of `PyFrameLocalsProxy_Type`, so calling `PyDict_GetItemString` is no longer valid(it will always return None) and must be replaced with `PyMapping_GetItemString`

Tested by partially reverting #141674 full revert will be done in the followup PR

Fixes #148273
Pull Request resolved: #153848
Approved by: https://github.com/Skylion007

(cherry picked from commit c0343b1)
@pytorchbot pytorchbot mentioned this pull request May 21, 2025
Merged
atalman pushed a commit that referenced this pull request May 21, 2025
@pytorchbot @malfet
Fix profiler on cpython-3.13 (#154037)
bdec157 
Fix profiler on cpython-3.13 (#153848)

Per [PEP 667](https://peps.python.org/pep-0667/) `PyFrame_GetLocals` no longer returns dict, but rather instance of `PyFrameLocalsProxy_Type`, so calling `PyDict_GetItemString` is no longer valid(it will always return None) and must be replaced with `PyMapping_GetItemString`

Tested by partially reverting #141674 full revert will be done in the followup PR

Fixes #148273
Pull Request resolved: #153848
Approved by: https://github.com/Skylion007

(cherry picked from commit c0343b1)

Co-authored-by: Nikita Shulga <nshulga@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atalman atalman atalman approved these changes

@sraikund16 sraikund16 sraikund16 approved these changes

Assignees

No one assigned

Labels

Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@williamwen42 @atalman @sraikund16 @pytorchmergebot