KEMBAR78
[ci, 3.13] fix/skip failing numpy 2.0+ dynamo-wrapped tests by williamwen42 · Pull Request #141950 · pytorch/pytorch · GitHub
Skip to content

[ci, 3.13] fix/skip failing numpy 2.0+ dynamo-wrapped tests #141950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[ci, 3.13] fix/skip failing numpy 2.0+ dynamo-wrapped tests #141950

wants to merge 3 commits into from

Conversation

@williamwen42
Copy link
Member

@williamwen42 williamwen42 commented Dec 3, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 3, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141950

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 649b3b9 with merge base 16676fd (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 3, 2024
This was referenced Dec 2, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@williamwen42 williamwen42 mentioned this pull request Dec 3, 2024
Closed
StrongerXi
StrongerXi approved these changes Dec 4, 2024
View reviewed changes
test/torch_np/numpy_tests/core/test_shape_base.py
Comment on lines +36 to +39
if int(numpy.__version__[0]) >= 2:
from numpy.exceptions import AxisError
else:
from numpy import AxisError
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought PT is already compatible with numpy 2, or am I imagining things?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The support might not be fully completed. Our test coverage also wasn't there since we didn't test numpy 2.0+ until 3.13.

pytorchmergebot pushed a commit that referenced this pull request Dec 5, 2024
@williamwen42 @pytorchmergebot
[ci, 3.13] disable segfaulting dynamo-wrapped profiler test (#141951)
797a347 
Pull Request resolved: #141951
Approved by: https://github.com/sraikund16, https://github.com/atalman
ghstack dependencies: #141409, #142003, #141572, #141577, #141605, #141621, #141623, #141673, #141674, #141858, #141862, #139533, #140733, #141859, #141860, #141886, #141887, #141950
pytorchmergebot pushed a commit that referenced this pull request Dec 5, 2024
@williamwen42 @pytorchmergebot
[CI, 3.13] enable dynamo_wrapped unittests in 3.13 (#141264)
25d9fa8 
Pull Request resolved: #141264
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: #141409, #142003, #141572, #141577, #141605, #141621, #141623, #141673, #141674, #141858, #141862, #139533, #140733, #141859, #141860, #141886, #141887, #141950, #141951
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[ci, 3.13] fix/skip failing numpy 2.0+ dynamo-wrapped tests (pytorch#…
ca4c72e 
…141950)

Pull Request resolved: pytorch#141950
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[ci, 3.13] disable segfaulting dynamo-wrapped profiler test (pytorch#…
6ecd615 
…141951)

Pull Request resolved: pytorch#141951
Approved by: https://github.com/sraikund16, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887, pytorch#141950
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[CI, 3.13] enable dynamo_wrapped unittests in 3.13 (pytorch#141264)
33f35d6 
Pull Request resolved: pytorch#141264
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887, pytorch#141950, pytorch#141951
@williamwen42 williamwen42 mentioned this pull request Dec 5, 2024
Open
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci, 3.13] fix/skip failing numpy 2.0+ dynamo-wrapped tests (pytorch#…
ea06bac 
…141950)

Pull Request resolved: pytorch#141950
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887
pytorch-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci, 3.13] disable segfaulting dynamo-wrapped profiler test (#141951)
ba7e1dc 
Pull Request resolved: #141951
Approved by: https://github.com/sraikund16, https://github.com/atalman
ghstack dependencies: #141409, #142003, #141572, #141577, #141605, #141621, #141623, #141673, #141674, #141858, #141862, #139533, #140733, #141859, #141860, #141886, #141887, #141950
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[CI, 3.13] enable dynamo_wrapped unittests in 3.13 (pytorch#141264)
8eff273 
Pull Request resolved: pytorch#141264
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887, pytorch#141950, pytorch#141951
@atalman atalman mentioned this pull request Dec 12, 2024
Closed
37 tasks
Esquains pushed a commit to Esquains/study1 that referenced this pull request Dec 15, 2024
@williamwen42
[ci, 3.13] fix/skip failing numpy 2.0+ dynamo-wrapped tests
30e0a33 
ghstack-source-id: e83a17b
Pull Request resolved: pytorch/pytorch#141950
@github-actions github-actions bot deleted the gh/williamwen42/183/head branch January 5, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atalman atalman atalman approved these changes

@StrongerXi StrongerXi StrongerXi approved these changes

Assignees

No one assigned

Labels

Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@williamwen42 @atalman @StrongerXi @pytorchmergebot