Introduce thenAsync method on Future #57637
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had proposes a similar method in #48790, although that PR was exposing it to Python and thus requires a bit more work. This PR only introduces this method as a C++ API. Python can be added later. This new method is useful when one wants to use `then` but the callback does perform some async operation itself, and one wants to "reconcile" the future produced inside the callback with the one produced outside. Differential Revision: [D28222809](https://our.internmc.facebook.com/intern/diff/D28222809/) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 34adac2 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
This was referenced May 5, 2021
mrshenli
reviewed
May 6, 2021
| return childFut; | ||
| } | ||
|
|
||
| c10::intrusive_ptr<Future> thenAsync( |
There was a problem hiding this comment.
Looks like there is no usage of this API in this stack. Do we plan to use it in the near future?
I had proposes a similar method in #48790, although that PR was exposing it to Python and thus requires a bit more work. This PR only introduces this method as a C++ API. Python can be added later. This new method is useful when one wants to use `then` but the callback does perform some async operation itself, and one wants to "reconcile" the future produced inside the callback with the one produced outside. Differential Revision: [D28222809](https://our.internmc.facebook.com/intern/diff/D28222809/) [ghstack-poisoned]
I had proposes a similar method in #48790, although that PR was exposing it to Python and thus requires a bit more work. This PR only introduces this method as a C++ API. Python can be added later. This new method is useful when one wants to use `then` but the callback does perform some async operation itself, and one wants to "reconcile" the future produced inside the callback with the one produced outside. Differential Revision: [D28222809](https://our.internmc.facebook.com/intern/diff/D28222809/) [ghstack-poisoned]
This was referenced May 7, 2021
Closed
I had proposes a similar method in #48790, although that PR was exposing it to Python and thus requires a bit more work. This PR only introduces this method as a C++ API. Python can be added later. This new method is useful when one wants to use `then` but the callback does perform some async operation itself, and one wants to "reconcile" the future produced inside the callback with the one produced outside. Differential Revision: [D28222809](https://our.internmc.facebook.com/intern/diff/D28222809/) [ghstack-poisoned]
I had proposes a similar method in #48790, although that PR was exposing it to Python and thus requires a bit more work. This PR only introduces this method as a C++ API. Python can be added later. This new method is useful when one wants to use `then` but the callback does perform some async operation itself, and one wants to "reconcile" the future produced inside the callback with the one produced outside. Differential Revision: [D28222809](https://our.internmc.facebook.com/intern/diff/D28222809/) [ghstack-poisoned]
This was referenced May 17, 2021
mrshenli
approved these changes
May 17, 2021
aten/src/ATen/core/ivalue_inl.h
Outdated
| childFut->setError(std::current_exception()); | ||
| return; | ||
| } | ||
| intermediateFut->addCallback([childFut](Future& intermediateFut) { |
I had proposes a similar method in #48790, although that PR was exposing it to Python and thus requires a bit more work. This PR only introduces this method as a C++ API. Python can be added later. This new method is useful when one wants to use `then` but the callback does perform some async operation itself, and one wants to "reconcile" the future produced inside the callback with the one produced outside. Differential Revision: [D28222809](https://our.internmc.facebook.com/intern/diff/D28222809/) [ghstack-poisoned]
I had proposes a similar method in #48790, although that PR was exposing it to Python and thus requires a bit more work. This PR only introduces this method as a C++ API. Python can be added later. This new method is useful when one wants to use `then` but the callback does perform some async operation itself, and one wants to "reconcile" the future produced inside the callback with the one produced outside. Differential Revision: [D28222809](https://our.internmc.facebook.com/intern/diff/D28222809/) [ghstack-poisoned]
I had proposes a similar method in #48790, although that PR was exposing it to Python and thus requires a bit more work. This PR only introduces this method as a C++ API. Python can be added later. This new method is useful when one wants to use `then` but the callback does perform some async operation itself, and one wants to "reconcile" the future produced inside the callback with the one produced outside. Differential Revision: [D28222809](https://our.internmc.facebook.com/intern/diff/D28222809/) [ghstack-poisoned]
This was referenced May 20, 2021
I had proposes a similar method in #48790, although that PR was exposing it to Python and thus requires a bit more work. This PR only introduces this method as a C++ API. Python can be added later. This new method is useful when one wants to use `then` but the callback does perform some async operation itself, and one wants to "reconcile" the future produced inside the callback with the one produced outside. Differential Revision: [D28222809](https://our.internmc.facebook.com/intern/diff/D28222809/) [ghstack-poisoned]
dgl-intel
pushed a commit
to dgl-intel/pytorch
that referenced
this pull request
May 21, 2021
Pull Request resolved: pytorch#57637 I had proposes a similar method in pytorch#48790, although that PR was exposing it to Python and thus requires a bit more work. This PR only introduces this method as a C++ API. Python can be added later. This new method is useful when one wants to use `then` but the callback does perform some async operation itself, and one wants to "reconcile" the future produced inside the callback with the one produced outside. ghstack-source-id: 129567066 Differential Revision: [D28222809](https://our.internmc.facebook.com/intern/diff/D28222809/)
|
This pull request has been merged in ce2f1c2. |
QYP-842653
pushed a commit
to QYP-842653/Pytorch
that referenced
this pull request
Jul 27, 2021
I had proposes a similar method in pytorch/pytorch#48790, although that PR was exposing it to Python and thus requires a bit more work. This PR only introduces this method as a C++ API. Python can be added later. This new method is useful when one wants to use `then` but the callback does perform some async operation itself, and one wants to "reconcile" the future produced inside the callback with the one produced outside. Differential Revision: [D28222809](https://our.internmc.facebook.com/intern/diff/D28222809/) ghstack-source-id: 128188695 Pull Request resolved: pytorch/pytorch#57637
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
I had proposes a similar method in #48790, although that PR was exposing it to Python and thus requires a bit more work. This PR only introduces this method as a C++ API. Python can be added later.
This new method is useful when one wants to use
thenbut the callback does perform some async operation itself, and one wants to "reconcile" the future produced inside the callback with the one produced outside.Differential Revision: D28222809