Make processPythonExecution return a future #57855
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already had a helper to run Python functions, which was nice (it de-duplicated some code). This helper was however taking a callback which, as I said, isn't as nice as it returning a Future. Hence here I change this. Differential Revision: [D28253846](https://our.internmc.facebook.com/intern/diff/D28253846/) [ghstack-poisoned]
lw
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma,
wayi1 and
zhaojuanmao
as code owners
facebook-github-bot
added
oncall: distributed
💊 CI failures summary and remediationsAs of commit f100675 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
This was referenced May 7, 2021
Closed
We already had a helper to run Python functions, which was nice (it de-duplicated some code). This helper was however taking a callback which, as I said, isn't as nice as it returning a Future. Hence here I change this. Differential Revision: [D28253846](https://our.internmc.facebook.com/intern/diff/D28253846/) [ghstack-poisoned]
We already had a helper to run Python functions, which was nice (it de-duplicated some code). This helper was however taking a callback which, as I said, isn't as nice as it returning a Future. Hence here I change this. Differential Revision: [D28253846](https://our.internmc.facebook.com/intern/diff/D28253846/) [ghstack-poisoned]
This was referenced May 17, 2021
|
Test failures are real: |
|
The test failures turned out to come from the previous PR. |
We already had a helper to run Python functions, which was nice (it de-duplicated some code). This helper was however taking a callback which, as I said, isn't as nice as it returning a Future. Hence here I change this. Differential Revision: [D28253846](https://our.internmc.facebook.com/intern/diff/D28253846/) [ghstack-poisoned]
We already had a helper to run Python functions, which was nice (it de-duplicated some code). This helper was however taking a callback which, as I said, isn't as nice as it returning a Future. Hence here I change this. Differential Revision: [D28253846](https://our.internmc.facebook.com/intern/diff/D28253846/) [ghstack-poisoned]
We already had a helper to run Python functions, which was nice (it de-duplicated some code). This helper was however taking a callback which, as I said, isn't as nice as it returning a Future. Hence here I change this. Differential Revision: [D28253846](https://our.internmc.facebook.com/intern/diff/D28253846/) [ghstack-poisoned]
This was referenced May 20, 2021
We already had a helper to run Python functions, which was nice (it de-duplicated some code). This helper was however taking a callback which, as I said, isn't as nice as it returning a Future. Hence here I change this. Differential Revision: [D28253846](https://our.internmc.facebook.com/intern/diff/D28253846/) [ghstack-poisoned]
dgl-intel
pushed a commit
to dgl-intel/pytorch
that referenced
this pull request
May 21, 2021
Pull Request resolved: pytorch#57855 We already had a helper to run Python functions, which was nice (it de-duplicated some code). This helper was however taking a callback which, as I said, isn't as nice as it returning a Future. Hence here I change this. ghstack-source-id: 129567054 Differential Revision: [D28253846](https://our.internmc.facebook.com/intern/diff/D28253846/)
|
This pull request has been merged in e220a1b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
We already had a helper to run Python functions, which was nice (it de-duplicated some code). This helper was however taking a callback which, as I said, isn't as nice as it returning a Future. Hence here I change this.
Differential Revision: D28253846