Unify fetching RRefs #57859
Closed
Unify fetching RRefs #57859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like with assigning OwnerRRefs, we can also deduplicate the code paths for fetching their values. In fact this was duplicated three times, with different ways of post-processing the value (once for JIT, once for Python, once for autograd). Thanks to future, we can have that logic once, and then connect it to different follow-up steps. Differential Revision: [D28286172](https://our.internmc.facebook.com/intern/diff/D28286172/) [ghstack-poisoned]
lw
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma,
wayi1 and
zhaojuanmao
as code owners
💊 CI failures summary and remediationsAs of commit 9564774 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
 pytorch_linux_xenial_py3_6_gcc5_4_test |
Run tests | 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group.
facebook-github-bot
added
cla signed
oncall: distributed
This was referenced May 7, 2021
Just like with assigning OwnerRRefs, we can also deduplicate the code paths for fetching their values. In fact this was duplicated three times, with different ways of post-processing the value (once for JIT, once for Python, once for autograd). Thanks to future, we can have that logic once, and then connect it to different follow-up steps. Differential Revision: [D28286172](https://our.internmc.facebook.com/intern/diff/D28286172/) [ghstack-poisoned]
Just like with assigning OwnerRRefs, we can also deduplicate the code paths for fetching their values. In fact this was duplicated three times, with different ways of post-processing the value (once for JIT, once for Python, once for autograd). Thanks to future, we can have that logic once, and then connect it to different follow-up steps. Differential Revision: [D28286172](https://our.internmc.facebook.com/intern/diff/D28286172/) [ghstack-poisoned]
This was referenced May 17, 2021
Just like with assigning OwnerRRefs, we can also deduplicate the code paths for fetching their values. In fact this was duplicated three times, with different ways of post-processing the value (once for JIT, once for Python, once for autograd). Thanks to future, we can have that logic once, and then connect it to different follow-up steps. Differential Revision: [D28286172](https://our.internmc.facebook.com/intern/diff/D28286172/) [ghstack-poisoned]
Just like with assigning OwnerRRefs, we can also deduplicate the code paths for fetching their values. In fact this was duplicated three times, with different ways of post-processing the value (once for JIT, once for Python, once for autograd). Thanks to future, we can have that logic once, and then connect it to different follow-up steps. Differential Revision: [D28286172](https://our.internmc.facebook.com/intern/diff/D28286172/) [ghstack-poisoned]
mrshenli
approved these changes
May 18, 2021
| return future->then( | ||
| [autogradContextId = rrefBackwardReq.getAutogradContextId(), | ||
| retainGraph = rrefBackwardReq.retainGraph()](JitFuture& future) { | ||
| // Run backward (TODO: make this async?). |
There was a problem hiding this comment.
@pritamdamania87 is there any concern for making distributed backward async?
There was a problem hiding this comment.
I think this should be fine as long as it is still sync from the user point of view. Although, I think this is an old comment from a previous PR and not from this PR right?
Just like with assigning OwnerRRefs, we can also deduplicate the code paths for fetching their values. In fact this was duplicated three times, with different ways of post-processing the value (once for JIT, once for Python, once for autograd). Thanks to future, we can have that logic once, and then connect it to different follow-up steps. Differential Revision: [D28286172](https://our.internmc.facebook.com/intern/diff/D28286172/) [ghstack-poisoned]
Just like with assigning OwnerRRefs, we can also deduplicate the code paths for fetching their values. In fact this was duplicated three times, with different ways of post-processing the value (once for JIT, once for Python, once for autograd). Thanks to future, we can have that logic once, and then connect it to different follow-up steps. Differential Revision: [D28286172](https://our.internmc.facebook.com/intern/diff/D28286172/) [ghstack-poisoned]
This was referenced May 20, 2021
Just like with assigning OwnerRRefs, we can also deduplicate the code paths for fetching their values. In fact this was duplicated three times, with different ways of post-processing the value (once for JIT, once for Python, once for autograd). Thanks to future, we can have that logic once, and then connect it to different follow-up steps. Differential Revision: [D28286172](https://our.internmc.facebook.com/intern/diff/D28286172/) [ghstack-poisoned]
dgl-intel
pushed a commit
to dgl-intel/pytorch
that referenced
this pull request
May 21, 2021
Pull Request resolved: pytorch#57859 Just like with assigning OwnerRRefs, we can also deduplicate the code paths for fetching their values. In fact this was duplicated three times, with different ways of post-processing the value (once for JIT, once for Python, once for autograd). Thanks to future, we can have that logic once, and then connect it to different follow-up steps. ghstack-source-id: 129567050 Differential Revision: [D28286172](https://our.internmc.facebook.com/intern/diff/D28286172/)
|
This pull request has been merged in 797dff5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Just like with assigning OwnerRRefs, we can also deduplicate the code paths for fetching their values. In fact this was duplicated three times, with different ways of post-processing the value (once for JIT, once for Python, once for autograd). Thanks to future, we can have that logic once, and then connect it to different follow-up steps.
Differential Revision: D28286172