Unify async execution for JIT functions #57852
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another great example of the benefits of Futures. Thanks to the "right abstraction" (i.e., the `thenAsync` method), adding support for async execution becomes trivial, and the code much simpler than what it used to be. Differential Revision: [D28253842](https://our.internmc.facebook.com/intern/diff/D28253842/) [ghstack-poisoned]
lw
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma,
wayi1 and
zhaojuanmao
as code owners
💊 CI failures summary and remediationsAs of commit e891e5b (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
facebook-github-bot
added
the
oncall: distributed
This was referenced May 7, 2021
Closed
Another great example of the benefits of Futures. Thanks to the "right abstraction" (i.e., the `thenAsync` method), adding support for async execution becomes trivial, and the code much simpler than what it used to be. Differential Revision: [D28253842](https://our.internmc.facebook.com/intern/diff/D28253842/) [ghstack-poisoned]
Another great example of the benefits of Futures. Thanks to the "right abstraction" (i.e., the `thenAsync` method), adding support for async execution becomes trivial, and the code much simpler than what it used to be. Differential Revision: [D28253842](https://our.internmc.facebook.com/intern/diff/D28253842/) [ghstack-poisoned]
This was referenced May 17, 2021
mrshenli
approved these changes
May 18, 2021
| } catch (std::exception& e) { | ||
| ownerRRef->setError(std::current_exception()); | ||
| postProcessing(); | ||
| auto asyncPostProcessing = [ownerRRef, postProcessing](JitFuture& jitFuture) { |
Another great example of the benefits of Futures. Thanks to the "right abstraction" (i.e., the `thenAsync` method), adding support for async execution becomes trivial, and the code much simpler than what it used to be. Differential Revision: [D28253842](https://our.internmc.facebook.com/intern/diff/D28253842/) [ghstack-poisoned]
Another great example of the benefits of Futures. Thanks to the "right abstraction" (i.e., the `thenAsync` method), adding support for async execution becomes trivial, and the code much simpler than what it used to be. Differential Revision: [D28253842](https://our.internmc.facebook.com/intern/diff/D28253842/) [ghstack-poisoned]
Another great example of the benefits of Futures. Thanks to the "right abstraction" (i.e., the `thenAsync` method), adding support for async execution becomes trivial, and the code much simpler than what it used to be. Differential Revision: [D28253842](https://our.internmc.facebook.com/intern/diff/D28253842/) [ghstack-poisoned]
This was referenced May 20, 2021
Another great example of the benefits of Futures. Thanks to the "right abstraction" (i.e., the `thenAsync` method), adding support for async execution becomes trivial, and the code much simpler than what it used to be. Differential Revision: [D28253842](https://our.internmc.facebook.com/intern/diff/D28253842/) [ghstack-poisoned]
dgl-intel
pushed a commit
to dgl-intel/pytorch
that referenced
this pull request
May 21, 2021
Pull Request resolved: pytorch#57852 Another great example of the benefits of Futures. Thanks to the "right abstraction" (i.e., the `thenAsync` method), adding support for async execution becomes trivial, and the code much simpler than what it used to be. ghstack-source-id: 129567063 Differential Revision: [D28253842](https://our.internmc.facebook.com/intern/diff/D28253842/)
|
This pull request has been merged in ea2f5bb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Another great example of the benefits of Futures. Thanks to the "right abstraction" (i.e., the
thenAsyncmethod), adding support for async execution becomes trivial, and the code much simpler than what it used to be.Differential Revision: D28253842