Add helpers to manipulate futures #57846
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In later PRs I'll need to create already-completed futures (it'll make sense then, I hope). Here are a few helpers for that, which I'm adding separately to reduce the noise later. Differential Revision: [D28253664](https://our.internmc.facebook.com/intern/diff/D28253664/) [ghstack-poisoned]
lw
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma,
wayi1 and
zhaojuanmao
as code owners
facebook-github-bot
added
oncall: distributed
💊 CI failures summary and remediationsAs of commit 87a5cab (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
This was referenced May 7, 2021
Closed
In later PRs I'll need to create already-completed futures (it'll make sense then, I hope). Here are a few helpers for that, which I'm adding separately to reduce the noise later. Differential Revision: [D28253664](https://our.internmc.facebook.com/intern/diff/D28253664/) [ghstack-poisoned]
In later PRs I'll need to create already-completed futures (it'll make sense then, I hope). Here are a few helpers for that, which I'm adding separately to reduce the noise later. Differential Revision: [D28253664](https://our.internmc.facebook.com/intern/diff/D28253664/) [ghstack-poisoned]
This was referenced May 17, 2021
mrshenli
approved these changes
May 17, 2021
| #endif | ||
| } | ||
|
|
||
| c10::intrusive_ptr<JitFuture> RequestCallbackNoPython::asFuture( |
There was a problem hiding this comment.
Any reason these need to be member functions instead of standalone util functions?
There was a problem hiding this comment.
No "strong" reason, but:
- several other helper functions in this file were defined as methods (e.g.,
cudaAvailable) - we need this to be available both to
RequestCallbackNoPythonand to its subclassRequestCallbackImpl(hence it needs to be public, it cannot go in an unnamed namespace) - by making it a method in a sense we "namespace" it
In later PRs I'll need to create already-completed futures (it'll make sense then, I hope). Here are a few helpers for that, which I'm adding separately to reduce the noise later. Differential Revision: [D28253664](https://our.internmc.facebook.com/intern/diff/D28253664/) [ghstack-poisoned]
In later PRs I'll need to create already-completed futures (it'll make sense then, I hope). Here are a few helpers for that, which I'm adding separately to reduce the noise later. Differential Revision: [D28253664](https://our.internmc.facebook.com/intern/diff/D28253664/) [ghstack-poisoned]
In later PRs I'll need to create already-completed futures (it'll make sense then, I hope). Here are a few helpers for that, which I'm adding separately to reduce the noise later. Differential Revision: [D28253664](https://our.internmc.facebook.com/intern/diff/D28253664/) [ghstack-poisoned]
This was referenced May 20, 2021
In later PRs I'll need to create already-completed futures (it'll make sense then, I hope). Here are a few helpers for that, which I'm adding separately to reduce the noise later. Differential Revision: [D28253664](https://our.internmc.facebook.com/intern/diff/D28253664/) [ghstack-poisoned]
dgl-intel
pushed a commit
to dgl-intel/pytorch
that referenced
this pull request
May 21, 2021
Pull Request resolved: pytorch#57846 In later PRs I'll need to create already-completed futures (it'll make sense then, I hope). Here are a few helpers for that, which I'm adding separately to reduce the noise later. ghstack-source-id: 129567064 Differential Revision: [D28253664](https://our.internmc.facebook.com/intern/diff/D28253664/)
|
This pull request has been merged in 7e1f2b3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
In later PRs I'll need to create already-completed futures (it'll make sense then, I hope). Here are a few helpers for that, which I'm adding separately to reduce the noise later.
Differential Revision: D28253664