Remove getScriptRemoteCallType #57854
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because OwnerRRefs used to be created before their value was computed, we had to figure out their type ahead of time. After the previous diff, we inverted the order of operations, and we can now first compute the result and then create the OwnerRRef. Which means we can just inspect the value to get its type. Much simpler, and much less likely to get it wrong. Differential Revision: [D28253843](https://our.internmc.facebook.com/intern/diff/D28253843/) [ghstack-poisoned]
lw
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma,
wayi1 and
zhaojuanmao
as code owners
facebook-github-bot
added
oncall: distributed
💊 CI failures summary and remediationsAs of commit c21688b (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
This was referenced May 7, 2021
Closed
Because OwnerRRefs used to be created before their value was computed, we had to figure out their type ahead of time. After the previous diff, we inverted the order of operations, and we can now first compute the result and then create the OwnerRRef. Which means we can just inspect the value to get its type. Much simpler, and much less likely to get it wrong. Differential Revision: [D28253843](https://our.internmc.facebook.com/intern/diff/D28253843/) [ghstack-poisoned]
Because OwnerRRefs used to be created before their value was computed, we had to figure out their type ahead of time. After the previous diff, we inverted the order of operations, and we can now first compute the result and then create the OwnerRRef. Which means we can just inspect the value to get its type. Much simpler, and much less likely to get it wrong. Differential Revision: [D28253843](https://our.internmc.facebook.com/intern/diff/D28253843/) [ghstack-poisoned]
This was referenced May 17, 2021
mrshenli
approved these changes
May 18, 2021
| .toRRef()); | ||
| } else { | ||
| ownerRRef = ctx.getOrCreateOwnerRRef(rrefId, returnType); | ||
| ownerRRef = ctx.getOrCreateOwnerRRef(rrefId, jitFuture->elementType()); |
There was a problem hiding this comment.
I assume runJitFunction and runJitOperator can retrieve type correctly, so that we can directly the the elementType from this Future?
There was a problem hiding this comment.
I did look into how they determine the type for the Future that they return, and they seem to be doing some kind of introspection and type inference. Hence to me they seem to be doing the right thing, but I'm not an expert on JIT so I may perhaps miss some nuances?
|
There turned out to be test failures because the inferred types were now "too" precise. In particular it seems before we were just inferring a "base" tensor whereas now we infer a "specialized" tensor. I had to thus relax a check later on to accept tensor subclasses. |
Because OwnerRRefs used to be created before their value was computed, we had to figure out their type ahead of time. After the previous diff, we inverted the order of operations, and we can now first compute the result and then create the OwnerRRef. Which means we can just inspect the value to get its type. Much simpler, and much less likely to get it wrong. Differential Revision: [D28253843](https://our.internmc.facebook.com/intern/diff/D28253843/) [ghstack-poisoned]
Because OwnerRRefs used to be created before their value was computed, we had to figure out their type ahead of time. After the previous diff, we inverted the order of operations, and we can now first compute the result and then create the OwnerRRef. Which means we can just inspect the value to get its type. Much simpler, and much less likely to get it wrong. Differential Revision: [D28253843](https://our.internmc.facebook.com/intern/diff/D28253843/) [ghstack-poisoned]
Because OwnerRRefs used to be created before their value was computed, we had to figure out their type ahead of time. After the previous diff, we inverted the order of operations, and we can now first compute the result and then create the OwnerRRef. Which means we can just inspect the value to get its type. Much simpler, and much less likely to get it wrong. Differential Revision: [D28253843](https://our.internmc.facebook.com/intern/diff/D28253843/) [ghstack-poisoned]
This was referenced May 20, 2021
Because OwnerRRefs used to be created before their value was computed, we had to figure out their type ahead of time. After the previous diff, we inverted the order of operations, and we can now first compute the result and then create the OwnerRRef. Which means we can just inspect the value to get its type. Much simpler, and much less likely to get it wrong. Differential Revision: [D28253843](https://our.internmc.facebook.com/intern/diff/D28253843/) [ghstack-poisoned]
dgl-intel
pushed a commit
to dgl-intel/pytorch
that referenced
this pull request
May 21, 2021
Pull Request resolved: pytorch#57854 Because OwnerRRefs used to be created before their value was computed, we had to figure out their type ahead of time. After the previous diff, we inverted the order of operations, and we can now first compute the result and then create the OwnerRRef. Which means we can just inspect the value to get its type. Much simpler, and much less likely to get it wrong. ghstack-source-id: 129567060 Differential Revision: [D28253843](https://our.internmc.facebook.com/intern/diff/D28253843/)
|
This pull request has been merged in 20d02cb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Because OwnerRRefs used to be created before their value was computed, we had to figure out their type ahead of time. After the previous diff, we inverted the order of operations, and we can now first compute the result and then create the OwnerRRef. Which means we can just inspect the value to get its type. Much simpler, and much less likely to get it wrong.
Differential Revision: D28253843