Deduplicate Python object serialization #57858

lw · 2021-05-07T20:30:15Z

Stack from ghstack:

Fix race condition in TP agent #58753 Fix race condition in TP agent
Make Future always extract DataPtrs in RPC tests #58675 Make Future always extract DataPtrs in RPC tests
Ensure async_execution works with CUDAFuture #56863 Ensure async_execution works with CUDAFuture
Avoid re-doing CUDA stream sync in OwnerRRef #57355 Avoid re-doing CUDA stream sync in OwnerRRef
Make TP agent use streams from Future when sending response #58428 Make TP agent use streams from Future when sending response
Set and propagate devices in RRef completion future #58674 Set and propagate devices in RRef completion future
Set streams when invoking UDFs #58427 Set streams when invoking UDFs
Create CUDA-aware futures in RequestCallback #58426 Create CUDA-aware futures in RequestCallback
Provide pre-extracted DataPtrs when completing a Future with a Message #58425 Provide pre-extracted DataPtrs when completing a Future with a Message
Allow Future::then to return pre-extracted DataPtrs #58424 Allow Future::then to return pre-extracted DataPtrs
Always use intrusive_ptr for Message (2 out of 2) #58423 Always use intrusive_ptr for Message (2 out of 2)
Always use intrusive_ptr for Message (1 out of 2) #58422 Always use intrusive_ptr for Message (1 out of 2)
Prevent using anything other than intrusive_ptr for Future #58421 Prevent using anything other than intrusive_ptr for Future
Migrate remaining shared_ptr<Future> to intrusive_ptr #58420 Migrate remaining shared_ptr to intrusive_ptr
Make remaining autograd methods return futures #57861 Make remaining autograd methods return futures
Make remaining RRef methods return futures #57860 Make remaining RRef methods return futures
Unify fetching RRefs #57859 Unify fetching RRefs
Deduplicate Python object serialization #57858 Deduplicate Python object serialization
Simplify process(Script|Python)(Remote)?Call #57857 Simplify process(Script|Python)(Remote)?Call
Unify assignment of OwnerRRef result #57856 Unify assignment of OwnerRRef result
Make processPythonExecution return a future #57855 Make processPythonExecution return a future
Remove getScriptRemoteCallType #57854 Remove getScriptRemoteCallType
Simplify OwnerRRef completion #57853 Simplify OwnerRRef completion
Unify async execution for JIT functions #57852 Unify async execution for JIT functions
Unify invoking JIT functions #57851 Unify invoking JIT functions
Unify invoking JIT operands #57850 Unify invoking JIT operands
Make some methods of RequestCallback return void instead of bool #57849 Make some methods of RequestCallback return void instead of bool
Centralize setting messageId in RequestCallback #57848 Centralize setting messageId in RequestCallback
Make RequestCallback collect Futures from methods, rather than providing them #57847 Make RequestCallback collect Futures from methods, rather than providing them
Add helpers to manipulate futures #57846 Add helpers to manipulate futures
Reduce overhead when Future invokes callbacks inline #57638 Reduce overhead when Future invokes callbacks inline
Introduce thenAsync method on Future #57637 Introduce thenAsync method on Future

Just a small deduplication, which move complexity our of the way, and ensures consistent error checking.

Differential Revision: D28286174

Just a small deduplication, which move complexity our of the way, and ensures consistent error checking. Differential Revision: [D28286174](https://our.internmc.facebook.com/intern/diff/D28286174/) [ghstack-poisoned]

facebook-github-bot · 2021-05-07T20:30:55Z

💊 CI failures summary and remediations

As of commit ed3f372 (more details on the Dr. CI page):

4/4 failures possibly* introduced in this PR
- 1/4 non-scanned failure(s)

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

Linux CI (pytorch-linux-xenial-py3.6-gcc5.4) / test (1/2)

Step: "Test PyTorch" (full log | diagnosis details | 🔁 rerun)

2021-05-21T12:33:10.7119805Z Build left local git repository checkout dirty

2021-05-21T12:33:05.5769704Z sys	26m27.565s
2021-05-21T12:33:05.5769990Z + assert_git_not_dirty
2021-05-21T12:33:05.5771103Z + [[ pytorch-linux-xenial-py3.6-gcc5.4 != *rocm* ]]
2021-05-21T12:33:05.5771944Z + [[ pytorch-linux-xenial-py3.6-gcc5.4 != *xla* ]]
2021-05-21T12:33:05.5772570Z ++ git status --porcelain
2021-05-21T12:33:10.7117076Z + git_status=' M third_party/nccl/nccl
2021-05-21T12:33:10.7117732Z  M third_party/tensorpipe'
2021-05-21T12:33:10.7118199Z + [[ -n  M third_party/nccl/nccl
2021-05-21T12:33:10.7118638Z  M third_party/tensorpipe ]]
2021-05-21T12:33:10.7119304Z + echo 'Build left local git repository checkout dirty'
2021-05-21T12:33:10.7119805Z Build left local git repository checkout dirty
2021-05-21T12:33:10.7120399Z + echo 'git status --porcelain:'
2021-05-21T12:33:10.7120852Z git status --porcelain:
2021-05-21T12:33:10.7121285Z + echo ' M third_party/nccl/nccl
2021-05-21T12:33:10.7121737Z  M third_party/tensorpipe'
2021-05-21T12:33:10.7122086Z  M third_party/nccl/nccl
2021-05-21T12:33:10.7122514Z  M third_party/tensorpipe
2021-05-21T12:33:10.7122818Z + exit 1
2021-05-21T12:33:10.7123137Z + cleanup
2021-05-21T12:33:10.7123400Z + retcode=1
2021-05-21T12:33:10.7123669Z + set +x

pytorch_xla_linux_bionic_py3_6_clang9_build (2/2)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

May 21 12:32:34 torch_xla/csrc/aten_xla_type.cp... match any declaration in 'torch_xla::AtenXlaType'

May 21 12:32:16 clang-9 -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -I/var/lib/jenkins/workspace/xla -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-bin -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/protobuf_archive/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_protobuf/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/eigen_archive -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_absl -I/var/lib/jenkins/workspace -I/var/lib/jenkins/workspace/torch/csrc -I/var/lib/jenkins/workspace/torch/lib/tmp_install/include -I/opt/conda/lib/python3.6/site-packages/torch/include -I/opt/conda/lib/python3.6/site-packages/torch/include/torch/csrc/api/include -I/opt/conda/lib/python3.6/site-packages/torch/include/TH -I/opt/conda/lib/python3.6/site-packages/torch/include/THC -I/opt/conda/include/python3.6m -c torch_xla/csrc/aten_xla_type_default.cpp -o build/temp.linux-x86_64-3.6/torch_xla/csrc/aten_xla_type_default.o -std=c++14 -Wno-sign-compare -Wno-deprecated-declarations -Wno-return-type -Wno-macro-redefined -Wno-return-std-move -DNDEBUG -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE="_clang" -DPYBIND11_STDLIB="_libstdcpp" -DPYBIND11_BUILD_ABI="_cxxabi1002" -DTORCH_EXTENSION_NAME=_XLAC -D_GLIBCXX_USE_CXX11_ABI=1
May 21 12:32:18 clang-9 -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -I/var/lib/jenkins/workspace/xla -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-bin -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/protobuf_archive/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_protobuf/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/eigen_archive -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_absl -I/var/lib/jenkins/workspace -I/var/lib/jenkins/workspace/torch/csrc -I/var/lib/jenkins/workspace/torch/lib/tmp_install/include -I/opt/conda/lib/python3.6/site-packages/torch/include -I/opt/conda/lib/python3.6/site-packages/torch/include/torch/csrc/api/include -I/opt/conda/lib/python3.6/site-packages/torch/include/TH -I/opt/conda/lib/python3.6/site-packages/torch/include/THC -I/opt/conda/include/python3.6m -c torch_xla/csrc/aten_xla_type.cpp -o build/temp.linux-x86_64-3.6/torch_xla/csrc/aten_xla_type.o -std=c++14 -Wno-sign-compare -Wno-deprecated-declarations -Wno-return-type -Wno-macro-redefined -Wno-return-std-move -DNDEBUG -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE="_clang" -DPYBIND11_STDLIB="_libstdcpp" -DPYBIND11_BUILD_ABI="_cxxabi1002" -DTORCH_EXTENSION_NAME=_XLAC -D_GLIBCXX_USE_CXX11_ABI=1
May 21 12:32:24 clang-9 -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -I/var/lib/jenkins/workspace/xla -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-bin -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/protobuf_archive/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_protobuf/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/eigen_archive -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_absl -I/var/lib/jenkins/workspace -I/var/lib/jenkins/workspace/torch/csrc -I/var/lib/jenkins/workspace/torch/lib/tmp_install/include -I/opt/conda/lib/python3.6/site-packages/torch/include -I/opt/conda/lib/python3.6/site-packages/torch/include/torch/csrc/api/include -I/opt/conda/lib/python3.6/site-packages/torch/include/TH -I/opt/conda/lib/python3.6/site-packages/torch/include/THC -I/opt/conda/include/python3.6m -c torch_xla/csrc/batch_norm.cpp -o build/temp.linux-x86_64-3.6/torch_xla/csrc/batch_norm.o -std=c++14 -Wno-sign-compare -Wno-deprecated-declarations -Wno-return-type -Wno-macro-redefined -Wno-return-std-move -DNDEBUG -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE="_clang" -DPYBIND11_STDLIB="_libstdcpp" -DPYBIND11_BUILD_ABI="_cxxabi1002" -DTORCH_EXTENSION_NAME=_XLAC -D_GLIBCXX_USE_CXX11_ABI=1
May 21 12:32:34 clang-9 -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -I/var/lib/jenkins/workspace/xla -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-bin -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/protobuf_archive/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_protobuf/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/eigen_archive -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_absl -I/var/lib/jenkins/workspace -I/var/lib/jenkins/workspace/torch/csrc -I/var/lib/jenkins/workspace/torch/lib/tmp_install/include -I/opt/conda/lib/python3.6/site-packages/torch/include -I/opt/conda/lib/python3.6/site-packages/torch/include/torch/csrc/api/include -I/opt/conda/lib/python3.6/site-packages/torch/include/TH -I/opt/conda/lib/python3.6/site-packages/torch/include/THC -I/opt/conda/include/python3.6m -c torch_xla/csrc/reduction.cpp -o build/temp.linux-x86_64-3.6/torch_xla/csrc/reduction.o -std=c++14 -Wno-sign-compare -Wno-deprecated-declarations -Wno-return-type -Wno-macro-redefined -Wno-return-std-move -DNDEBUG -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE="_clang" -DPYBIND11_STDLIB="_libstdcpp" -DPYBIND11_BUILD_ABI="_cxxabi1002" -DTORCH_EXTENSION_NAME=_XLAC -D_GLIBCXX_USE_CXX11_ABI=1
May 21 12:32:34 torch_xla/csrc/aten_xla_type.cpp:1238:25: error: out-of-line definition of 'div' does not match any declaration in 'torch_xla::AtenXlaType'
May 21 12:32:34 at::Tensor AtenXlaType::div(const at::Tensor& self, const at::Tensor& other,
May 21 12:32:34                         ^~~
May 21 12:32:34 /var/lib/jenkins/workspace/xla/torch_xla/csrc/aten_xla_type.h:138:74: note: type of 3rd parameter of member declaration does not match definition ('optional<c10::string_view>' vs 'optional<std::string>')
May 21 12:32:34 static at::Tensor div(const at::Tensor & self, const at::Tensor & other, c10::optional<c10::string_view> rounding_mode);
May 21 12:32:34                                                                          ^
May 21 12:32:34 torch_xla/csrc/aten_xla_type.cpp:1257:26: error: out-of-line definition of 'div_' does not match any declaration in 'torch_xla::AtenXlaType'
May 21 12:32:34 at::Tensor& AtenXlaType::div_(at::Tensor& self, const at::Tensor& other,
May 21 12:32:34                          ^~~~
May 21 12:32:34 /var/lib/jenkins/workspace/xla/torch_xla/csrc/aten_xla_type.h:340:71: note: type of 3rd parameter of member declaration does not match definition ('optional<c10::string_view>' vs 'optional<std::string>')
May 21 12:32:34 static at::Tensor & div_(at::Tensor & self, const at::Tensor & other, c10::optional<c10::string_view> rounding_mode);
May 21 12:32:34                                                                       ^
May 21 12:32:39 2 errors generated.
May 21 12:32:39 clang-9 -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -I/var/lib/jenkins/workspace/xla -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-bin -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/protobuf_archive/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_protobuf/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/eigen_archive -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_absl -I/var/lib/jenkins/workspace -I/var/lib/jenkins/workspace/torch/csrc -I/var/lib/jenkins/workspace/torch/lib/tmp_install/include -I/opt/conda/lib/python3.6/site-packages/torch/include -I/opt/conda/lib/python3.6/site-packages/torch/include/torch/csrc/api/include -I/opt/conda/lib/python3.6/site-packages/torch/include/TH -I/opt/conda/lib/python3.6/site-packages/torch/include/THC -I/opt/conda/include/python3.6m -c torch_xla/csrc/matrix.cpp -o build/temp.linux-x86_64-3.6/torch_xla/csrc/matrix.o -std=c++14 -Wno-sign-compare -Wno-deprecated-declarations -Wno-return-type -Wno-macro-redefined -Wno-return-std-move -DNDEBUG -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE="_clang" -DPYBIND11_STDLIB="_libstdcpp" -DPYBIND11_BUILD_ABI="_cxxabi1002" -DTORCH_EXTENSION_NAME=_XLAC -D_GLIBCXX_USE_CXX11_ABI=1
May 21 12:32:45 1 warning generated.
May 21 12:32:45 clang-9 -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -I/var/lib/jenkins/workspace/xla -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-bin -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/protobuf_archive/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_protobuf/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/eigen_archive -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_absl -I/var/lib/jenkins/workspace -I/var/lib/jenkins/workspace/torch/csrc -I/var/lib/jenkins/workspace/torch/lib/tmp_install/include -I/opt/conda/lib/python3.6/site-packages/torch/include -I/opt/conda/lib/python3.6/site-packages/torch/include/torch/csrc/api/include -I/opt/conda/lib/python3.6/site-packages/torch/include/TH -I/opt/conda/lib/python3.6/site-packages/torch/include/THC -I/opt/conda/include/python3.6m -c torch_xla/csrc/pooling.cpp -o build/temp.linux-x86_64-3.6/torch_xla/csrc/pooling.o -std=c++14 -Wno-sign-compare -Wno-deprecated-declarations -Wno-return-type -Wno-macro-redefined -Wno-return-std-move -DNDEBUG -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE="_clang" -DPYBIND11_STDLIB="_libstdcpp" -DPYBIND11_BUILD_ABI="_cxxabi1002" -DTORCH_EXTENSION_NAME=_XLAC -D_GLIBCXX_USE_CXX11_ABI=1
May 21 12:32:49 clang-9 -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -I/var/lib/jenkins/workspace/xla -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-bin -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/protobuf_archive/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_protobuf/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/eigen_archive -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_absl -I/var/lib/jenkins/workspace -I/var/lib/jenkins/workspace/torch/csrc -I/var/lib/jenkins/workspace/torch/lib/tmp_install/include -I/opt/conda/lib/python3.6/site-packages/torch/include -I/opt/conda/lib/python3.6/site-packages/torch/include/torch/csrc/api/include -I/opt/conda/lib/python3.6/site-packages/torch/include/TH -I/opt/conda/lib/python3.6/site-packages/torch/include/THC -I/opt/conda/include/python3.6m -c torch_xla/csrc/aten_xla_bridge.cpp -o build/temp.linux-x86_64-3.6/torch_xla/csrc/aten_xla_bridge.o -std=c++14 -Wno-sign-compare -Wno-deprecated-declarations -Wno-return-type -Wno-macro-redefined -Wno-return-std-move -DNDEBUG -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE="_clang" -DPYBIND11_STDLIB="_libstdcpp" -DPYBIND11_BUILD_ABI="_cxxabi1002" -DTORCH_EXTENSION_NAME=_XLAC -D_GLIBCXX_USE_CXX11_ABI=1

1 failure not recognized by patterns:

Job	Step	Action
^{pytorch_linux_bionic_py3_8_gcc9_coverage_test2}	^{Run tests}	🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Just a small deduplication, which move complexity our of the way, and ensures consistent error checking. Differential Revision: [D28286174](https://our.internmc.facebook.com/intern/diff/D28286174/) [ghstack-poisoned]

mrshenli

This is great!

Just a small deduplication, which move complexity our of the way, and ensures consistent error checking. Differential Revision: [D28286174](https://our.internmc.facebook.com/intern/diff/D28286174/) [ghstack-poisoned]

Pull Request resolved: pytorch#57858 Just a small deduplication, which move complexity our of the way, and ensures consistent error checking. ghstack-source-id: 129567056 Differential Revision: [D28286174](https://our.internmc.facebook.com/intern/diff/D28286174/)

facebook-github-bot · 2021-05-21T20:16:33Z

This pull request has been merged in b9b41f6.

Deduplicate Python object serialization

1f966d0

Just a small deduplication, which move complexity our of the way, and ensures consistent error checking. Differential Revision: [D28286174](https://our.internmc.facebook.com/intern/diff/D28286174/) [ghstack-poisoned]

lw requested review from H-Huang, mingzhe09088, mrshenli, pritamdamania87, rohan-varma, wayi1 and zhaojuanmao as code owners May 7, 2021 20:30

facebook-github-bot added oncall: distributed Add this issue/PR to distributed oncall triage queue cla signed labels May 7, 2021

lw added 2 commits May 17, 2021 03:53

Update on "Deduplicate Python object serialization"

2ca6516

Just a small deduplication, which move complexity our of the way, and ensures consistent error checking. Differential Revision: [D28286174](https://our.internmc.facebook.com/intern/diff/D28286174/) [ghstack-poisoned]

Update on "Deduplicate Python object serialization"

9d4524f

Just a small deduplication, which move complexity our of the way, and ensures consistent error checking. Differential Revision: [D28286174](https://our.internmc.facebook.com/intern/diff/D28286174/) [ghstack-poisoned]

Update on "Deduplicate Python object serialization"

0e9a3ed

Just a small deduplication, which move complexity our of the way, and ensures consistent error checking. Differential Revision: [D28286174](https://our.internmc.facebook.com/intern/diff/D28286174/) [ghstack-poisoned]

mrshenli approved these changes May 18, 2021

View reviewed changes

lw added 3 commits May 18, 2021 13:06

Update on "Deduplicate Python object serialization"

92aefac

Just a small deduplication, which move complexity our of the way, and ensures consistent error checking. Differential Revision: [D28286174](https://our.internmc.facebook.com/intern/diff/D28286174/) [ghstack-poisoned]

Update on "Deduplicate Python object serialization"

ece1552

Just a small deduplication, which move complexity our of the way, and ensures consistent error checking. Differential Revision: [D28286174](https://our.internmc.facebook.com/intern/diff/D28286174/) [ghstack-poisoned]

Update on "Deduplicate Python object serialization"

2ee0983

Just a small deduplication, which move complexity our of the way, and ensures consistent error checking. Differential Revision: [D28286174](https://our.internmc.facebook.com/intern/diff/D28286174/) [ghstack-poisoned]

This was referenced May 20, 2021

Set and propagate devices in RRef completion future #58674

Closed

Avoid re-doing CUDA stream sync in OwnerRRef #57355

Closed

Ensure async_execution works with CUDAFuture #56863

Closed

Make Future always extract DataPtrs in RPC tests #58675

Closed

Update on "Deduplicate Python object serialization"

ed3f372

Just a small deduplication, which move complexity our of the way, and ensures consistent error checking. Differential Revision: [D28286174](https://our.internmc.facebook.com/intern/diff/D28286174/) [ghstack-poisoned]

lw mentioned this pull request May 21, 2021

Fix race condition in TP agent #58753

Closed

facebook-github-bot closed this in b9b41f6 May 21, 2021

facebook-github-bot added the Merged label May 21, 2021

facebook-github-bot deleted the gh/lw/172/head branch May 25, 2021 14:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Deduplicate Python object serialization #57858

Deduplicate Python object serialization #57858

Uh oh!

lw commented May 7, 2021 •

edited

Loading

Uh oh!

facebook-github-bot commented May 7, 2021 •

edited

Loading

Uh oh!

mrshenli left a comment

Uh oh!

facebook-github-bot commented May 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Deduplicate Python object serialization #57858

Deduplicate Python object serialization #57858

Uh oh!

Conversation

lw commented May 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented May 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

🕵️ 2 new failures recognized by patterns

Linux CI (pytorch-linux-xenial-py3.6-gcc5.4) / test (1/2)

pytorch_xla_linux_bionic_py3_6_clang9_build (2/2)

1 failure not recognized by patterns:

Uh oh!

mrshenli left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented May 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lw commented May 7, 2021 •

edited

Loading

facebook-github-bot commented May 7, 2021 •

edited

Loading