Allow Future::then to return pre-extracted DataPtrs #58424
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In CUDA mode, Future must inspect its value and extract DataPtrs. However some types are not supported, for example the C++/JIT custom classes, which include Message, which is widely used in RPC. Hence for these scenarios we allow the user to perform the custom DataPtr extraction on their own, and pass the pre-extracted DataPtrs. Note that `markCompleted` already allowed users to pass in pre-extracted DataPtrs, hence this PR simply extends this possibility to the `then` method too. Differential Revision: [D28474880](https://our.internmc.facebook.com/intern/diff/D28474880/) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 5565bab (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
This was referenced May 17, 2021
Closed
In CUDA mode, Future must inspect its value and extract DataPtrs. However some types are not supported, for example the C++/JIT custom classes, which include Message, which is widely used in RPC. Hence for these scenarios we allow the user to perform the custom DataPtr extraction on their own, and pass the pre-extracted DataPtrs. Note that `markCompleted` already allowed users to pass in pre-extracted DataPtrs, hence this PR simply extends this possibility to the `then` method too. Differential Revision: [D28474880](https://our.internmc.facebook.com/intern/diff/D28474880/) [ghstack-poisoned]
In CUDA mode, Future must inspect its value and extract DataPtrs. However some types are not supported, for example the C++/JIT custom classes, which include Message, which is widely used in RPC. Hence for these scenarios we allow the user to perform the custom DataPtr extraction on their own, and pass the pre-extracted DataPtrs. Note that `markCompleted` already allowed users to pass in pre-extracted DataPtrs, hence this PR simply extends this possibility to the `then` method too. Differential Revision: [D28474880](https://our.internmc.facebook.com/intern/diff/D28474880/) [ghstack-poisoned]
mrshenli
approved these changes
May 18, 2021
| addCallback([childFut, | ||
| cb = std::move(callback)](Future& parentFut) mutable { | ||
| try { | ||
| guts::if_constexpr<std::is_convertible< |
There was a problem hiding this comment.
curious, what's the difference between guts::if_constexpr and if constexpr? Is it because we are not using C++17 yet?
There was a problem hiding this comment.
Correct. In fact, guts::if_constexpr will use if constexpr internally if available, but will fall back onto a C++-14-compatible polyfill if not.
aten/src/ATen/core/ivalue_inl.h
Outdated
| guts::if_constexpr<std::is_convertible< | ||
| typename std::result_of<T && (Future&)>::type, | ||
| IValueWithDataPtrs>::value>( | ||
| [&](auto _) { |
There was a problem hiding this comment.
any reason for using "_" instead of giving it a name?
There was a problem hiding this comment.
I did it because this was the example in the docstring of guts::if_constexpr. I'll rename it to identity, hopefully that's clearer.
aten/src/ATen/core/ivalue_inl.h
Outdated
| [&](auto _) { | ||
| IValue value; | ||
| std::vector<std::reference_wrapper<const at::DataPtr>> dataPtrs; | ||
| std::tie(value, dataPtrs) = _(cb)(parentFut); |
There was a problem hiding this comment.
would I be correct that _(cb) converts the cb type to IValueWithDataPtrs && (Future &)?
There was a problem hiding this comment.
I'm not sure about the details, but according to the docstring of guts::if_constexpr we need _ in order to "trick" the compiler into delaying type-checking and thus avoid it complaining about the fact that cb has different types in the two branches. In practice, _ is the identity function, so it should have no effect.
In CUDA mode, Future must inspect its value and extract DataPtrs. However some types are not supported, for example the C++/JIT custom classes, which include Message, which is widely used in RPC. Hence for these scenarios we allow the user to perform the custom DataPtr extraction on their own, and pass the pre-extracted DataPtrs. Note that `markCompleted` already allowed users to pass in pre-extracted DataPtrs, hence this PR simply extends this possibility to the `then` method too. Differential Revision: [D28474880](https://our.internmc.facebook.com/intern/diff/D28474880/) [ghstack-poisoned]
In CUDA mode, Future must inspect its value and extract DataPtrs. However some types are not supported, for example the C++/JIT custom classes, which include Message, which is widely used in RPC. Hence for these scenarios we allow the user to perform the custom DataPtr extraction on their own, and pass the pre-extracted DataPtrs. Note that `markCompleted` already allowed users to pass in pre-extracted DataPtrs, hence this PR simply extends this possibility to the `then` method too. Differential Revision: [D28474880](https://our.internmc.facebook.com/intern/diff/D28474880/) [ghstack-poisoned]
In CUDA mode, Future must inspect its value and extract DataPtrs. However some types are not supported, for example the C++/JIT custom classes, which include Message, which is widely used in RPC. Hence for these scenarios we allow the user to perform the custom DataPtr extraction on their own, and pass the pre-extracted DataPtrs. Note that `markCompleted` already allowed users to pass in pre-extracted DataPtrs, hence this PR simply extends this possibility to the `then` method too. Differential Revision: [D28474880](https://our.internmc.facebook.com/intern/diff/D28474880/) [ghstack-poisoned]
This was referenced May 20, 2021
In CUDA mode, Future must inspect its value and extract DataPtrs. However some types are not supported, for example the C++/JIT custom classes, which include Message, which is widely used in RPC. Hence for these scenarios we allow the user to perform the custom DataPtr extraction on their own, and pass the pre-extracted DataPtrs. Note that `markCompleted` already allowed users to pass in pre-extracted DataPtrs, hence this PR simply extends this possibility to the `then` method too. Differential Revision: [D28474880](https://our.internmc.facebook.com/intern/diff/D28474880/) [ghstack-poisoned]
dgl-intel
pushed a commit
to dgl-intel/pytorch
that referenced
this pull request
May 21, 2021
Pull Request resolved: pytorch#58424 In CUDA mode, Future must inspect its value and extract DataPtrs. However some types are not supported, for example the C++/JIT custom classes, which include Message, which is widely used in RPC. Hence for these scenarios we allow the user to perform the custom DataPtr extraction on their own, and pass the pre-extracted DataPtrs. Note that `markCompleted` already allowed users to pass in pre-extracted DataPtrs, hence this PR simply extends this possibility to the `then` method too. ghstack-source-id: 129567044 Differential Revision: [D28474880](https://our.internmc.facebook.com/intern/diff/D28474880/)
|
This pull request has been merged in a0ee299. |
|
This pull request has been reverted by c1a9bef. |
lw
added a commit
that referenced
this pull request
May 31, 2021
Reland of #58424 In CUDA mode, Future must inspect its value and extract DataPtrs. However some types are not supported, for example the C++/JIT custom classes, which include Message, which is widely used in RPC. Hence for these scenarios we allow the user to perform the custom DataPtr extraction on their own, and pass the pre-extracted DataPtrs. Note that `markCompleted` already allowed users to pass in pre-extracted DataPtrs, hence this PR simply extends this possibility to the `then` method too. Differential Revision: [D28623890](https://our.internmc.facebook.com/intern/diff/D28623890/) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 2, 2021
Summary: Pull Request resolved: #59207 Reland of #58424 In CUDA mode, Future must inspect its value and extract DataPtrs. However some types are not supported, for example the C++/JIT custom classes, which include Message, which is widely used in RPC. Hence for these scenarios we allow the user to perform the custom DataPtr extraction on their own, and pass the pre-extracted DataPtrs. Note that `markCompleted` already allowed users to pass in pre-extracted DataPtrs, hence this PR simply extends this possibility to the `then` method too. ghstack-source-id: 130202846 Test Plan: Used in next PR. Reviewed By: mrshenli Differential Revision: D28623890 fbshipit-source-id: 468c5308b40774ba0a778b195add0e0845c1929e
deniskokarev
pushed a commit
to deniskokarev/pytorch
that referenced
this pull request
Jun 9, 2021
…#59207) Summary: Pull Request resolved: pytorch#59207 Reland of pytorch#58424 In CUDA mode, Future must inspect its value and extract DataPtrs. However some types are not supported, for example the C++/JIT custom classes, which include Message, which is widely used in RPC. Hence for these scenarios we allow the user to perform the custom DataPtr extraction on their own, and pass the pre-extracted DataPtrs. Note that `markCompleted` already allowed users to pass in pre-extracted DataPtrs, hence this PR simply extends this possibility to the `then` method too. ghstack-source-id: 130202846 Test Plan: Used in next PR. Reviewed By: mrshenli Differential Revision: D28623890 fbshipit-source-id: 468c5308b40774ba0a778b195add0e0845c1929e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
In CUDA mode, Future must inspect its value and extract DataPtrs. However some types are not supported, for example the C++/JIT custom classes, which include Message, which is widely used in RPC. Hence for these scenarios we allow the user to perform the custom DataPtr extraction on their own, and pass the pre-extracted DataPtrs.
Note that
markCompletedalready allowed users to pass in pre-extracted DataPtrs, hence this PR simply extends this possibility to thethenmethod too.Differential Revision: D28474880